Skip to content

Commit 1744604

Browse files
authored
Merge pull request #341 from magento-obsessive-owls/PB-300
[Owls] PB-300: Upgrade test: preview.js:50 Uncaught TypeError: Cannot read property 'children' of undefined
2 parents 2bfdd89 + b761352 commit 1744604

File tree

2 files changed

+11
-6
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml/web

2 files changed

+11
-6
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/products/preview.js

Lines changed: 6 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/products/preview.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,12 @@ export default class Preview extends BasePreview {
6767

6868
// Redraw slider after content type gets redrawn
6969
events.on("contentType:redrawAfter", (args: ContentTypeAfterRenderEventParamsInterface) => {
70-
const $element = $(this.element.children);
70+
if (this.element && this.element.children) {
71+
const $element = $(this.element.children);
7172

72-
if (args.element && this.element && $element.closest(args.element).length) {
73-
$element.slick("setPosition");
73+
if (args.element && $element.closest(args.element).length) {
74+
$element.slick("setPosition");
75+
}
7476
}
7577
});
7678
}

0 commit comments

Comments
 (0)