Skip to content

Commit 16ac37c

Browse files
committed
PB-46: Parallax Is Broken On Slide Out Forms
- Remove imgSrc so we retain background-image - Fix going into full screen causing parallax to be incorrectly displayed
1 parent 8de36f5 commit 16ac37c

File tree

2 files changed

+11
-2
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml/web

2 files changed

+11
-2
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/row/preview.js

Lines changed: 6 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/row/preview.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ export default class Preview extends PreviewCollection {
5252
jarallax(
5353
this.element,
5454
{
55-
imgSrc: (this.contentType.dataStore.get("background_image") as any[])[0].url as string,
5655
imgPosition: this.contentType.dataStore.get("background_position") as string || "50% 50%",
5756
imgRepeat: (
5857
(this
@@ -93,6 +92,11 @@ export default class Preview extends PreviewCollection {
9392
this.buildJarallax();
9493
}
9594
});
95+
events.on(`stage:${this.contentType.stageId}:fullScreenModeChangeAfter`, () => {
96+
_.delay(() => {
97+
this.buildJarallax();
98+
}, 350);
99+
});
96100
}
97101

98102
/**

0 commit comments

Comments
 (0)