Skip to content

Commit 1608645

Browse files
committed
MC-5405: Column Minimum Height Issues
- fix existing tests to account for new min height for column
1 parent a1edcf6 commit 1608645

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/ColumnData.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,6 @@
4747
<data key="fieldName">appearance</data>
4848
<data key="value">align-top</data>
4949
</entity>
50-
<!-- Minimum Height -->
51-
<entity name="PageBuilderEmptyColumnHeightProperty" type="pagebuilder_column_min_height_property">
52-
<data key="value">190</data>
53-
<data key="valueWithPadding">210</data>
54-
</entity>
5550
<!-- Background Color -->
5651
<entity name="PageBuilderBackgroundColorProperty" type="pagebuilder_column_background_color_property">
5752
<data key="name">Background Color</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnContentTest.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,9 @@
144144
<actionGroup ref="dragContentTypeToStage" stepKey="dragColumnIntoStage">
145145
<argument name="contentType" value="PageBuilderColumnContentType"/>
146146
</actionGroup>
147+
<actionGroup ref="removeEmptyContentTypeFromStage" stepKey="removeColumn1">
148+
<argument name="contentType" value="PageBuilderColumnContentType"/>
149+
</actionGroup>
147150
<comment userInput="Enter column min height 200 px" stepKey="commentEnterColumnMinHeight"/>
148151
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditPanel">
149152
<argument name="contentType" value="PageBuilderColumnContentType"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
<actionGroup ref="validateContentTypeHeightOnStageWithoutPadding" stepKey="assertInitialColumnHeightMatchesExpected">
4545
<argument name="contentType" value="PageBuilderColumnContentType"/>
4646
<argument name="index" value="1"/>
47-
<argument name="containerDefaultHeight" value="PageBuilderEmptyColumnHeightProperty"/>
47+
<argument name="containerDefaultHeight" value="PageBuilderMinHeightProperty_300"/>
4848
</actionGroup>
4949
<executeJS function="{{PageBuilderStage.computedHeightOnStage(PageBuilderColumnContentType.role,'1')}}" stepKey="actualStageInitialColumnHeight"/>
5050
<comment userInput="Validate Row Height adjusts to Column Height" stepKey="commentValidateRowHeightAdjustToColumn"/>

0 commit comments

Comments
 (0)