Skip to content

Commit 15f1b38

Browse files
committed
Merge remote-tracking branch 'origin/MC-2434-column-resize-test' into cms-team-1-delivery
2 parents 415ff4e + 30f3e4b commit 15f1b38

File tree

1 file changed

+28
-28
lines changed

1 file changed

+28
-28
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnResizingTest.xml

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
-->
88
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
10-
<test name="ColumnResize1v6">
10+
<test name="ColumnResize1to0">
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Column"/>
14-
<title value="Resize Column: 6:0 Ratio"/>
15-
<description value="A user should be able to resize a columns to achieve a ratio of 6:0."/>
14+
<title value="Resize Column: 1:0 Ratio"/>
15+
<description value="A user should be able to resize a columns to achieve a ratio of 1:0."/>
1616
<severity value="CRITICAL"/>
1717
<useCaseId value="MC-950"/>
1818
<testCaseId value="MC-2717"/>
@@ -40,8 +40,8 @@
4040
<!-- Assert the initial width classes are correct -->
4141
<waitForElement selector="{{ColumnOnBackend.columnByIndexAndWidthClass('1','50')}}" stepKey="assertInitialWidthClass1"/>
4242
<waitForElement selector="{{ColumnOnBackend.columnByIndexAndWidthClass('2','50')}}" stepKey="assertInitialWidthClass2"/>
43-
<!-- Change Columns To 6:0 Ratio -->
44-
<comment userInput="Change Columns To 6:0 Ratio" stepKey="context2"/>
43+
<!-- Change Columns To 1:0 Ratio -->
44+
<comment userInput="Change Columns To 1:0 Ratio" stepKey="context2"/>
4545
<actionGroup ref="removeContentTypeFromStageByIndex" stepKey="removeSecondColumn">
4646
<argument name="contentType" value="PageBuilderColumnContentType"/>
4747
<argument name="contentTypeNumber" value="2"/>
@@ -93,7 +93,7 @@
9393
<actualResult type="variable">columnRatioFrontend</actualResult>
9494
</assertEquals>
9595
</test>
96-
<test name="ColumnResize1v5And1v1">
96+
<test name="ColumnResize5to1">
9797
<annotations>
9898
<features value="PageBuilder"/>
9999
<stories value="Column"/>
@@ -180,12 +180,12 @@
180180
<actualResult type="variable">columnRatioFrontend</actualResult>
181181
</assertEquals>
182182
</test>
183-
<test name="ColumnResize1v4And1v2">
183+
<test name="ColumnResize2to1">
184184
<annotations>
185185
<features value="PageBuilder"/>
186186
<stories value="Column"/>
187-
<title value="Resize Column: 4:2 Ratio"/>
188-
<description value="A user should be able to resize a columns to achieve a ratio of 4:2."/>
187+
<title value="Resize Column: 2:1 Ratio"/>
188+
<description value="A user should be able to resize a columns to achieve a ratio of 2:1."/>
189189
<severity value="CRITICAL"/>
190190
<testCaseId value="MC-2867"/>
191191
<group value="pagebuilder"/>
@@ -206,8 +206,8 @@
206206
<actionGroup ref="dragContentTypeToStage" stepKey="dragColumnIntoStage">
207207
<argument name="contentType" value="PageBuilderColumnContentType"/>
208208
</actionGroup>
209-
<!-- Change Columns To 4:2 Ratio -->
210-
<comment userInput="Change Columns To 4:2 Ratio" stepKey="context1"/>
209+
<!-- Change Columns To 2:1 Ratio -->
210+
<comment userInput="Change Columns To 2:1 Ratio" stepKey="context1"/>
211211
<actionGroup ref="dragContentTypeToContainer" stepKey="dragColumnIntoStage2">
212212
<argument name="contentType" value="PageBuilderColumnContentType"/>
213213
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
@@ -271,7 +271,7 @@
271271
<actualResult type="variable">columnRatioFrontend</actualResult>
272272
</assertEquals>
273273
</test>
274-
<test name="ColumnResize1v4And2v1">
274+
<test name="ColumnResize4to1to1">
275275
<annotations>
276276
<features value="PageBuilder"/>
277277
<stories value="Column"/>
@@ -282,9 +282,6 @@
282282
<group value="pagebuilder"/>
283283
<group value="pagebuilder-column"/>
284284
<group value="pagebuilder-columnResize"/>
285-
<skip>
286-
<issueId value="MC-2434"/>
287-
</skip>
288285
</annotations>
289286
<before>
290287
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -300,18 +297,21 @@
300297
<actionGroup ref="dragContentTypeToStage" stepKey="dragColumnIntoStage">
301298
<argument name="contentType" value="PageBuilderColumnContentType"/>
302299
</actionGroup>
303-
<!-- Grab grid guide width (-8 due to how picky the guide is) -->
300+
<!-- Grab grid guide width -->
304301
<comment userInput="Grab grid guide width" stepKey="context0"/>
305-
<executeJS function="return document.querySelector('{{ColumnOnBackend.columnResizeGridLine('8')}}').clientWidth-8" stepKey="guideWidth"/>
302+
<executeJS function="return document.querySelector('{{ColumnOnBackend.columnResizeGridLine('1')}}').clientWidth" stepKey="guideWidth"/>
306303
<!-- Change Columns To 4:1:1 Ratio -->
307304
<comment userInput="Change Columns To 4:1:1 Ratio" stepKey="context1"/>
308-
<dragAndDrop selector1="{{ColumnOnBackend.columnX('1')}} {{ColumnOnBackend.columnResizeHandle}}" selector2="{{ColumnOnBackend.columnResizeGridLine('8')}}" x="$guideWidth" stepKey="resizeColumn1ToFour"/>
305+
<dragAndDrop selector1="{{ColumnOnBackend.columnX('1')}} {{ColumnOnBackend.columnResizeHandle}}" selector2="{{ColumnOnBackend.columnResizeGridLine('8')}}" x="$guideWidth" stepKey="resizeColumn1ToEight"/>
309306
<actionGroup ref="dragContentTypeToContainer" stepKey="dragColumnIntoStage2">
310307
<argument name="contentType" value="PageBuilderColumnContentType"/>
311308
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
312309
<argument name="containerTargetIndex" value="2"/>
313310
</actionGroup>
314311
<dragAndDrop selector1="{{ColumnOnBackend.columnX('2')}} {{ColumnOnBackend.columnResizeHandle}}" selector2="{{ColumnOnBackend.columnResizeGridLine('10')}}" x="$guideWidth" stepKey="resizeColumnToTwo"/>
312+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
313+
<argument name="group" value="PageBuilderDividerContentType"/>
314+
</actionGroup>
315315
<actionGroup ref="dragContentTypeToContainer" stepKey="dragIntoStage1">
316316
<argument name="contentType" value="PageBuilderDividerContentType"/>
317317
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
@@ -384,12 +384,12 @@
384384
<actualResult type="variable">columnRatioFrontend2</actualResult>
385385
</assertEquals>
386386
</test>
387-
<test name="ColumnResizeColumn2v3">
387+
<test name="ColumnResize1to1">
388388
<annotations>
389389
<features value="PageBuilder"/>
390390
<stories value="Column"/>
391-
<title value="Resize Column: 3:3 Ratio"/>
392-
<description value="A user should be able to resize a columns to achieve a ratio of 3:3."/>
391+
<title value="Resize Column: 1:1 Ratio"/>
392+
<description value="A user should be able to resize a columns to achieve a ratio of 1:1."/>
393393
<severity value="CRITICAL"/>
394394
<testCaseId value="MC-2837"/>
395395
<group value="pagebuilder"/>
@@ -462,7 +462,7 @@
462462
<actualResult type="variable">columnRatioFrontend</actualResult>
463463
</assertEquals>
464464
</test>
465-
<test name="ColumnResize1v3And1v2And1v1">
465+
<test name="ColumnResize3to2to1">
466466
<annotations>
467467
<features value="PageBuilder"/>
468468
<stories value="Column"/>
@@ -574,7 +574,7 @@
574574
<actualResult type="variable">columnRatioFrontend2</actualResult>
575575
</assertEquals>
576576
</test>
577-
<test name="ColumnResize1v3And3v1">
577+
<test name="ColumnResize3to1to1to1">
578578
<annotations>
579579
<features value="PageBuilder"/>
580580
<stories value="Column"/>
@@ -713,12 +713,12 @@
713713
<actualResult type="variable">columnRatioFrontend3</actualResult>
714714
</assertEquals>
715715
</test>
716-
<test name="ColumnResize3v2">
716+
<test name="ColumnResize1to1to1">
717717
<annotations>
718718
<features value="PageBuilder"/>
719719
<stories value="Column"/>
720-
<title value="Resize Column: 2:2:2 Ratio"/>
721-
<description value="A user should be able to resize a columns to achieve a ratio of 2:2:2."/>
720+
<title value="Resize Column: 1:1:1 Ratio"/>
721+
<description value="A user should be able to resize a columns to achieve a ratio of 1:1:1."/>
722722
<severity value="CRITICAL"/>
723723
<testCaseId value="MC-2592"/>
724724
<group value="pagebuilder"/>
@@ -742,8 +742,8 @@
742742
<!-- Grab grid guide width -->
743743
<comment userInput="Grab grid guide width" stepKey="context0"/>
744744
<executeJS function="return document.querySelector('{{ColumnOnBackend.columnResizeGridLine('4')}}').clientWidth" stepKey="guideWidth"/>
745-
<!-- Change Columns To 2:2:2 Ratio -->
746-
<comment userInput="Change Columns To 2:2:2 Ratio" stepKey="context1"/>
745+
<!-- Change Columns To 1:1:1 Ratio -->
746+
<comment userInput="Change Columns To 1:1:1 Ratio" stepKey="context1"/>
747747
<actionGroup ref="dragContentTypeToContainer" stepKey="dragColumnIntoStage2">
748748
<argument name="contentType" value="PageBuilderColumnContentType"/>
749749
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>

0 commit comments

Comments
 (0)