Skip to content

Commit 157828a

Browse files
anthoulaanthoula
committed
MC-5432: Contained Row Appearance Renders Too Small When In Smaller Container or in Block/Dynamic Block
- remove unreliable word wrap tests - remove associated data and action group
1 parent 31e8add commit 157828a

8 files changed

+0
-550
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/WYSIWYGActionGroup.xml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -161,19 +161,4 @@
161161
<actualResult type="variable">textareaValue</actualResult>
162162
</assertEquals>
163163
</actionGroup>
164-
<actionGroup name="validateContentWordHeight">
165-
<arguments>
166-
<argument name="page"/>
167-
<argument name="height" type="string"/>
168-
<argument name="index" defaultValue="1" type="string"/>
169-
</arguments>
170-
<!-- Validate content height -->
171-
<comment userInput="Validate content height" stepKey="commentValidateContentHeight"/>
172-
<executeJS function="return {{page.contentJS(index)}}.getBoundingClientRect().height" stepKey="elementContentHeight"/>
173-
<executeJS function="return Math.round(({$elementContentHeight}/{{height}})*100)/100" stepKey="contentHeightRatio"/>
174-
<assertEquals stepKey="assertContentHeightRatio">
175-
<expectedResult type="int">1</expectedResult>
176-
<actualResult type="variable">contentHeightRatio</actualResult>
177-
</assertEquals>
178-
</actionGroup>
179164
</actionGroups>

‎app/code/Magento/PageBuilder/Test/Mftf/Data/CommonContentTypeData.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -113,12 +113,4 @@
113113
<data key="name">Box Shadow</data>
114114
<data key="value">rgb(153, 153, 153) 0px 0px 0px 1px</data>
115115
</entity>
116-
<!-- Message -->
117-
<entity name="PageBuilderMessageProperty_WordBreak" type="pagebuilder_message_property">
118-
<data key="name">Message Text</data>
119-
<data key="section">contents</data>
120-
<data key="role">textarea</data>
121-
<data key="fieldName">message</data>
122-
<data key="value">Magento1111111 Page11111111111</data>
123-
</entity>
124116
</entities>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -305,25 +305,6 @@
305305
<argument name="pageNamePrefix" value="banner"/>
306306
</actionGroup>
307307
</test>
308-
<test name="BannerCollageLeftContentCanWordWrap" extends="BannerPosterContentCanWordWrap">
309-
<annotations>
310-
<features value="PageBuilder"/>
311-
<stories value="Banner"/>
312-
<title value="Collage Left - Banner content can wrap words to multiple lines"/>
313-
<description value="A user can see banner collage left content word wrap to multiple lines"/>
314-
<severity value="CRITICAL"/>
315-
<useCaseId value="MC-4965"/>
316-
<testCaseId value="MC-5632"/>
317-
<group value="pagebuilder"/>
318-
<group value="pagebuilder-banner"/>
319-
<group value="pagebuilder-bannerCollageLeft"/>
320-
<group value="pagebuilder-wordWrap"/>
321-
</annotations>
322-
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
323-
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
324-
</actionGroup>
325-
<comment userInput="keyForRemoval" stepKey="duplicateColumn"/>
326-
</test>
327308
<test name="BannerCollageLeftButtonNeverShow">
328309
<annotations>
329310
<features value="PageBuilder"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerPosterAppearanceTest.xml

Lines changed: 0 additions & 85 deletions
Original file line numberDiff line numberDiff line change
@@ -455,91 +455,6 @@
455455
<resizeWindow width="767" height="1000" stepKey="resizeWindowToMobile"/>
456456
<seeElement selector="{{BannerOnFrontend.wysiwygLinkUrl('1', ExternalLink.googleUrl)}}" stepKey="waitForBannerStorefrontMobile"/>
457457
</test>
458-
<test name="BannerPosterContentCanWordWrap">
459-
<annotations>
460-
<features value="PageBuilder"/>
461-
<stories value="Banner"/>
462-
<title value="Poster - Banner content can wrap words to multiple lines"/>
463-
<description value="A user can see banner poster content word wrap to multiple lines"/>
464-
<severity value="CRITICAL"/>
465-
<useCaseId value="MC-4965"/>
466-
<testCaseId value="MC-5631"/>
467-
<group value="pagebuilder"/>
468-
<group value="pagebuilder-banner"/>
469-
<group value="pagebuilder-bannerPoster"/>
470-
<group value="pagebuilder-wordWrap"/>
471-
</annotations>
472-
<before>
473-
<resizeWindow width="1280" height="1024" stepKey="resetWindowToDesktopBefore"/>
474-
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
475-
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
476-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
477-
</before>
478-
<after>
479-
<resizeWindow width="1280" height="1024" stepKey="resizeWindowToDesktopAfter"/>
480-
<actionGroup ref="logout" stepKey="logout"/>
481-
</after>
482-
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
483-
<argument name="contentType" value="PageBuilderBannerContentType"/>
484-
</actionGroup>
485-
<!-- Add Column to Stage -->
486-
<comment userInput="Add Column to Stage" stepKey="addColumnToStage"/>
487-
<actionGroup ref="dragContentTypeToStage" stepKey="dragColumnIntoStage">
488-
<argument name="contentType" value="PageBuilderColumnContentType"/>
489-
</actionGroup>
490-
<!-- Duplicate Column to create small width -->
491-
<comment userInput="Duplicate Column to create small width" stepKey="commentDuplicateColumnToCreateSmallWidth"/>
492-
<actionGroup ref="duplicateContentType" stepKey="duplicateColumn">
493-
<argument name="contentType" value="PageBuilderColumnContentType"/>
494-
<argument name="targetIndex" value="1"/>
495-
<argument name="contentTypeXCoordinate" value="10"/>
496-
<argument name="contentTypeYCoordinate" value="0"/>
497-
</actionGroup>
498-
<!-- Add content type to Column -->
499-
<comment userInput="Add content type to Column" stepKey="addContentTypeToColumn"/>
500-
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandGroupElements">
501-
<argument name="group" value="PageBuilderBannerContentType"/>
502-
</actionGroup>
503-
<actionGroup ref="dragContentTypeToContainer" stepKey="dragIntoStage">
504-
<argument name="contentType" value="PageBuilderBannerContentType"/>
505-
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
506-
</actionGroup>
507-
<actionGroup ref="inlineEditWYSIWYGFromStage" stepKey="inlineEdit">
508-
<argument name="contentType" value="PageBuilderBannerContentType"/>
509-
<argument name="content" value="{{PageBuilderMessageProperty_WordBreak.value}}"/>
510-
</actionGroup>
511-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
512-
<argument name="contentType" value="PageBuilderBannerContentType"/>
513-
</actionGroup>
514-
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
515-
<argument name="property" value="PageBuilderAppearance_Poster"/>
516-
</actionGroup>
517-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
518-
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
519-
<!-- Validate Height Before Save -->
520-
<comment userInput="Validate Height Before Save" stepKey="commentValidateBeforeSave"/>
521-
<actionGroup ref="validateContentWordHeight" stepKey="validateContentWordHeightStage">
522-
<argument name="page" value="BannerOnBackend"/>
523-
<argument name="height" value="110"/>
524-
</actionGroup>
525-
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
526-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
527-
<!-- Validate Height After Save -->
528-
<comment userInput="Validate Height After Save" stepKey="commentValidateAfterSave"/>
529-
<actionGroup ref="validateContentWordHeight" stepKey="validateContentWordHeightAfterSave">
530-
<argument name="page" value="BannerOnBackend"/>
531-
<argument name="height" value="110"/>
532-
</actionGroup>
533-
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
534-
<argument name="contentType" value="PageBuilderBannerContentType"/>
535-
</actionGroup>
536-
<!-- Validate Height Storefront -->
537-
<comment userInput="Validate Height Storefront" stepKey="commentValidateStorefront"/>
538-
<actionGroup ref="validateContentWordHeight" stepKey="validateContentWordHeightStorefront">
539-
<argument name="page" value="BannerOnFrontend"/>
540-
<argument name="height" value="50"/>
541-
</actionGroup>
542-
</test>
543458
<test name="BannerPosterButtonNeverShow">
544459
<annotations>
545460
<features value="PageBuilder"/>

0 commit comments

Comments
 (0)