Skip to content

Commit 152fdda

Browse files
committed
MAGETWO-92021: Improving dev experience for Products content type
- Made changes from CR
1 parent 0c63be3 commit 152fdda

File tree

5 files changed

+15
-10
lines changed

5 files changed

+15
-10
lines changed

app/code/Magento/PageBuilder/Block/Adminhtml/Form/Element/ProductConditions.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,11 @@ private function getConfig(): array
7272
];
7373
}
7474

75+
/**
76+
* Creates a JSON string containing the configuration for the needed JS components in the mage-init format
77+
*
78+
* @return string
79+
*/
7580
public function getConfigJson(): string
7681
{
7782
return $this->serializer->serialize([

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/products/mass-converter/widget-directive.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/mass-converter/widget-directive.js renamed to app/code/Magento/PageBuilder/view/adminhtml/web/js/mass-converter/widget-directive-abstract.js

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/products/mass-converter/widget-directive.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* See COPYING.txt for license details.
44
*/
55

6-
import BaseWidgetDirective from "../../../mass-converter/widget-directive";
6+
import BaseWidgetDirective from "../../../mass-converter/widget-directive-abstract";
77

88
export default class WidgetDirective extends BaseWidgetDirective {
99
/**

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/mass-converter/widget-directive.ts renamed to app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/mass-converter/widget-directive-abstract.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import _ from "underscore";
77
import ConverterInterface from "./converter-interface";
88

9-
export default class WidgetDirective implements ConverterInterface {
9+
export default class WidgetDirectiveAbstract implements ConverterInterface {
1010
/**
1111
* Convert value to internal format
1212
*

0 commit comments

Comments
 (0)