MC-5423: Scheduled Update slide out issues

- Resolve PR comments
- Resolve TS linting issues

Author: davemacaulay

app/code/Magento/PageBuilder/view/adminhtml/web/js/page-builder.js

@@ -129,8 +129,8 @@ function onSortStart(preview: Preview, event: Event, ui: JQueryUI.SortableUIPara
                 "option", "connectWith",
                 getAllowedContainersClasses(
                     contentTypeInstance.config.name,
-                    preview.parent.stageId
-                )
+                    preview.parent.stageId,
+                ),
             );
             $(this).sortable("refresh");
         }

app/code/Magento/PageBuilder/view/adminhtml/web/js/panel.js

@@ -3,11 +3,11 @@
  * See COPYING.txt for license details.
  */
 
-import _ from "underscore";
 import $ from "jquery";
 import ko from "knockout";
 import events from "Magento_PageBuilder/js/events";
 import utils from "mageUtils";
+import _ from "underscore";
 import Config from "./config";
 import PageBuilderInterface from "./page-builder.d";
 import Panel from "./panel";
@@ -52,7 +52,7 @@ export default class PageBuilder implements PageBuilderInterface {
      * @param {StageToggleFullScreenParamsInterface} args
      */
     public toggleFullScreen(args: StageToggleFullScreenParamsInterface): void {
-        if (typeof args.animate !== "undefined" && args.animate === false) {
+        if (args.animate === false) {
             this.isFullScreen(!this.isFullScreen());
             return;
         }
@@ -72,11 +72,11 @@ export default class PageBuilder implements PageBuilderInterface {
                 parseInt($(window).scrollTop().toString(), 10);
             const yPosition = stageWrapper.offset().left;
             this.previousWrapperStyles = {
-                'position': 'fixed',
-                'top': `${xPosition}px`,
-                'left': `${yPosition}px`,
-                'zIndex': '800',
-                'width': stageWrapper.outerWidth().toString() + 'px'
+                position: "fixed",
+                top: `${xPosition}px`,
+                left: `${yPosition}px`,
+                zIndex: "800",
+                width: stageWrapper.outerWidth().toString() + "px",
             };
             this.wrapperStyles(this.previousWrapperStyles);
             this.isFullScreen(true);
@@ -86,7 +86,7 @@ export default class PageBuilder implements PageBuilderInterface {
                 this.wrapperStyles(Object.keys(this.previousWrapperStyles)
                     .reduce((object: object, styleName: string) => {
                         return Object.assign(object, {[styleName]: ""});
-                    }, {})
+                    }, {}),
                 );
             });
         } else {
@@ -101,7 +101,7 @@ export default class PageBuilder implements PageBuilderInterface {
                 this.wrapperStyles(Object.keys(this.previousWrapperStyles)
                     .reduce((object: object, styleName: string) => {
                         return Object.assign(object, {[styleName]: ""});
-                    }, {})
+                    }, {}),
                 );
                 this.previousWrapperStyles = {};
                 this.previousPanelHeight = null;

app/code/Magento/PageBuilder/view/adminhtml/web/js/utils/position-sticky.js

@@ -177,7 +177,7 @@ export default class Panel implements PanelInterface {
      */
     public getDraggableOptions(element: HTMLElement): JQueryUI.DraggableOptions {
         // If we're within a modal make the containment be the current modal
-        let containment: string | JQuery = "document";
+        let containment: JQuery;
         if ($(element).parents(".modal-inner-wrap").length > 0) {
             containment = $(element).parents(".modal-inner-wrap");
         }
@@ -187,7 +187,7 @@ export default class Panel implements PanelInterface {
             appendTo: "body",
             cursor: "-webkit-grabbing",
             connectToSortable: ".content-type-drop",
-            containment,
+            containment: containment || "document",
             scroll: true,
             helper() {
                 return $(this).clone().css({
@@ -251,11 +251,11 @@ export default class Panel implements PanelInterface {
                             return new GroupContentType(
                                 identifier,
                                 contentType,
-                                this.parent.stage.id
+                                this.parent.stage.id,
                             );
                         },
                     ),
-                    this.parent.stage.id
+                    this.parent.stage.id,
                 ));
             });
 

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/drag-drop/sortable.ts

@@ -13,14 +13,16 @@ export function supportsPositionSticky() {
         return false;
     }
 
-    const testNode = document.createElement('div');
+    const testNode = document.createElement("div");
 
-    return ['', '-webkit-', '-moz-', '-ms-'].some(prefix => {
+    return ["", "-webkit-", "-moz-", "-ms-"].some((prefix) => {
         try {
-            testNode.style.position = prefix + 'sticky';
+            testNode.style.position = prefix + "sticky";
+        }
+        catch (e) {
+            // Fail silently
         }
-        catch(e) {}
 
-        return testNode.style.position != '';
-    })
-}
+        return testNode.style.position !== "";
+    });
+}