Skip to content

Commit 1330c31

Browse files
bluemwhitewbluemwhitew
committed
#425: Infinite Loop Disabled on Slider Does Not Work Correctly
- Creating `validateSliderAttributesActionGroup` Action Group - Updating Existing Tests
1 parent fe84d3f commit 1330c31

File tree

3 files changed

+49
-10
lines changed

3 files changed

+49
-10
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeSliderActionGroup/ValidateSliderAttributesActionGroup.xml

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
9+
<actionGroup name="validateSliderAttributesActionGroup">
10+
<annotations>
11+
<description>Validates a slider instance based on its HTML attributes.</description>
12+
</annotations>
13+
<arguments>
14+
<argument name="sliderSection" defaultValue="SliderOnStage"/>
15+
<argument name="sliderIndex" defaultValue="1" type="string"/>
16+
<argument name="sliderAutoplay" defaultValue="{{PageBuilderSliderAutoPlay_Disabled.value}}" type="string"/>
17+
<argument name="sliderAutoplaySpeed" defaultValue="{{PageBuilderSliderAutoPlaySpeed_Default.value}}" type="string"/>
18+
<argument name="sliderFade" defaultValue="{{PageBuilderSliderFade_Disabled.value}}" type="string"/>
19+
<argument name="sliderInfiniteLoop" defaultValue="{{PageBuilderSliderInfiniteLoop_Disabled.value}}" type="string"/>
20+
<argument name="sliderShowArrows" defaultValue="{{PageBuilderSliderShowArrows_Disabled.value}}" type="string"/>
21+
<argument name="sliderShowDots" defaultValue="{{PageBuilderSliderShowDots_Enabled.value}}" type="string"/>
22+
</arguments>
23+
<waitForElementVisible selector="{{sliderSection.autoPlay(sliderIndex, sliderAutoplay)}}" stepKey="seeAutoplay"/>
24+
<waitForElementVisible selector="{{sliderSection.autoPlaySpeed(sliderIndex, sliderAutoplaySpeed)}}" stepKey="seeAutoplaySpeed"/>
25+
<waitForElementVisible selector="{{sliderSection.fade(sliderIndex, sliderFade)}}" stepKey="seeFade"/>
26+
<waitForElementVisible selector="{{sliderSection.infiniteLoop(sliderIndex, sliderInfiniteLoop)}}" stepKey="seeInfiniteLoop"/>
27+
<waitForElementVisible selector="{{sliderSection.showArrows(sliderIndex, sliderShowArrows)}}" stepKey="seeShowArrows"/>
28+
<waitForElementVisible selector="{{sliderSection.showDots(sliderIndex, sliderShowDots)}}" stepKey="seeShowDots"/>
29+
</actionGroup>
30+
</actionGroups>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSliderCommonTests/SliderValidateInfiniteLoopDisabled.xml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,15 @@
2222
<argument name="property" value="PageBuilderSliderInfiniteLoop_Disabled"/>
2323
</actionGroup>
2424
<!-- Validate Stage: Slider Settings -->
25-
<waitForElementVisible selector="{{SliderOnStage.infiniteLoop('1', PageBuilderSliderInfiniteLoop_Disabled.value)}}" stepKey="seeInfiniteLoopStage"/>
25+
<actionGroup ref="validateSliderAttributesActionGroup" stepKey="seeSliderStage">
26+
<argument name="sliderFade" value="{{PageBuilderSliderFade_Enabled.value}}"/>
27+
<argument name="sliderShowArrows" value="{{PageBuilderSliderShowArrows_Enabled.value}}"/>
28+
</actionGroup>
2629
<!-- Validate Storefront: Slider Settings -->
27-
<waitForElementVisible selector="{{SliderOnFrontend.infiniteLoop('1', PageBuilderSliderInfiniteLoop_Disabled.value)}}" stepKey="seeInfiniteLoopStorefront"/>
30+
<actionGroup ref="validateSliderAttributesActionGroup" stepKey="seeSliderStorefront">
31+
<argument name="sliderFade" value="{{PageBuilderSliderFade_Enabled.value}}"/>
32+
<argument name="sliderShowArrows" value="{{PageBuilderSliderShowArrows_Enabled.value}}"/>
33+
</actionGroup>
2834
<!-- Validate Storefront: Slide 1 -->
2935
<waitForElementVisible selector="{{SliderOnFrontend.previousSlideArrowDisabled('1')}}" stepKey="seePreviousSlideArrow"/>
3036
<!-- Validate Storefront: Slide 2 -->

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSliderCommonTests/SliderValidateInfiniteLoopEnabled.xml

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,11 @@
7979
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
8080
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
8181
<!-- Validate Stage: Slider Settings -->
82-
<waitForElementVisible selector="{{SliderOnStage.autoPlay('1', PageBuilderSliderAutoPlay_Disabled.value)}}" stepKey="seeAutoPlayStage"/>
83-
<waitForElementVisible selector="{{SliderOnStage.infiniteLoop('1', PageBuilderSliderInfiniteLoop_Enabled.value)}}" stepKey="seeInfiniteLoopStage"/>
84-
<waitForElementVisible selector="{{SliderOnStage.showArrows('1', PageBuilderSliderShowArrows_Enabled.value)}}" stepKey="seeArrowsStage"/>
85-
<waitForElementVisible selector="{{SliderOnStage.showDots('1', PageBuilderSliderShowDots_Enabled.value)}}" stepKey="seeDotsStage"/>
82+
<actionGroup ref="validateSliderAttributesActionGroup" stepKey="seeSliderStage">
83+
<argument name="sliderFade" value="{{PageBuilderSliderFade_Enabled.value}}"/>
84+
<argument name="sliderInfiniteLoop" value="{{PageBuilderSliderInfiniteLoop_Enabled.value}}"/>
85+
<argument name="sliderShowArrows" value="{{PageBuilderSliderShowArrows_Enabled.value}}"/>
86+
</actionGroup>
8687
<!-- Validate Stage: Slide 1 -->
8788
<actionGroup ref="switchSlide" stepKey="clickSlide1Stage">
8889
<argument name="slideIndex" value="1"/>
@@ -97,10 +98,12 @@
9798
<argument name="page" value="$$createCMSPage.identifier$$"/>
9899
</actionGroup>
99100
<!-- Validate Storefront: Slider Settings -->
100-
<waitForElementVisible selector="{{SliderOnFrontend.autoPlay('1', PageBuilderSliderAutoPlay_Disabled.value)}}" stepKey="seeAutoPlayStorefront"/>
101-
<waitForElementVisible selector="{{SliderOnFrontend.infiniteLoop('1', PageBuilderSliderInfiniteLoop_Enabled.value)}}" stepKey="seeInfiniteLoopStorefront"/>
102-
<waitForElementVisible selector="{{SliderOnFrontend.showArrows('1', PageBuilderSliderShowArrows_Enabled.value)}}" stepKey="seeArrowsStorefront"/>
103-
<waitForElementVisible selector="{{SliderOnFrontend.showDots('1', PageBuilderSliderShowDots_Enabled.value)}}" stepKey="seeDotsStorefront"/>
101+
<actionGroup ref="validateSliderAttributesActionGroup" stepKey="seeSliderStorefront">
102+
<argument name="sliderSection" value="SliderOnFrontend"/>
103+
<argument name="sliderFade" value="{{PageBuilderSliderFade_Enabled.value}}"/>
104+
<argument name="sliderInfiniteLoop" value="{{PageBuilderSliderInfiniteLoop_Enabled.value}}"/>
105+
<argument name="sliderShowArrows" value="{{PageBuilderSliderShowArrows_Enabled.value}}"/>
106+
</actionGroup>
104107
<!-- Validate Storefront: Slide 1 -->
105108
<actionGroup ref="switchSlide" stepKey="clickSlide1Storefront">
106109
<argument name="sliderSection" value="SliderOnFrontend"/>

0 commit comments

Comments
 (0)