Skip to content

Commit 0e37cf7

Browse files
committed
Merge from 559_no-predefined-gutters--block
2 parents c3db771 + c5eb3cc commit 0e37cf7

File tree

2 files changed

+20
-8
lines changed

2 files changed

+20
-8
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockTest/BlockValidateAdvancedConfigurationDefaultValuesTest.xml

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,13 @@
55
* See COPYING.txt for license details.
66
*/
77
-->
8-
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9-
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
8+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
109
<test name="BlockValidateAdvancedConfigurationDefaultValuesTest">
1110
<annotations>
1211
<features value="PageBuilder"/>
1312
<stories value="Block"/>
14-
<title value="Validate Advanced Configuration Default Values"/>
15-
<description value="Validate the default values for every attribute in the Advanced Configuration form and on Stage for Block."/>
13+
<title value="Validate Advanced Configuration Default Values for Block"/>
14+
<description value="Validates the default values for every attribute in the Advanced form and on Stage for Block."/>
1615
<severity value="BLOCKER"/>
1716
<useCaseId value="MAGETWO-83415"/>
1817
<testCaseId value="MC-2820"/>
@@ -67,10 +66,12 @@
6766
<actualResult type="variable">getCssClasses</actualResult>
6867
</assertEmpty>
6968
<actionGroup ref="seeInMarginFieldsSlideOutPanel" stepKey="validateMargins">
70-
<argument name="property" value="PageBuilderMarginsPropertyDefault"/>
69+
<!-- @todo: Update `PageBuilderMarginsPropertyDefault` with (Default) Empty Values -->
70+
<argument name="property" value="PageBuilderMarginsProperty_Empty"/>
7171
</actionGroup>
7272
<actionGroup ref="seeInPaddingFieldsSlideOutPanel" stepKey="validatePadding">
73-
<argument name="property" value="PageBuilderPaddingPropertyDefault"/>
73+
<!-- @todo: Update `PageBuilderPaddingPropertyDefault` with (Default) Empty Values -->
74+
<argument name="property" value="PageBuilderPaddingProperty_Empty"/>
7475
</actionGroup>
7576
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
7677
<!-- Validate Stage -->
@@ -114,10 +115,12 @@
114115
<actualResult type="variable">getCssClasses2</actualResult>
115116
</assertEmpty>
116117
<actionGroup ref="seeInMarginFieldsSlideOutPanel" stepKey="validateMargins2">
117-
<argument name="property" value="PageBuilderMarginsPropertyDefault"/>
118+
<!-- @todo: Update `PageBuilderMarginsPropertyDefault` with (Default) Empty Values -->
119+
<argument name="property" value="PageBuilderMarginsProperty_Empty"/>
118120
</actionGroup>
119121
<actionGroup ref="seeInPaddingFieldsSlideOutPanel" stepKey="validatePadding2">
120-
<argument name="property" value="PageBuilderPaddingPropertyDefault"/>
122+
<!-- @todo: Update `PageBuilderPaddingPropertyDefault` with (Default) Empty Values -->
123+
<argument name="property" value="PageBuilderPaddingProperty_Empty"/>
121124
</actionGroup>
122125
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
123126
<argument name="contentType" value="PageBuilderBlockContentType"/>

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_block_form.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,15 @@
3131
</settings>
3232
</dataProvider>
3333
</dataSource>
34+
<fieldset name="advanced">
35+
<field name="margins_and_padding">
36+
<argument name="data" xsi:type="array">
37+
<item name="config" xsi:type="array">
38+
<item name="default" xsi:type="null" />
39+
</item>
40+
</argument>
41+
</field>
42+
</fieldset>
3443
<fieldset name="appearance_fieldset" sortOrder="10" component="Magento_PageBuilder/js/form/element/dependent-fieldset">
3544
<settings>
3645
<label translate="true">Appearance</label>

0 commit comments

Comments
 (0)