Skip to content

Commit 0d4d6fb

Browse files
committed
MC-3926: Slide Content Does Not Render After Page Load If Slide Is In Non-Default Tab
Fix admin preview rendering
1 parent cb738d1 commit 0d4d6fb

File tree

5 files changed

+31
-3
lines changed

5 files changed

+31
-3
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slider/preview.js

Lines changed: 7 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/tabs/preview.js

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slider/preview.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,11 @@ export default class Preview extends PreviewCollection {
112112
this.childSubscribe = this.parent.children.subscribe(this.buildSlick);
113113
this.parent.dataStore.subscribe(this.buildSlick);
114114

115+
// Redraw slide after content type gets redrawn
116+
events.on("contentType:redrawAfter", function () {
117+
$(this.element).slick("setPosition");
118+
}.bind(this));
119+
115120
// Set the stage to interacting when a slide is focused
116121
this.focusedSlide.subscribe((value: number) => {
117122
if (value !== null) {
@@ -398,7 +403,7 @@ export default class Preview extends PreviewCollection {
398403
}
399404

400405
/**
401-
* Build the slack config object
406+
* Build the slick config object
402407
*
403408
* @returns {{autoplay: boolean; autoplaySpeed: (any | number);
404409
* fade: boolean; infinite: boolean; arrows: boolean; dots: boolean}}

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/tabs/preview.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,14 @@ export default class Preview extends PreviewCollection {
6060
}
6161
}
6262
},
63+
/**
64+
* Trigger redraw event since new content is being displayed
65+
*/
66+
activate: () => {
67+
events.trigger("contentType:redrawAfter", {
68+
element: this.element
69+
});
70+
},
6371
});
6472
}
6573
}, 10);

app/code/Magento/PageBuilder/view/base/web/js/content-type/slider/appearance/default/widget.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ define([
2929
dots: $element.data('show-dots')
3030
});
3131

32+
// Redraw slide after content type gets redrawn
3233
events.on('contentType:redrawAfter', function () {
3334
$element.slick('setPosition');
3435
});

0 commit comments

Comments
 (0)