Skip to content

Commit 0bd471e

Browse files
author
Hwashiang Yu
committed
MC-4318: Slide Transparent Background Color Renders Incorrectly & Inconsistently On Stage & Storefront
- Renamed entity data for stageValue for empty background color
1 parent df6a505 commit 0bd471e

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/BannerData.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
<data key="name">Background Color</data>
7474
<data key="section">background</data>
7575
<data key="fieldName">background_color</data>
76-
<data key="value">rgb(250, 250, 250)</data>
76+
<data key="stageValue">rgb(250, 250, 250)</data>
7777
</entity>
7878
<!-- Link -->
7979
<entity name="PageBuilderBannerLinkUrlProperty" type="pagebuilder_banner_linkUrl_property">

app/code/Magento/PageBuilder/Test/Mftf/Data/SlideData.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
<data key="name">Background Color</data>
4646
<data key="section">background</data>
4747
<data key="fieldName">background_color</data>
48-
<data key="value">rgb(250, 250, 250)</data>
48+
<data key="stageValue">rgb(250, 250, 250)</data>
4949
</entity>
5050
<!-- Link -->
5151
<entity name="PageBuilderSlideItemLinkURL_Empty" type="pagebuilder_slide_item_link_url_property">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@
596596
</actionGroup>
597597
<executeJS function="return window.getComputedStyle(document.evaluate(&quot;{{BannerOnBackend.noBackgroundColor('1')}}&quot;, document.body).iterateNext()).backgroundColor" stepKey="grabDefaultBackgroundColor"/>
598598
<assertEquals stepKey="assertDefaultBackgroundColor">
599-
<expectedResult type="string">{{PageBuilderBannerBackgroundColor_Empty.value}}</expectedResult>
599+
<expectedResult type="string">{{PageBuilderBannerBackgroundColor_Empty.stageValue}}</expectedResult>
600600
<actualResult type="variable">grabDefaultBackgroundColor</actualResult>
601601
</assertEquals>
602602
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
@@ -608,7 +608,7 @@
608608
</actionGroup>
609609
<executeJS function="return window.getComputedStyle(document.evaluate(&quot;{{BannerOnBackend.noBackgroundColor('1')}}&quot;, document.body).iterateNext()).backgroundColor" stepKey="grabDefaultBackgroundColorAfterSave"/>
610610
<assertEquals stepKey="assertDefaultBackgroundColorAfterSave">
611-
<expectedResult type="string">{{PageBuilderBannerBackgroundColor_Empty.value}}</expectedResult>
611+
<expectedResult type="string">{{PageBuilderBannerBackgroundColor_Empty.stageValue}}</expectedResult>
612612
<actualResult type="variable">grabDefaultBackgroundColorAfterSave</actualResult>
613613
</assertEquals>
614614
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemCommonTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@
198198
<seeElement selector="{{SlideOnBackend.backgroundRepeat('1', PageBuilderBackgroundRepeat_Default.styleValue)}}" stepKey="seeBackgroundRepeatStage"/>
199199
<executeJS function="return window.getComputedStyle(document.evaluate(&quot;{{SlideOnBackend.noBackgroundColor('1')}}&quot;, document.body).iterateNext()).backgroundColor" stepKey="grabDefaultBackgroundColor"/>
200200
<assertEquals stepKey="assertDefaultBackgroundColor">
201-
<expectedResult type="string">{{PageBuilderSlideItemBackgroundColor_Empty.value}}</expectedResult>
201+
<expectedResult type="string">{{PageBuilderSlideItemBackgroundColor_Empty.stageValue}}</expectedResult>
202202
<actualResult type="variable">grabDefaultBackgroundColor</actualResult>
203203
</assertEquals>
204204
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
@@ -212,7 +212,7 @@
212212
<seeElement selector="{{SlideOnBackend.backgroundRepeat('1', PageBuilderBackgroundRepeat_Default.styleValue)}}" stepKey="seeBackgroundRepeatStage2"/>
213213
<executeJS function="return window.getComputedStyle(document.evaluate(&quot;{{SlideOnBackend.noBackgroundColor('1')}}&quot;, document.body).iterateNext()).backgroundColor" stepKey="grabDefaultBackgroundColorAfterSave"/>
214214
<assertEquals stepKey="assertDefaultBackgroundColorAfterSave">
215-
<expectedResult type="string">{{PageBuilderSlideItemBackgroundColor_Empty.value}}</expectedResult>
215+
<expectedResult type="string">{{PageBuilderSlideItemBackgroundColor_Empty.stageValue}}</expectedResult>
216216
<actualResult type="variable">grabDefaultBackgroundColorAfterSave</actualResult>
217217
</assertEquals>
218218
<!-- Validate Edit Panel After Save -->

0 commit comments

Comments
 (0)