Skip to content

Commit 0a76423

Browse files
committed
MC-5054: User Can Bypass File Type Validation In PageBuilder's File Upload Spots
Add BackgroundImageInvalidMimeType MFTF test
1 parent 9c6c2b3 commit 0a76423

File tree

3 files changed

+31
-0
lines changed

3 files changed

+31
-0
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/BackgroundFormData.xml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,16 @@
218218
<data key="extension">sql</data>
219219
<data key="errorMessage">We don't recognize or support this file extension type.</data>
220220
</entity>
221+
<entity name="PageBuilderBackgroundImage_InvalidMimeType" type="pagebuilder_background_image_property">
222+
<data key="name">Background Image</data>
223+
<data key="section">background</data>
224+
<data key="fieldName">background_image</data>
225+
<data key="value">not-a.png</data>
226+
<data key="fileName">not-a</data>
227+
<data key="extension">png</data>
228+
<data key="path">wysiwyg</data>
229+
<data key="errorMessage">File validation failed.</data>
230+
</entity>
221231
<!-- Background Mobile Image -->
222232
<entity name="PageBuilderBackgroundMobileImage_Default" type="pagebuilder_background_mobile_image_property">
223233
<data key="name">Background Image</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBackgroundFormAttributeTests.xml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1148,6 +1148,26 @@
11481148
<argument name="backgroundImage" value="PageBuilderBackgroundImage_JPG"/>
11491149
</actionGroup>
11501150
</test>
1151+
<test name="BackgroundImageInvalidMimeType" extends="BackgroundImageInvalidFileSize">
1152+
<annotations>
1153+
<features value="PageBuilder"/>
1154+
<stories value="Background Form"/>
1155+
<title value="Background Image - Invalid Mime Type"/>
1156+
<description value="Tests that the Background Image attribute functions as expected for files with correct extension but invalid mime type"/>
1157+
<severity value="CRITICAL"/>
1158+
<useCaseId value="MC-5054"/>
1159+
<testCaseId value="MC-5071"/>
1160+
<group value="pagebuilder"/>
1161+
<group value="pagebuilder-banner"/>
1162+
<group value="pagebuilder-backgroundForm"/>
1163+
</annotations>
1164+
<actionGroup ref="attachInvalidFileOnSlideOut" stepKey="attachInvalidFileOnSlideOut">
1165+
<argument name="property" value="PageBuilderBackgroundImage_InvalidMimeType"/>
1166+
</actionGroup>
1167+
<actionGroup ref="attachInvalidFileOnSlideOut" stepKey="attachInvalidFileOnSlideOut2">
1168+
<argument name="property" value="PageBuilderBackgroundImage_InvalidMimeType"/>
1169+
</actionGroup>
1170+
</test>
11511171
<test name="BackgroundMobileImageJPG">
11521172
<annotations>
11531173
<features value="PageBuilder"/>
Lines changed: 1 addition & 0 deletions
Loading

0 commit comments

Comments
 (0)