Skip to content

Commit 0a2e0ad

Browse files
dhaeckerdhaecker
committed
PB-266: Video background for Slide
- Fixing MFTF broken tests
1 parent 6409969 commit 0a2e0ad

6 files changed

+10
-22
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/WYSIWYGActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@
253253
<annotations>
254254
<description>Edits content in the inline wysiwyg editor on the stage in a content type. Used when a single click does not initialize the editor.</description>
255255
</annotations>
256-
<doubleClick selector="{{PageBuilderStage.inlineWYSIWYGEditor(contentType.role, index)}}" stepKey="focusOnEditorArea"/>
256+
<doubleClick selector="{{PageBuilderStage.inlineWYSIWYGEditor(contentType.role, index)}}" stepKey="focusOnEditorArea0" before="focusOnEditorArea"/>
257257
</actionGroup>
258258
<actionGroup name="inlineEditTextAreaFromStage">
259259
<arguments>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageCenterAppearanceTest.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1402,7 +1402,6 @@
14021402
<group value="pagebuilder-backgroundForm"/>
14031403
<group value="pagebuilder-video-background"/>
14041404
</annotations>
1405-
<!-- Fill Out Banner Edit Panel -->
14061405
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
14071406
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
14081407
</actionGroup>
@@ -1422,7 +1421,6 @@
14221421
<group value="pagebuilder-backgroundForm"/>
14231422
<group value="pagebuilder-video-background"/>
14241423
</annotations>
1425-
<!-- Fill Out Banner Edit Panel -->
14261424
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
14271425
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
14281426
</actionGroup>
@@ -1442,7 +1440,6 @@
14421440
<group value="pagebuilder-backgroundForm"/>
14431441
<group value="pagebuilder-video-background"/>
14441442
</annotations>
1445-
<!-- Fill Out Banner Edit Panel -->
14461443
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
14471444
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
14481445
</actionGroup>
@@ -1462,7 +1459,6 @@
14621459
<group value="pagebuilder-backgroundForm"/>
14631460
<group value="pagebuilder-video-background"/>
14641461
</annotations>
1465-
<!-- Fill Out Banner Edit Panel -->
14661462
<actionGroup ref="chooseVisualSelectOption" stepKey="setAppearance">
14671463
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
14681464
</actionGroup>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1405,7 +1405,6 @@
14051405
<group value="pagebuilder-backgroundForm"/>
14061406
<group value="pagebuilder-video-background"/>
14071407
</annotations>
1408-
<!-- Fill Out Banner Edit Panel -->
14091408
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
14101409
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
14111410
</actionGroup>
@@ -1425,7 +1424,6 @@
14251424
<group value="pagebuilder-backgroundForm"/>
14261425
<group value="pagebuilder-video-background"/>
14271426
</annotations>
1428-
<!-- Fill Out Banner Edit Panel -->
14291427
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
14301428
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
14311429
</actionGroup>
@@ -1445,7 +1443,6 @@
14451443
<group value="pagebuilder-backgroundForm"/>
14461444
<group value="pagebuilder-video-background"/>
14471445
</annotations>
1448-
<!-- Fill Out Banner Edit Panel -->
14491446
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
14501447
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
14511448
</actionGroup>
@@ -1465,7 +1462,6 @@
14651462
<group value="pagebuilder-backgroundForm"/>
14661463
<group value="pagebuilder-video-background"/>
14671464
</annotations>
1468-
<!-- Fill Out Banner Edit Panel -->
14691465
<actionGroup ref="chooseVisualSelectOption" stepKey="setAppearance">
14701466
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
14711467
</actionGroup>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageRightAppearanceTest.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1306,7 +1306,6 @@
13061306
<group value="pagebuilder-backgroundForm"/>
13071307
<group value="pagebuilder-video-background"/>
13081308
</annotations>
1309-
<!-- Fill Out Banner Edit Panel -->
13101309
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
13111310
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
13121311
</actionGroup>
@@ -1326,7 +1325,6 @@
13261325
<group value="pagebuilder-backgroundForm"/>
13271326
<group value="pagebuilder-video-background"/>
13281327
</annotations>
1329-
<!-- Fill Out Banner Edit Panel -->
13301328
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
13311329
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
13321330
</actionGroup>
@@ -1346,7 +1344,6 @@
13461344
<group value="pagebuilder-backgroundForm"/>
13471345
<group value="pagebuilder-video-background"/>
13481346
</annotations>
1349-
<!-- Fill Out Banner Edit Panel -->
13501347
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
13511348
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
13521349
</actionGroup>
@@ -1366,7 +1363,6 @@
13661363
<group value="pagebuilder-backgroundForm"/>
13671364
<group value="pagebuilder-video-background"/>
13681365
</annotations>
1369-
<!-- Fill Out Banner Edit Panel -->
13701366
<actionGroup ref="chooseVisualSelectOption" stepKey="setAppearance">
13711367
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
13721368
</actionGroup>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerPosterAppearanceTest.xml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2213,7 +2213,7 @@
22132213
<argument name="playOnlyVisible" value="PageBuilderVideoBackgroundPlayOnlyWhenVisible_Enabled"/>
22142214
<argument name="fallbackImage" value="PageBuilderVideoBackgroundFallbackImage_JPG"/>
22152215
</actionGroup>
2216-
<actionGroup ref="doubleClickToInlineEditWYSIWYGFromStage" stepKey="inlineEdit">
2216+
<actionGroup ref="inlineEditWYSIWYGFromStage" stepKey="inlineEdit">
22172217
<argument name="contentType" value="PageBuilderBannerContentType"/>
22182218
<argument name="content" value="{{PageBuilderBannerMessageProperty.value}}"/>
22192219
</actionGroup>
@@ -2226,7 +2226,7 @@
22262226
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
22272227
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
22282228
<!-- Validate Stage After Save -->
2229-
<scrollTo selector="{{BannerOnBackend.base('1')}}" stepKey="scrollBanner1Stage"/>
2229+
<scrollTo selector="{{CmsNewPagePageContentSection.header}}" stepKey="scrollBanner1Stage"/>
22302230
<actionGroup ref="validateVideoBackgroundWithAllAttributes" stepKey="validateStage2">
22312231
<argument name="section" value="BannerOnBackend"/>
22322232
<argument name="backgroundColor" value="{{PageBuilderBackgroundColor_Pink.rgb}}"/>
@@ -2350,7 +2350,7 @@
23502350
<argument name="section" value="BannerOnBackend"/>
23512351
<argument name="fallbackImage" value="PageBuilderVideoBackgroundFallbackImage_JPG"/>
23522352
</actionGroup>
2353-
<actionGroup ref="doubleClickToInlineEditWYSIWYGFromStage" stepKey="inlineEdit">
2353+
<actionGroup ref="inlineEditWYSIWYGFromStage" stepKey="inlineEdit">
23542354
<argument name="contentType" value="PageBuilderBannerContentType"/>
23552355
<argument name="content" value="{{PageBuilderBannerMessageProperty.value}}"/>
23562356
</actionGroup>
@@ -2363,7 +2363,7 @@
23632363
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
23642364
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
23652365
<!-- Validate Stage After Save -->
2366-
<scrollTo selector="{{BannerOnBackend.base('1')}}" stepKey="scrollBanner1Stage"/>
2366+
<scrollTo selector="{{CmsNewPagePageContentSection.header}}" stepKey="scrollBanner1Stage"/>
23672367
<actionGroup ref="validateFallbackImageInVideoBackgroundWithInvalidVideo" stepKey="validateStage2">
23682368
<argument name="section" value="BannerOnBackend"/>
23692369
<argument name="fallbackImage" value="PageBuilderVideoBackgroundFallbackImage_JPG"/>
@@ -2439,7 +2439,7 @@
24392439
<actionGroup ref="validateInvalidVideoBackgroundAndNoFallbackImage" stepKey="validateStage1">
24402440
<argument name="section" value="BannerOnBackend"/>
24412441
</actionGroup>
2442-
<actionGroup ref="doubleClickToInlineEditWYSIWYGFromStage" stepKey="inlineEdit">
2442+
<actionGroup ref="inlineEditWYSIWYGFromStage" stepKey="inlineEdit">
24432443
<argument name="contentType" value="PageBuilderBannerContentType"/>
24442444
<argument name="content" value="{{PageBuilderBannerMessageProperty.value}}"/>
24452445
</actionGroup>
@@ -2452,7 +2452,7 @@
24522452
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
24532453
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
24542454
<!-- Validate Stage After Save -->
2455-
<scrollTo selector="{{BannerOnBackend.base('1')}}" stepKey="scrollBanner1Stage"/>
2455+
<scrollTo selector="{{CmsNewPagePageContentSection.header}}" stepKey="scrollBanner1Stage"/>
24562456
<actionGroup ref="validateInvalidVideoBackgroundAndNoFallbackImage" stepKey="validateStage2">
24572457
<argument name="section" value="BannerOnBackend"/>
24582458
</actionGroup>
@@ -2538,7 +2538,7 @@
25382538
<argument name="lazyLoad" value="PageBuilderVideoBackgroundLazyLoad_Disabled"/>
25392539
<argument name="playOnlyWhenVisible" value="PageBuilderVideoBackgroundPlayOnlyWhenVisible_Disabled"/>
25402540
</actionGroup>
2541-
<actionGroup ref="doubleClickToInlineEditWYSIWYGFromStage" stepKey="inlineEdit">
2541+
<actionGroup ref="inlineEditWYSIWYGFromStage" stepKey="inlineEdit">
25422542
<argument name="contentType" value="PageBuilderBannerContentType"/>
25432543
<argument name="content" value="{{PageBuilderBannerMessageProperty.value}}"/>
25442544
</actionGroup>
@@ -2551,7 +2551,7 @@
25512551
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
25522552
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
25532553
<!-- Validate Stage After Save -->
2554-
<scrollTo selector="{{BannerOnBackend.base('1')}}" stepKey="scrollBanner1Stage"/>
2554+
<scrollTo selector="{{CmsNewPagePageContentSection.header}}" stepKey="scrollBanner1Stage"/>
25552555
<actionGroup ref="validateVideoBackgroundWithOnlyVideoUrl" stepKey="validateStage2">
25562556
<argument name="section" value="BannerOnBackend"/>
25572557
<argument name="videoUrl" value="PageBuilderVideoBackgroundUrl_YouTube_Embedded"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderMediaContentTypesTests.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2955,7 +2955,7 @@
29552955
<argument name="playOnlyWhenVisible" value="PageBuilderVideoBackgroundPlayOnlyWhenVisible_Enabled"/>
29562956
<argument name="fallbackImage" value="PageBuilderVideoBackgroundFallbackImage_JPG"/>
29572957
</actionGroup>
2958-
<actionGroup ref="doubleClickToInlineEditWYSIWYGFromStage" stepKey="inlineEdit">
2958+
<actionGroup ref="inlineEditWYSIWYGFromStage" stepKey="inlineEdit">
29592959
<argument name="contentType" value="PageBuilderBannerContentType"/>
29602960
<argument name="content" value="{{PageBuilderBannerMessageProperty.value}}"/>
29612961
</actionGroup>

0 commit comments

Comments
 (0)