MC-3095: Display TypeScript errors within local build process

- Update data argument to be of type DataObject in implemented coverters

Author: davemacaulay

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/attribute/link-href.ts

@@ -3,6 +3,7 @@
  * See COPYING.txt for license details.
  */
 import _ from "underscore";
+import {DataObject} from "../../data-store";
 import ConverterInterface from "../converter-interface";
 
 /**
@@ -12,7 +13,15 @@ export default class CreateValueForHref implements ConverterInterface {
     /**
      * @type object
      */
-    private widgetParamsByLinkType: object = {
+    private widgetParamsByLinkType: {
+        [key: string]: {
+            type: string;
+            page_id?: string;
+            id_path?: string;
+            template: string;
+            type_name: string;
+        };
+    } = {
         category: {
             type: "Magento\\Catalog\\Block\\Category\\Widget\\Link",
             id_path: `category/:href`,
@@ -50,7 +59,7 @@ export default class CreateValueForHref implements ConverterInterface {
      * @param data Object
      * @returns {string}
      */
-    public toDom(name: string, data: object): string {
+    public toDom(name: string, data: DataObject): string {
 
         const link = data[name];
         let href = "";

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/attribute/link-target.ts

@@ -3,6 +3,7 @@
  * See COPYING.txt for license details.
  */
 
+import {DataObject} from "../../data-store";
 import ConverterInterface from "../converter-interface";
 
 /**
@@ -26,7 +27,7 @@ export default class CreateValueForTarget implements ConverterInterface {
      * @param data Object
      * @returns {string}
      */
-    public toDom(name: string, data: object): string {
+    public toDom(name: string, data: DataObject): string {
         if (!data[name]) {
             return "";
         }

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/attribute/link-type.ts

@@ -3,6 +3,7 @@
  * See COPYING.txt for license details.
  */
 
+import {DataObject} from "../../data-store";
 import ConverterInterface from "../converter-interface";
 
 /**
@@ -27,7 +28,7 @@ export default class CreateValueForLinkType implements ConverterInterface {
      * @param data Object
      * @returns {string}
      */
-    public toDom(name: string, data: object): string {
+    public toDom(name: string, data: DataObject): string {
 
         return data[name] ? data[name].type : "";
     }

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/attribute/preview/src.ts

@@ -3,6 +3,7 @@
  * See COPYING.txt for license details.
  */
 
+import {DataObject} from "../../../data-store";
 import ConverterInterface from "../../converter-interface";
 
 /**
@@ -26,7 +27,7 @@ export default class Src implements ConverterInterface {
      * @param data Object
      * @returns {string}
      */
-    public toDom(name: string, data: object): string {
+    public toDom(name: string, data: DataObject): string {
         const value = data[name];
         if (value && typeof value[0] === "object") {
             return value[0].url;

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/attribute/src.ts

@@ -4,6 +4,7 @@
  */
 
 import Config from "../../config";
+import {DataObject} from "../../data-store";
 import {decodeUrl} from "../../utils/image";
 import {convertUrlToPathIfOtherUrlIsOnlyAPath} from "../../utils/url";
 import ConverterInterface from "../converter-interface";
@@ -32,7 +33,7 @@ export default class Src implements ConverterInterface {
      * @param data Object
      * @returns {string}
      */
-    public toDom(name: string, data: object): string {
+    public toDom(name: string, data: DataObject): string {
         const value = data[name];
         if (value[0] === undefined || value[0].url === undefined) {
             return "";

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/converter-interface.ts

@@ -8,7 +8,7 @@ import {DataObject} from "../data-store";
 /**
  * @api
  */
-export interface ConverterInterface {
+export default interface ConverterInterface {
     /**
      * Convert value to internal format
      *

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/converter-pool.ts

@@ -3,7 +3,7 @@
  * See COPYING.txt for license details.
  */
 
-import {ConverterInterface} from "./converter-interface";
+import ConverterInterface from "./converter-interface";
 
 /**
  * @api

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/html/directive.ts

@@ -3,6 +3,7 @@
  * See COPYING.txt for license details.
  */
 
+import {DataObject} from "../../data-store";
 import {convertMediaDirectivesToUrls, removeQuotesInMediaDirectives} from "../../utils/directives";
 import ConverterInterface from "../converter-interface";
 
@@ -27,7 +28,7 @@ export default class Directives implements ConverterInterface {
      * @param {Object} data
      * @returns {string}
      */
-    public toDom(name: string, data: object): string {
+    public toDom(name: string, data: DataObject): string {
         return convertMediaDirectivesToUrls(removeQuotesInMediaDirectives(data[name]));
     }
 }

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/style/background-image.ts

@@ -4,6 +4,7 @@
  */
 
 import Config from "../../config";
+import {DataObject} from "../../data-store";
 import {toDataUrl} from "../../utils/directives";
 import {decodeUrl} from "../../utils/image";
 import {convertUrlToPathIfOtherUrlIsOnlyAPath} from "../../utils/url";
@@ -33,7 +34,7 @@ export default class BackgroundImage implements ConverterInterface {
      * @param data Object
      * @returns {string}
      */
-    public toDom(name: string, data: object): string {
+    public toDom(name: string, data: DataObject): string {
         const value = data[name];
         if (value[0] === undefined || value[0].url === undefined) {
             return "";

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/style/border-width.ts

@@ -3,6 +3,7 @@
  * See COPYING.txt for license details.
  */
 
+import {DataObject} from "../../data-store";
 import ConverterInterface from "../converter-interface";
 
 /**
@@ -22,11 +23,11 @@ export default class BorderWidth implements ConverterInterface {
     /**
      * Convert value to knockout format
      *
-     * @param name string
-     * @param data Object
+     * @param {string} name
+     * @param {DataObject} data
      * @returns {string | object}
      */
-    public toDom(name: string, data: object): string | object {
+    public toDom(name: string, data: DataObject): string | object {
         if (data[name]) {
             return data[name] + "px";
         }