Skip to content

Commit 07cbb87

Browse files
committed
MC-5255: Flaky MFTF Map Tests
- Adding waits to error overlay action groups to prevent flakiness - Adding proper teardown to suite
1 parent eb60117 commit 07cbb87

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeMapActionGroup.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,7 @@
222222
</arguments>
223223
<comment userInput="validateMapSettings" stepKey="comment"/>
224224
<waitForElement selector="{{page.base(index)}}" stepKey="waitForMap"/>
225+
<waitForElementVisible selector="{{page.warningMessageLink(index)}}" stepKey="waitForErrorOverlay"/>
225226
<waitForElement selector="{{page.height(index, height.value)}}" stepKey="waitForHeight"/>
226227
<dontSeeElement selector="{{page.height(index, height.value)}}" stepKey="dontSeeHeight"/>
227228
<seeElementInDOM selector="{{page.height(index, height.value)}}" stepKey="seeInDOMHeight"/>
@@ -409,9 +410,9 @@
409410
<seeElement selector="{{ContentManagementSection.GoogleMapsAPIKeyInputField}}" stepKey="seeGoogleMapsAPIKeyInputField"/>
410411
</actionGroup>
411412
<actionGroup name="validateAdvancedStyleWithAllUpdatedMapWithErrorOverlay" extends="validateAdvancedStyleWithAllUpdatedNotVisible">
412-
<comment userInput="removing w/ merge" stepKey="dontSeeElement"/>
413+
<waitForElementVisible selector="{{page.warningMessageLink(index)}}" stepKey="dontSeeElement"/>
413414
</actionGroup>
414415
<actionGroup name="validateAdvancedStyleWithNoAlignmentMapWithErrorOverlay" extends="validateAdvancedStyleWithNoAlignmentNotVisible">
415-
<comment userInput="removing w/ merge" stepKey="dontSeeElement"/>
416+
<waitForElementVisible selector="{{page.warningMessageLink(index)}}" stepKey="dontSeeElement"/>
416417
</actionGroup>
417418
</actionGroups>

app/code/Magento/PageBuilder/Test/Mftf/Suite/suite.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@
1414
<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key ''" stepKey="setEmptyGoogleMapsAPIKey"/>
1515
</before>
1616
<after>
17+
<magentoCLI command="config:set cms/pagebuilder/enabled 1" stepKey="enablePageBuilder"/>
18+
<magentoCLI command="config:set cms/wysiwyg/editor mage/adminhtml/wysiwyg/tiny_mce/tinymce4Adapter" stepKey="enableTinyMCE4"/>
1719
<magentoCLI command="config:set cms/wysiwyg/enabled disabled" stepKey="disableWYSIWYG"/>
20+
<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key ''" stepKey="setEmptyGoogleMapsAPIKey"/>
1821
</after>
1922
<include>
2023
<group name="pagebuilder"/>

0 commit comments

Comments
 (0)