MC-5723: Flaky MFTF Map Tests - Google Maps Rate Limit Reached

- MFTF map changes to greatly reduce number of API calls per build

Author: dhaecker

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeMapActionGroup.xml

@@ -372,11 +372,12 @@
     </actionGroup>
     <actionGroup name="validateMapErrorMessageStage">
         <arguments>
+            <argument name="page" defaultValue="MapOnStage"/>
             <argument name="index" defaultValue="1" type="string"/>
         </arguments>
-        <waitForElement selector="{{MapOnStage.base(index)}}" stepKey="seeMap"/>
-        <waitForElementVisible selector="{{MapOnStage.errorContainer(index)}}" stepKey="seeMapErrorContainer"/>
-        <see userInput="{{PageBuilderMapCommonData.mapErrorMessageStage}}" selector="{{MapOnStage.errorContainer(index)}}" stepKey="seeMapErrorMessage"/>
+        <waitForElement selector="{{page.base(index)}}" stepKey="seeMap"/>
+        <waitForElementVisible selector="{{page.errorContainer(index)}}" stepKey="seeMapErrorContainer"/>
+        <see userInput="{{PageBuilderMapCommonData.mapErrorMessageAdmin}}" selector="{{page.errorContainer(index)}}" stepKey="seeMapErrorMessage"/>
     </actionGroup>
     <actionGroup name="validateMapErrorMessageStorefront">
         <arguments>

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/StoreConfigurationActionGroup.xml

@@ -91,12 +91,14 @@
     <actionGroup name="clickAndValidateGoogleMapsAPIKeyTestKeyButton">
         <arguments>
             <argument name="expectedResult" defaultValue="success" type="string"/>
+            <argument name="buttonText" type="string"/>
         </arguments>
         <comment userInput="clickAndValidateGoogleMapsAPIKeyTestKeyButton" stepKey="comment"/>
         <waitForElementVisible selector="{{ContentManagementSection.GoogleMapsAPIKeyTestKeyButton}}" stepKey="waitForTestKeyButtonEnabled"/>
         <click selector="{{ContentManagementSection.GoogleMapsAPIKeyTestKeyButton}}" stepKey="clickTestKeyButton"/>
         <waitForPageLoad stepKey="waitForPageLoad"/>
-        <waitForElementVisible selector="{{ContentManagementSection.GoogleMapsAPIKeyTestKeyResult(expectedResult)}}" stepKey="waitForTestKeyButtonResult"/>
+        <waitForElementVisible selector="{{ContentManagementSection.GoogleMapsAPIKeyTestKeyResult}} .icon-admin-pagebuilder-{{expectedResult}}" stepKey="waitForTestKeyButtonResult"/>
+        <see userInput="{{buttonText}}" selector="{{ContentManagementSection.GoogleMapsAPIKeyTestKeyResult}}" stepKey="seeTestKeyButtonText"/>
     </actionGroup>
     <actionGroup name="inputGoogleMapsStyle">
         <arguments>

app/code/Magento/PageBuilder/Test/Mftf/Data/CmsConfigData.xml

@@ -13,11 +13,14 @@
         <data key="row">row_cms_pagebuilder_google_maps_api_key</data>
         <data key="label">Google Maps API Key</data>
         <data key="default"/>
-        <data key="valid">AIzaSyCw10cOO31cpxb2bcwnHPHKtxov8oUbxJw</data>
+        <data key="valid">AIzaSyA7TbgpW4U9yKFNzJmHPwLUh_bWt9nXBl4</data>
         <data key="invalidOneCharacter">a</data>
-        <data key="invalidOneCharacterOffOfValid">aIzaSyCw10cOO31cpxb2bcwnHPHKtxov8oUbxJw</data>
+        <data key="invalidOneCharacterOffOfValid">aIzaSyA7TbgpW4U9yKFNzJmHPwLUh_bWt9nXBl4</data>
         <data key="empty"/>
         <data key="warningMessage">You must provide the Google Maps API key in order to use the map</data>
+        <data key="keyButtonText">Test Key</data>
+        <data key="invalidKeyButtonText">Key is invalid. Try a different key.</data>
+        <data key="validKeyButtonText">Key is valid</data>
     </entity>
     <entity name="googleMapsStyle" type="config">
         <data key="section">cms_pagebuilder</data>

app/code/Magento/PageBuilder/Test/Mftf/Data/MapData.xml

@@ -24,7 +24,7 @@
     <entity name="PageBuilderMapCommonData" type="pagebuilder__map_common_data">
         <data key="mapErrorTitleStorefront">Oops! Something went wrong.</data>
         <data key="mapErrorMessageStorefront">This page didn't load Google Maps correctly. See the JavaScript console for technical details.</data>
-        <data key="mapErrorMessageStage">Enter valid API Key to use Google Maps</data>
+        <data key="mapErrorMessageAdmin">Enter valid API Key to use Google Maps</data>
     </entity>
     <!-- Map Position -->
     <entity name="PageBuilderMapPositionDefaultProperty" type="pagebuilder_map_position_property">

app/code/Magento/PageBuilder/Test/Mftf/Section/ContentManagementSection.xml

@@ -20,7 +20,7 @@
         <element name="ConfigurationFieldLabel" type="button" selector="//div[contains(@class,'form-inline')]//fieldset[@id='{{arg1}}']//tr[@id='{{arg2}}']//span[.='{{arg3}}']" parameterized="true"/>
         <element name="GoogleMapsAPIKeyInputField" type="input" selector="#cms_pagebuilder_google_maps_api_key"/>
         <element name="GoogleMapsAPIKeyTestKeyButton" type="button" selector="#cms_pagebuilder_google_maps_api_key_validator"/>
-        <element name="GoogleMapsAPIKeyTestKeyResult" type="button" selector="#cms_pagebuilder_google_maps_api_key_validator .result .icon-admin-pagebuilder-{{arg1}}" parameterized="true"/>
+        <element name="GoogleMapsAPIKeyTestKeyResult" type="button" selector="#cms_pagebuilder_google_maps_api_key_validator .result"/>
         <element name="GoogleMapsAPIKeyHelperText" type="text" selector="#row_cms_pagebuilder_google_maps_api_key .value .note span"/>
         <element name="GoogleMapsGetAPIKeyLink" type="button" selector="#row_cms_pagebuilder_google_maps_api_key a[href]"/>
         <element name="GoogleMapsStyleInputField" type="input" selector="#cms_pagebuilder_google_maps_style"/>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderMapSection.xml

@@ -117,5 +117,7 @@
         <element name="fullScreen" type="button" selector="(//div[@data-index='position']//div[@class='map-field']//button[@title='Toggle fullscreen view'])[{{arg1}}]" parameterized="true"/>
         <element name="zoomIn" type="button" selector="(//div[@data-index='position']//div[@class='map-field']//button[@title='Zoom in'])[{{arg1}}]" parameterized="true"/>
         <element name="zoomOut" type="button" selector="(//div[@data-index='position']//div[@class='map-field']//button[@title='Zoom out'])[{{arg1}}]" parameterized="true"/>
+        <!-- Map Error Message -->
+        <element name="errorContainer" type="text" selector="(//div[@data-index='position']//div[@class='map-field']//div[@class='google-map-auth-failure-placeholder'])[{{arg1}}]" parameterized="true"/>
     </section>
 </sections>

app/code/Magento/PageBuilder/Test/Mftf/Suite/suite.xml

@@ -11,7 +11,7 @@
             <magentoCLI command="config:set cms/pagebuilder/enabled 1" stepKey="enablePageBuilder"/>
             <magentoCLI command="config:set cms/wysiwyg/enabled enabled" stepKey="enableWYSIWYG"/>
             <magentoCLI command="config:set cms/wysiwyg/editor mage/adminhtml/wysiwyg/tiny_mce/tinymce4Adapter" stepKey="enableTinyMCE4"/>
-            <magentoCLI command="config:set cms/pagebuilder/google_maps_api_key {{googleMapsAPIKey.valid}}" stepKey="setValidGoogleMapsAPIKey"/>
+            <magentoCLI command="config:set cms/pagebuilder/google_maps_api_key {{googleMapsAPIKey.invalidOneCharacter}}" stepKey="setInvalidGoogleMapsAPIKey"/>
         </before>
         <after>
             <magentoCLI command="config:set cms/wysiwyg/enabled disabled" stepKey="disableWYSIWYG"/>