Skip to content

Commit 05335ee

Browse files
author
Hwashiang Yu
committed
MC-5810: Improve naming of the critical variables/parameters in the code and configuration
- Reverted MC-10833 test failure changes
1 parent 5dcecdd commit 05335ee

File tree

4 files changed

+4
-9
lines changed

4 files changed

+4
-9
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeMapActionGroup.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -409,11 +409,6 @@
409409
<seeInCurrentUrl url="{{AdminContentManagementPage.url}}#cms_pagebuilder" stepKey="validateURL"/>
410410
<seeElement selector="{{ContentManagementSection.GoogleMapsAPIKeyInputField}}" stepKey="seeGoogleMapsAPIKeyInputField"/>
411411
</actionGroup>
412-
<actionGroup name="validateWarningMessageLinkNewTabTarget" extends="validateWarningMessageLink">
413-
<switchToNextTab stepKey="switchToNewConfigurationTab" after="clickLink"/>
414-
<closeTab stepKey="closeTab" after="seeGoogleMapsAPIKeyInputField"/>
415-
<switchToPreviousTab stepKey="switchToPreviousTab" after="closeTab"/>
416-
</actionGroup>
417412
<actionGroup name="validateAdvancedStyleWithAllUpdatedMapWithErrorOverlay" extends="validateAdvancedStyleWithAllUpdatedNotVisible">
418413
<waitForElementVisible selector="{{page.warningMessageLink(index)}}" stepKey="dontSeeElement"/>
419414
</actionGroup>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCatalogProductPageBuilder.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
<actionGroup ref="dragContentTypeToDropZone" stepKey="dragRowToStage">
9898
<argument name="contentType" value="PageBuilderRowContentType"/>
9999
<argument name="contentTypeIndex" value="2"/>
100-
<argument name="containerTargetType" value="PageBuilderRootContainerContentType"/>
100+
<argument name="containerTargetType" value="PageBuilderStage"/>
101101
<argument name="dropZoneIndex" value="2"/>
102102
</actionGroup>
103103
<!-- Edit 2nd Row -->

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderMapGoogleMapsSettingsTests.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@
129129
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage1"/>
130130
<!-- Stage: Validate Warning Message Link -->
131131
<comment userInput="Stage: Validate Warning Message Link" stepKey="commentValidateWarningMessageLinkStage"/>
132-
<actionGroup ref="validateWarningMessageLinkNewTabTarget" stepKey="validateWarningMessageLink1">
132+
<actionGroup ref="validateWarningMessageLink" stepKey="validateWarningMessageLink1">
133133
<argument name="section" value="MapOnStage"/>
134134
</actionGroup>
135135
<!-- Edit Form: Validate Warning Message Link -->
@@ -149,7 +149,7 @@
149149
<argument name="contentType" value="PageBuilderMapContentType"/>
150150
</actionGroup>
151151
<actionGroup ref="clickAddLocationButton" stepKey="clickAddLocationButton"/>
152-
<actionGroup ref="validateWarningMessageLinkNewTabTarget" stepKey="validateWarningMessageLink3">
152+
<actionGroup ref="validateWarningMessageLink" stepKey="validateWarningMessageLink3">
153153
<argument name="section" value="AddLocationForm"/>
154154
</actionGroup>
155155
</test>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
6363
<actionGroup ref="dragContentTypeToDropZone" stepKey="dragRowIntoStage">
6464
<argument name="contentType" value="PageBuilderRowContentType"/>
65-
<argument name="containerTargetType" value="PageBuilderRootContainerContentType"/>
65+
<argument name="containerTargetType" value="PageBuilderStage"/>
6666
<argument name="containerTargetIndex" value="1"/>
6767
<argument name="contentTypeIndex" value="2"/>
6868
<argument name="dropZoneIndex" value="2"/>

0 commit comments

Comments
 (0)