Skip to content

Commit 04df2a0

Browse files
author
Michael Yu
committed
MC-407: Empty banner displays on store front as big empty area
- Updated tests to remove tabbing functions and unique title and descriptions
1 parent 8fa3acd commit 04df2a0

4 files changed

+8
-16
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageCenterAppearanceTest.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1139,8 +1139,8 @@
11391139
<features value="Pagebuilder"/>
11401140
<stories value="Banner"/>
11411141
<useCaseId value="MC-407"/>
1142-
<title value=" Validate empty banner does not take up space on store front"/>
1143-
<description value="Validate empty banner does not take up space on store fronts"/>
1142+
<title value=" Validate empty banner collage center does not take up space on store front"/>
1143+
<description value="Validate empty banner collage center does not take up space on store fronts"/>
11441144
<severity value="CRITICAL"/>
11451145
<group value="pagebuilder"/>
11461146
<group value="pagebuilder-banner"/>
@@ -1152,7 +1152,6 @@
11521152
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
11531153
</before>
11541154
<after>
1155-
<closeTab stepKey="closeTab"/>
11561155
<actionGroup ref="logout" stepKey="logout"/>
11571156
</after>
11581157
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
@@ -1177,7 +1176,6 @@
11771176
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
11781177
<waitForElementVisible time="2" selector="{{BannerOnBackend.emptyCollageCentered}}" stepKey="waitForCollageCentered" />
11791178
<seeElement selector="{{BannerOnBackend.emptyBanner(PageBuilderBannerMessageDefaultProperty.placeholder)}}" stepKey="seeEmptyBannerContent"/>
1180-
<openNewTab stepKey="openNewTab"/>
11811179
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
11821180
<argument name="contentType" value="PageBuilderBannerContentType"/>
11831181
</actionGroup>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1133,8 +1133,8 @@
11331133
<features value="Pagebuilder"/>
11341134
<stories value="Banner"/>
11351135
<useCaseId value="MC-407"/>
1136-
<title value=" Validate empty banner does not take up space on store front"/>
1137-
<description value="Validate empty banner does not take up space on store fronts"/>
1136+
<title value=" Validate empty banner collage left does not take up space on store front"/>
1137+
<description value="Validate empty banner collage left does not take up space on store fronts"/>
11381138
<severity value="CRITICAL"/>
11391139
<group value="pagebuilder"/>
11401140
<group value="pagebuilder-banner"/>
@@ -1146,7 +1146,6 @@
11461146
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
11471147
</before>
11481148
<after>
1149-
<closeTab stepKey="closeTab"/>
11501149
<actionGroup ref="logout" stepKey="logout"/>
11511150
</after>
11521151
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
@@ -1171,7 +1170,6 @@
11711170
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
11721171
<waitForElementVisible time="2" selector="{{BannerOnBackend.emptyCollageLeft}}" stepKey="waitForCollageLeft" />
11731172
<seeElement selector="{{BannerOnBackend.emptyBanner(PageBuilderBannerMessageDefaultProperty.placeholder)}}" stepKey="seeEmptyBannerContent"/>
1174-
<openNewTab stepKey="openNewTab"/>
11751173
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
11761174
<argument name="contentType" value="PageBuilderBannerContentType"/>
11771175
</actionGroup>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageRightAppearanceTest.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1127,8 +1127,8 @@
11271127
<features value="Pagebuilder"/>
11281128
<stories value="Banner"/>
11291129
<useCaseId value="MC-407"/>
1130-
<title value=" Validate empty banner does not take up space on store front"/>
1131-
<description value="Validate empty banner does not take up space on store fronts"/>
1130+
<title value=" Validate empty banner collage right does not take up space on store front"/>
1131+
<description value="Validate empty banner collage right does not take up space on store fronts"/>
11321132
<severity value="CRITICAL"/>
11331133
<group value="pagebuilder"/>
11341134
<group value="pagebuilder-banner"/>
@@ -1140,7 +1140,6 @@
11401140
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
11411141
</before>
11421142
<after>
1143-
<closeTab stepKey="closeTab"/>
11441143
<actionGroup ref="logout" stepKey="logout"/>
11451144
</after>
11461145
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
@@ -1165,7 +1164,6 @@
11651164
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
11661165
<waitForElementVisible time="2" selector="{{BannerOnBackend.emptyCollageRight}}" stepKey="waitForCollageRight" />
11671166
<seeElement selector="{{BannerOnBackend.emptyBanner(PageBuilderBannerMessageDefaultProperty.placeholder)}}" stepKey="seeEmptyBannerContent"/>
1168-
<openNewTab stepKey="openNewTab"/>
11691167
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
11701168
<argument name="contentType" value="PageBuilderBannerContentType"/>
11711169
</actionGroup>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerPosterAppearanceTest.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -614,8 +614,8 @@
614614
<features value="Pagebuilder"/>
615615
<stories value="Banner"/>
616616
<useCaseId value="MC-407"/>
617-
<title value=" Validate empty banner does not take up space on store front"/>
618-
<description value="Validate empty banner does not take up space on store fronts"/>
617+
<title value=" Validate empty banner poster does not take up space on store front"/>
618+
<description value="Validate empty banner poster does not take up space on store fronts"/>
619619
<severity value="CRITICAL"/>
620620
<group value="pagebuilder"/>
621621
<group value="pagebuilder-banner"/>
@@ -627,7 +627,6 @@
627627
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
628628
</before>
629629
<after>
630-
<closeTab stepKey="closeTab"/>
631630
<actionGroup ref="logout" stepKey="logout"/>
632631
</after>
633632
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
@@ -645,7 +644,6 @@
645644
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
646645
<waitForElementVisible time="2" selector="{{BannerOnBackend.emptyPoster}}" stepKey="waitForPoster" />
647646
<seeElement selector="{{BannerOnBackend.emptyBanner(PageBuilderBannerMessageDefaultProperty.placeholder)}}" stepKey="seeEmptyBannerContent"/>
648-
<openNewTab stepKey="openNewTab"/>
649647
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
650648
<argument name="contentType" value="PageBuilderBannerContentType"/>
651649
</actionGroup>

0 commit comments

Comments
 (0)