Skip to content

Commit 0157d1a

Browse files
committed
MC-5405: Column Minimum Height Issues
- update existing tests to exclude padding from expected column height
1 parent d0193fd commit 0157d1a

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnContentTest.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,10 @@
8787
</actionGroup>
8888
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
8989
<comment userInput="Validate Column Height On Stage With Custom Min Height Matches Expected" stepKey="commentValidateColumnHeight"/>
90-
<actionGroup ref="validateContentTypeHeightOnStage" stepKey="assertInitialColumnHeightMatchesExpected">
90+
<actionGroup ref="validateContentTypeHeightOnStageWithoutPadding" stepKey="assertInitialColumnHeightMatchesExpected">
9191
<argument name="contentType" value="PageBuilderColumnContentType"/>
9292
<argument name="index" value="1"/>
9393
<argument name="containerDefaultHeight" value="PageBuilderMinHeightProperty_500"/>
94-
<argument name="expectedPaddingTop" value="PageBuilderPaddingProperty10"/>
95-
<argument name="expectedPaddingBottom" value="PageBuilderPaddingProperty10"/>
9694
</actionGroup>
9795
<executeJS function="{{PageBuilderStage.computedHeightOnStage(PageBuilderColumnContentType.role,'1')}}" stepKey="actualStageInitialColumnHeight"/>
9896
<comment userInput="Validate Row Height adjusts to Column Height" stepKey="commentValidateRowHeightAdjustToColumn"/>
@@ -156,7 +154,7 @@
156154
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
157155
<comment userInput="Validate Column Height On Stage With Custom Min Height Matches Expected" stepKey="commentValidateColumnHeight"/>
158156
<executeJS function="{{PageBuilderStage.computedHeightOnStage(PageBuilderColumnContentType.role,'1')}}" stepKey="actualStageContentTypeHeight"/>
159-
<executeJS function="return Math.round({{PageBuilderMinHeightProperty_200.value}} + {{PageBuilderPaddingProperty10.paddingTop}} + {{PageBuilderPaddingProperty10.paddingBottom}})" stepKey="expectedColumnHeight"/>
157+
<executeJS function="return Math.round({{PageBuilderMinHeightProperty_200.value}})" stepKey="expectedColumnHeight"/>
160158
<assertEquals stepKey="assertHeightOnStageMatchesExpected">
161159
<expectedResult type="variable">actualStageContentTypeHeight</expectedResult>
162160
<actualResult type="variable">expectedColumnHeight</actualResult>

0 commit comments

Comments
 (0)