Skip to content

Commit 011c085

Browse files
author
Hwashiang Yu
committed
Merge remote-tracking branch 'origin/MC-3713-paddding-is-not-respected-on-text' into cms-team-1-delivery
2 parents 9fb17d5 + d14f45a commit 011c085

File tree

2 files changed

+43
-1
lines changed

2 files changed

+43
-1
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2567,4 +2567,46 @@
25672567
<!-- Validate Image Editor On Storefront -->
25682568
<seeElement selector="{{TextOnStorefront.messageContentTextAreaImage('1', PageBuilderBackgroundImage_JPG.value)}}" stepKey="validateImageFrontEnd"/>
25692569
</test>
2570+
<test name="TextDisabledWYSIWYGUpdateAdvancedConfigurationValues" extends="TextUpdateAdvancedConfigurationValues">
2571+
<annotations>
2572+
<features value="PageBuilder"/>
2573+
<stories value="Text"/>
2574+
<title value="Update Advanced Configuration Values With Disabled WYSIWYG"/>
2575+
<description value="Validate that updating every attribute in the Advanced Configuration form for Text will update the Stage and Storefront correctly with disabled wysiwyg."/>
2576+
<severity value="CRITICAL"/>
2577+
<useCaseId value="MC-3713"/>
2578+
<testCaseId value="MC-5731"/>
2579+
<group value="pagebuilder"/>
2580+
<group value="pagebuilder-text"/>
2581+
</annotations>
2582+
<before>
2583+
<magentoCLI command="config:set cms/wysiwyg/enabled disabled" stepKey="disableWYSIWYG" before="loginAsAdmin"/>
2584+
</before>
2585+
<after>
2586+
<magentoCLI command="config:set cms/wysiwyg/enabled enabled" stepKey="enableWYSIWYG" before="logout"/>
2587+
</after>
2588+
<waitForElementVisible selector="{{TextOnConfiguration.textArea}}" stepKey="waitForTextOnEditPanel" before="enterText"/>
2589+
<fillField selector="{{TextOnConfiguration.textArea}}" userInput="{{PageBuilderTextProperty.value}}" stepKey="enterText"/>
2590+
</test>
2591+
<test name="TextDisabledByDefaultWYSIWYGUpdateAdvancedConfigurationValues" extends="TextUpdateAdvancedConfigurationValues">
2592+
<annotations>
2593+
<features value="PageBuilder"/>
2594+
<stories value="Text"/>
2595+
<title value="Update Advanced Configuration Values With Disabled By Default WYSIWYG"/>
2596+
<description value="Validate that updating every attribute in the Advanced Configuration form for Text will update the Stage and Storefront correctly with disabled wysiwyg by default."/>
2597+
<severity value="CRITICAL"/>
2598+
<useCaseId value="MC-3713"/>
2599+
<testCaseId value="MC-5732"/>
2600+
<group value="pagebuilder"/>
2601+
<group value="pagebuilder-text"/>
2602+
</annotations>
2603+
<before>
2604+
<magentoCLI command="config:set cms/wysiwyg/enabled hidden" stepKey="disableByDefaultWYSIWYG" before="loginAsAdmin"/>
2605+
</before>
2606+
<after>
2607+
<magentoCLI command="config:set cms/wysiwyg/enabled enabled" stepKey="enableWYSIWYG" before="logout"/>
2608+
</after>
2609+
<waitForElementVisible selector="{{TextOnConfiguration.textArea}}" stepKey="waitForTextOnEditPanel" before="enterText"/>
2610+
<fillField selector="{{TextOnConfiguration.textArea}}" userInput="{{PageBuilderTextProperty.value}}" stepKey="enterText"/>
2611+
</test>
25702612
</tests>

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/text/default/preview.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<div if="isWysiwygSupported()" class="inline-wysiwyg" ko-style="data.main.style" css="data.main.css" attr="data.main.attributes" afterRender="initWysiwyg" />
1010
<div if="isWysiwygSupported()" class="placeholder-text" ifnot="data.main.html" ko-style="getPlaceholderStyle()" translate="'Edit Text'"></div>
1111

12-
<div ifnot="isWysiwygSupported()">
12+
<div ifnot="isWysiwygSupported()" ko-style="data.main.style" css="data.main.css" attr="data.main.attributes" >
1313
<textarea
1414
class="inline-wysiwyg-textarea"
1515
afterRender="initTextarea"

0 commit comments

Comments
 (0)