MC-5810: Improve naming of the critical variables/parameters in the code and configuration

- Resolved product attribute failure
- Reverted non content type data-roles

Author: Hwashiang Yu

app/code/Magento/PageBuilder/Block/Adminhtml/Form/Element/ProductConditions.php

@@ -85,7 +85,7 @@ private function getConfig(): array
     public function getConfigJson(): string
     {
         return $this->serializer->serialize([
-            '[data-content-type=pagebuilder-conditions-form-placeholder-' . $this->getData('attribute') . ']' => [
+            '[data-role=pagebuilder-conditions-form-placeholder-' . $this->getData('attribute') . ']' => [
                 'Magento_PageBuilder/js/form/element/conditions-loader' => $this->getConfig(),
             ]
         ]);

app/code/Magento/PageBuilder/Test/Mftf/Data/ProductAttributeData.xml

@@ -16,18 +16,18 @@
         <data key="is_required">false</data>
         <data key="is_unique">false</data>
         <data key="is_searchable">false</data>
-        <data key="is_system">true</data>
+        <data key="is_visible">true</data>
         <data key="backend_type">text</data>
         <data key="is_wysiwyg_enabled">false</data>
-        <data key="is_system_in_advanced_search">false</data>
-        <data key="is_system_on_front">true</data>
+        <data key="is_visible_in_advanced_search">false</data>
+        <data key="is_visible_on_front">true</data>
         <data key="is_filterable">false</data>
         <data key="is_filterable_in_search">false</data>
         <data key="used_in_product_listing">false</data>
         <data key="is_used_for_promo_rules">false</data>
         <data key="is_comparable">true</data>
         <data key="is_used_in_grid">false</data>
-        <data key="is_system_in_grid">false</data>
+        <data key="is_visible_in_grid">false</data>
         <data key="is_filterable_in_grid">false</data>
         <data key="used_for_sort_by">false</data>
         <requiredEntity type="FrontendLabel">ProductAttributeFrontendLabel</requiredEntity>

app/code/Magento/PageBuilder/view/adminhtml/web/js/panel.js

@@ -5,7 +5,7 @@
  */
 -->
 <div class="pagebuilder-stage"
-     attr="id: id, 'data-content-type': 'pagebuilder-stage'"
+     attr="id: id, 'data-role': 'pagebuilder-stage'"
      css="'pagebuilder-show-borders': showBorders, 'pagebuilder-no-user-select': !userSelect(), 'panel-collapsed': pageBuilder.panel.isCollapsed, 'interacting': interacting, 'focus-child': focusChild">
     <div class="pagebuilder-stage-loading" visible="loading">
         <span class="spinner">

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/preview.html

@@ -21,7 +21,7 @@
             <button
                 type="button"
                 class="action-remove"
-                data-content-type="delete-button"
+                data-role="delete-button"
                 attr="title: $t('Delete image')"
                 disable="$parent.disabled"
                 click="$parent.removeFile.bind($parent, $file)">

app/code/Magento/PageBuilder/view/adminhtml/web/template/form/element/uploader/preview.html

@@ -5,7 +5,7 @@
  */
 -->
 
-<div class="pagebuilder-image-uploader-container" data-content-type="drop-zone" css="_loading: isLoading, 'has-data': hasData()">
+<div class="pagebuilder-image-uploader-container" data-role="drop-zone" css="_loading: isLoading, 'has-data': hasData()">
     <div class="pagebuilder-options" data-bind="visible: hasData() || isShowImageUploadOptions">
         <div class="pagebuilder-options-wrapper">
             <ul class="pagebuilder-options-links">

app/code/Magento/PageBuilder/view/adminhtml/web/template/form/element/uploader/preview/image.html

@@ -237,7 +237,7 @@ export default class Panel {
                     _.map(
                         _.where(contentTypes, {
                             group: id,
-                            is_system: true,
+                            is_visible: true,
                         }), /* Retrieve content types with group id */
                         (contentType: ContentTypeConfigInterface, identifier: string) => {
                             return new GroupContentType(

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/panel.ts

@@ -44,9 +44,9 @@ private function createPageBuilderAttribute($attributeCode)
                 "default_value" => "",
                 "frontend_input" => "textarea",
                 "is_wysiwyg_enabled" => 1,
-                "is_system_on_front" => true,
+                "is_visible_on_front" => true,
                 "is_searchable" => true,
-                "is_system_in_advanced_search" => true,
+                "is_visible_in_advanced_search" => true,
                 "is_filterable" => true,
                 "is_filterable_in_search" => true,
                 \Magento\Framework\Api\ExtensibleDataInterface::EXTENSION_ATTRIBUTES_KEY => [

dev/tests/api-functional/testsuite/Magento/PageBuilder/Api/ProductAttributeRepositoryTest.php

@@ -484,7 +484,7 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
             ['unsigned' => true, 'nullable' => false, 'default' => '0'],
             'Is WYSIWYG Enabled'
         )->addColumn(
-            'is_system',
+            'is_visible',
             \Magento\Framework\DB\Ddl\Table::TYPE_SMALLINT,
             null,
             ['unsigned' => true, 'nullable' => false, 'default' => '1'],