AC-391: Static test to cover "deprecated" jQuery methods

- Fixed transversal issues

Author: Rrego6

Magento2/Tests/Eslint/EventShorthandTest.js

@@ -2,3 +2,4 @@ $(document).ready(function () {
     'use strict';
     $('#result').unload(function () {});
 });
+

eslint/rules/jquery-no-click-event-shorthand.js

@@ -42,8 +42,7 @@ module.exports = {
                     name = node.callee.property.name;
                     context.report({
                         node: node,
-                        message:
-                            'Instead of .' + name + '(fn) use .on("' + name + '", fn). Instead of .' + name +
+                        message: 'Instead of .' + name + '(fn) use .on("' + name + '", fn). Instead of .' + name +
                             '() use .trigger("' + name + '")'
                     });
                 }

eslint/rules/jquery-no-event-shorthand.js

@@ -32,12 +32,14 @@ module.exports = {
                         'unload': 'jQuery.unload() was removed, use .on("unload", fn) instead.',
                         'ready': 'jQuery.ready(handler) is deprecated and should be replaced with jQuery(handler)'
                     },
-                    name;
+                    name,
+                    message;
 
                 if (node.callee.type !== 'MemberExpression') {return;}
 
                 name = node.callee.property.name;
-                if (!(name in namesToMsg)) {return;}
+                if (!namesToMsg.hasOwnProperty(name)) {return;}
+                message = namesToMsg[name];
 
                 if (utils.isjQuery(node)) {
                     context.report({

eslint/rules/jquery-no-misc-deprecated-functions.js

@@ -38,17 +38,19 @@ module.exports = {
                         'parseJSON' : 'jQuery.parseJSON() is deprecated. ' +
                             'To parse JSON strings, use the native JSON.parse method instead'
                     },
-                    name;
+                    name,
+                    message;
 
                 if (node.callee.type !== 'MemberExpression') {return;}
 
                 name = node.callee.property.name;
-                if (!(name in namesToMsg)) {return;}
+                if (!namesToMsg.hasOwnProperty(name)) {return;}
+                message = namesToMsg[name];
 
                 if (utils.isjQuery(node)) {
                     context.report({
                         node: node,
-                        message: namesToMsg[name]
+                        message: message
                     });
                 }
             }

eslint/rules/utils.js

@@ -40,7 +40,7 @@ function isjQuery(node) {
 
     var id = traverse(node);
 
-    return id && id.name.startsWith('$') || id.name.toLowerCase() === 'jquery';
+    return id && (id.name.startsWith('$') || id.name.toLowerCase() === 'jquery');
 }
 
 module.exports = {