MAGECLOUD-2280: Setting cron_run from .magento.env.yaml does not work (#283)

Author: Bohdan Korablov

src/Process/Deploy/InstallUpdate/ConfigUpdate/CronConsumersRunner.php

@@ -103,7 +103,7 @@ public function execute()
         );
 
         $config['cron_consumers_runner'] = [
-            'cron_run' => $runnerConfig->get('cron_run') === 'true',
+            'cron_run' => $runnerConfig->get('cron_run') === true,
             'max_messages' => $runnerConfig->get('max_messages', static::DEFAULT_MAX_MESSAGES),
             'consumers' => $runnerConfig->get('consumers', []),
         ];

src/Test/Integration/AcceptanceTest.php

@@ -60,6 +60,7 @@ public function testDefault(array $environment, array $expectedConsumersRunnerCo
 
     /**
      * @return array
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     public function defaultDataProvider(): array
     {
@@ -86,7 +87,7 @@ public function defaultDataProvider(): array
                     'variables' => [
                         'ADMIN_EMAIL' => 'admin@example.com',
                         'CRON_CONSUMERS_RUNNER' => [
-                            'cron_run' => "true",
+                            'cron_run' => true,
                             'max_messages' => 5000,
                             'consumers' => ['test'],
                         ],
@@ -103,11 +104,33 @@ public function defaultDataProvider(): array
                     ],
                 ],
             ],
+            'test cron_consumers_runner with wrong array' => [
+                'environment' => [
+                    'variables' => [
+                        'ADMIN_EMAIL' => 'admin@example.com',
+                        'CRON_CONSUMERS_RUNNER' => [
+                            'cron_run' => 'true',
+                            'max_messages' => 5000,
+                            'consumers' => ['test'],
+                        ],
+                    ],
+                ],
+                'expectedConsumersRunnerConfig' => [
+                    'cron_consumers_runner' => [
+                        'cron_run' => false,
+                        'max_messages' => 5000,
+                        'consumers' => ['test'],
+                    ],
+                    'directories' => [
+                        'document_root_is_pub' => true,
+                    ],
+                ],
+            ],
             'test cron_consumers_runner with string' => [
                 'environment' => [
                     'variables' => [
                         'ADMIN_EMAIL' => 'admin@example.com',
-                        'CRON_CONSUMERS_RUNNER' => '{"cron_run":"true", "max_messages":100, "consumers":["test2"]}',
+                        'CRON_CONSUMERS_RUNNER' => '{"cron_run":true, "max_messages":100, "consumers":["test2"]}',
                     ],
                 ],
                 'expectedConsumersRunnerConfig' => [
@@ -121,6 +144,24 @@ public function defaultDataProvider(): array
                     ],
                 ],
             ],
+            'test cron_consumers_runner with wrong string' => [
+                'environment' => [
+                    'variables' => [
+                        'ADMIN_EMAIL' => 'admin@example.com',
+                        'CRON_CONSUMERS_RUNNER' => '{"cron_run":"true", "max_messages":100, "consumers":["test2"]}',
+                    ],
+                ],
+                'expectedConsumersRunnerConfig' => [
+                    'cron_consumers_runner' => [
+                        'cron_run' => false,
+                        'max_messages' => 100,
+                        'consumers' => ['test2'],
+                    ],
+                    'directories' => [
+                        'document_root_is_pub' => true,
+                    ],
+                ],
+            ],
             'disabled static content symlinks 3 jobs' => [
                 'environment' => [
                     'variables' => [

src/Test/Unit/Process/Deploy/InstallUpdate/ConfigUpdate/CronConsumersRunnerTest.php

@@ -120,6 +120,7 @@ public function testExecute(array $config, array $configFromVariable, array $exp
 
     /**
      * @return array
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     public function executeDataProvider(): array
     {
@@ -182,7 +183,7 @@ public function executeDataProvider(): array
                         'consumers' => ['test'],
                     ],
                 ],
-                'configFromVariable' => ['cron_run' => 'true'],
+                'configFromVariable' => ['cron_run' => true],
                 'expectedResult' => [
                     'someConfig' => 'someValue',
                     'cron_consumers_runner' => [
@@ -202,7 +203,7 @@ public function executeDataProvider(): array
                     ],
                 ],
                 'configFromVariable' => [
-                    'cron_run' => 'true',
+                    'cron_run' => true,
                     'max_messages' => 200,
                     'consumers' => ['test2', 'test3'],
                 ],
@@ -215,6 +216,29 @@ public function executeDataProvider(): array
                     ],
                 ],
             ],
+            [
+                'config' => [
+                    'someConfig' => 'someValue',
+                    'cron_consumers_runner' => [
+                        'cron_run' => true,
+                        'max_messages' => 6000,
+                        'consumers' => ['test'],
+                    ],
+                ],
+                'configFromVariable' => [
+                    'cron_run' => 'true',
+                    'max_messages' => 200,
+                    'consumers' => ['test2', 'test3'],
+                ],
+                'expectedResult' => [
+                    'someConfig' => 'someValue',
+                    'cron_consumers_runner' => [
+                        'cron_run' => false,
+                        'max_messages' => 200,
+                        'consumers' => ['test2', 'test3'],
+                    ],
+                ],
+            ],
         ];
     }