Skip to content

Commit e368516

Browse files
authored
Merge pull request #184 from magento-commerce/develop
Merge develop into release branch
2 parents c14a911 + 5599f32 commit e368516

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

src/Config/Factory/Cache.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -379,4 +379,13 @@ private function isSynchronizedConfigStructure(): bool
379379
return $redisModel === self::REDIS_BACKEND_REMOTE_SYNCHRONIZED_CACHE ||
380380
$valkeyModel === self::VALKEY_BACKEND_REMOTE_SYNCHRONIZED_CACHE;
381381
}
382+
383+
/**
384+
* @return array
385+
*/
386+
public function isValkeyEnabled()
387+
{
388+
return $this->valkey->getConfiguration();
389+
}
390+
382391
}

src/Service/Validator.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,8 @@ class Validator
102102
'>=2.3.0 <2.3.7-p4 || >=2.4.0 <2.4.3-p3' => '~3.5.0 || ~3.7.0 || ~3.8.0',
103103
'>=2.4.3-p3 <2.4.5-p3 || ~2.3.7-p4' => '~3.5.0 || ~3.7.0 || ~3.8.0 || ~3.9.0',
104104
'>=2.4.5-p3 <2.4.6-p6' => '~3.9.0 || ~3.11.0',
105-
'>=2.4.6-p6 <2.4.9' => '~3.12.0 || ~3.13.0',
105+
'>=2.4.6-p6 <2.4.8' => '~3.12.0 || ~3.13.0',
106+
'>=2.4.8 <2.4.9' => '>=4.0 <4.1',
106107
],
107108
ServiceInterface::NAME_NODE => [
108109
'*' => '^6 || ^8 || ^10 || ^11',

src/Step/Deploy/PreDeploy/ConfigUpdate/Cache.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,10 +181,9 @@ private function checkBackendModel(string $backend): void
181181
CacheFactory::REDIS_BACKEND_REMOTE_SYNCHRONIZED_CACHE
182182
];
183183
$notAllowedValkeyBackend = [
184-
CacheFactory::VALKEY_BACKEND_VALKEY_CACHE,
185-
CacheFactory::VALKEY_BACKEND_REMOTE_SYNCHRONIZED_CACHE
184+
CacheFactory::VALKEY_BACKEND_VALKEY_CACHE
186185
];
187-
186+
// $isValkeyEnabled= $this->cacheConfig->isValkeyEnabled(); // @TODO
188187
try {
189188
if (in_array($backend, $notAllowedValkeyBackend, true)
190189
&& !$this->magentoVersion->isGreaterOrEqual('2.4.8')) {

0 commit comments

Comments
 (0)