MAGECLOUD-3345: Add Node.JS Docker Image (#476)

Author: shiftedreality

src/Command/Docker/Build.php

@@ -39,6 +39,7 @@ class Build extends Command
     const OPTION_REDIS = 'redis';
     const OPTION_ES = 'es';
     const OPTION_RABBIT_MQ = 'rmq';
+    const OPTION_NODE = 'node';
     const OPTION_MODE = 'mode';
 
     /**
@@ -142,6 +143,11 @@ protected function configure()
                 null,
                 InputOption::VALUE_OPTIONAL,
                 'RabbitMQ version'
+            )->addOption(
+                self::OPTION_NODE,
+                null,
+                InputOption::VALUE_REQUIRED,
+                'Node.js version'
             )->addOption(
                 self::OPTION_MODE,
                 'm',
@@ -176,6 +182,7 @@ public function execute(InputInterface $input, OutputInterface $output)
             self::OPTION_NGINX => Config::KEY_NGINX,
             self::OPTION_REDIS => Config::KEY_REDIS,
             self::OPTION_ES => Config::KEY_ELASTICSEARCH,
+            self::OPTION_NODE => Config::KEY_NODE,
             self::OPTION_RABBIT_MQ => Config::KEY_RABBITMQ,
         ];
 

src/Docker/Compose/ProductionCompose.php

@@ -117,6 +117,16 @@ public function build(Repository $config): array
             );
         }
 
+        $nodeVersion = $config->get(Config::KEY_NODE);
+
+        if ($nodeVersion) {
+            $services['node'] = $this->serviceFactory->create(
+                ServiceFactory::SERVICE_NODE,
+                $nodeVersion,
+                ['volumes' => [$this->getMagentoVolumes(false)]]
+            );
+        }
+
         $rabbitMQVersion = $config->get(Config::KEY_RABBITMQ)
             ?: $this->config->getServiceVersion(Config::KEY_RABBITMQ);
 

src/Docker/ComposeManagerInterface.php

@@ -18,6 +18,7 @@ interface ComposeManagerInterface
     const REDIS_VERSION = 'redis.version';
     const ES_VERSION = 'es.version';
     const RABBIT_MQ_VERSION = 'rmq.version';
+    const NODE_VERSION = 'node.version';
 
     /**
      * @param Repository $config

src/Docker/Service/Config.php

@@ -23,7 +23,7 @@ class Config
     const KEY_REDIS = 'redis';
     const KEY_ELASTICSEARCH = 'elasticsearch';
     const KEY_RABBITMQ = 'rabbitmq';
-
+    const KEY_NODE = 'node';
     const KEY_CRON = 'crons';
     const KEY_VARNISH = 'varnish';
 

src/Docker/Service/ServiceFactory.php

@@ -23,6 +23,7 @@ class ServiceFactory
     const SERVICE_ELASTICSEARCH = 'elasticsearch';
     const SERVICE_RABBIT_MQ = 'rabbitmq';
     const SERVICE_TLS = 'tls';
+    const SERVICE_NODE = 'node';
 
     const CONFIG = [
         self::SERVICE_CLI => [
@@ -85,6 +86,10 @@ class ServiceFactory
             'image' => 'rabbitmq:%s',
             'versions' => ['3.5', '3.7']
         ],
+        self::SERVICE_NODE => [
+            'image' => 'node:%s',
+            'versions' => ['6', '8', '10', '11'],
+        ],
     ];
 
     /**

src/Test/Unit/Command/Docker/BuildTest.php

@@ -198,12 +198,13 @@ public function testExecuteWithParams()
                 [Build::OPTION_REDIS, '3.2'],
                 [Build::OPTION_ES, '2.4'],
                 [Build::OPTION_RABBIT_MQ, '3.5'],
-                [Build::OPTION_MODE, ComposeManagerFactory::COMPOSE_PRODUCTION]
+                [Build::OPTION_NODE, '6.0'],
+                [Build::OPTION_MODE, ComposeManagerFactory::COMPOSE_PRODUCTION],
             ]);
         $this->managerMock->expects($this->once())
             ->method('getConfigPath')
             ->willReturn('magento_root/docker-compose.yml');
-        $this->configMock->expects($this->exactly(6))
+        $this->configMock->expects($this->exactly(7))
             ->method('set');
         $this->distGenerator->expects($this->once())
             ->method('generate');