MAGECLOUD-2919: Wrong Log Level for Starting/Finishing Deployment Phases (#382)

Author: billygilbert

src/Command/Build/Generate.php

@@ -71,9 +71,9 @@ protected function configure()
     public function execute(InputInterface $input, OutputInterface $output)
     {
         try {
-            $this->logger->info('Starting generate command. ' . $this->packageManager->getPrettyInfo());
+            $this->logger->notice('Starting generate command. ' . $this->packageManager->getPrettyInfo());
             $this->process->execute();
-            $this->logger->info('Generate command completed.');
+            $this->logger->notice('Generate command completed.');
         } catch (\Throwable $e) {
             $this->logger->critical($e->getMessage());
 

src/Command/Build/Transfer.php

@@ -61,9 +61,9 @@ protected function configure()
     public function execute(InputInterface $input, OutputInterface $output)
     {
         try {
-            $this->logger->info('Starting transfer files.');
+            $this->logger->notice('Starting transfer files.');
             $this->process->execute();
-            $this->logger->info('Transfer completed.');
+            $this->logger->notice('Transfer completed.');
         } catch (\Throwable $e) {
             $this->logger->critical($e->getMessage());
 

src/Process/Build/ApplyPatches.php

@@ -43,12 +43,13 @@ public function __construct(
      */
     public function execute()
     {
-        $this->logger->info('Applying patches.');
+        $this->logger->notice('Applying patches.');
 
         try {
             $this->manager->applyAll();
         } catch (GenericException $exception) {
             throw new ProcessException($exception->getMessage(), $exception->getCode(), $exception);
         }
+        $this->logger->notice('End of applying patches.');
     }
 }

src/Process/Build/BackupData.php

@@ -40,7 +40,8 @@ public function __construct(LoggerInterface $logger, ProcessInterface $processes
      */
     public function execute()
     {
-        $this->logger->info('Copying data to the ./init directory');
+        $this->logger->notice('Copying data to the ./init directory');
         $this->processes->execute();
+        $this->logger->notice('End of copying data to the ./init directory');
     }
 }

src/Process/Build/DeployStaticContent.php

@@ -69,7 +69,9 @@ public function execute()
             return;
         }
 
+        $this->logger->notice('Generating fresh static content');
         $this->process->execute();
         $this->flagManager->set(FlagManager::FLAG_STATIC_CONTENT_DEPLOY_IN_BUILD);
+        $this->logger->notice('End of generating fresh static content');
     }
 }

src/Process/Deploy/DeployStaticContent.php

@@ -97,7 +97,8 @@ public function execute()
             $this->staticContentCleaner->clean();
         }
 
-        $this->logger->info('Generating fresh static content');
+        $this->logger->notice('Generating fresh static content');
         $this->process->execute();
+        $this->logger->notice('End of generating fresh static content');
     }
 }

src/Process/Deploy/InstallUpdate.php

@@ -59,11 +59,13 @@ public function execute()
     {
         try {
             if (!$this->deployConfig->isInstalled()) {
-                $this->logger->info('Starting install.');
+                $this->logger->notice('Starting install.');
                 $this->installProcess->execute();
+                $this->logger->notice('End of install.');
             } else {
-                $this->logger->info('Starting update.');
+                $this->logger->notice('Starting update.');
                 $this->updateProcess->execute();
+                $this->logger->notice('End of update.');
             }
         } catch (GenericException $exception) {
             throw new ProcessException($exception->getMessage(), $exception->getCode(), $exception);

src/Process/Deploy/PreDeploy.php

@@ -57,13 +57,14 @@ public function __construct(
      */
     public function execute()
     {
-        $this->logger->info('Starting pre-deploy.');
+        $this->logger->notice('Starting pre-deploy.');
         $this->process->execute();
 
         try {
             $this->maintenanceModeSwitcher->enable();
         } catch (ShellException $exception) {
             throw new ProcessException($exception->getMessage(), $exception->getCode(), $exception);
         }
+        $this->logger->notice('End of pre-deploy.');
     }
 }

src/Process/Deploy/PreDeploy/RestoreWritableDirectories.php

@@ -78,7 +78,7 @@ public function execute()
         }
 
         // Restore mounted directories.
-        $this->logger->info('Recoverable directories were copied back.');
+        $this->logger->notice('Recoverable directories were copied back.');
         $this->flagManager->delete(FlagManager::FLAG_REGENERATE);
     }
 }

src/Test/Unit/Command/Build/GenerateTest.php

@@ -59,7 +59,7 @@ protected function setUp()
     public function testExecute()
     {
         $this->loggerMock->expects($this->exactly(2))
-            ->method('info')
+            ->method('notice')
             ->withConsecutive(
                 ['Starting generate command. Some info.'],
                 ['Generate command completed.']
@@ -88,7 +88,7 @@ public function testExecuteWithException()
             ->method('getPrettyInfo')
             ->willReturn('Some info.');
         $this->loggerMock->expects($this->once())
-            ->method('info')
+            ->method('notice')
             ->with('Starting generate command. Some info.');
         $this->loggerMock->expects($this->once())
             ->method('critical')