MAGECLOUD-1578: Option skip_csd doesn't work if set using build_options.ini file (#145)

Bohdan Korablov · oshmyheliuk · commit 95af1790a5a6 · 2018-01-18T15:11:30.000+02:00
diff --git a/src/Config/Stage/Build.php b/src/Config/Stage/Build.php
@@ -130,7 +130,7 @@ private function getDeprecatedConfig(): array
         }
 
         if (isset($buildConfig['skip_scd'])) {
-            $result[self::VAR_SKIP_SCD] = $buildConfig['skip_scd'] === 'yes';
+            $result[self::VAR_SKIP_SCD] = $buildConfig['skip_scd'] === '1';
         }
 
         if (isset($buildConfig['VERBOSE_COMMANDS'])) {
diff --git a/src/Test/Unit/Config/Stage/BuildTest.php b/src/Test/Unit/Config/Stage/BuildTest.php
@@ -318,7 +318,7 @@ public function getDataProvider(): array
                     ],
                 ],
                 [
-                    'skip_scd' => 'yes',
+                    'skip_scd' => '1',
                 ],
                 true,
             ],

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ private function getDeprecatedConfig(): array`
`130`	`130`	`}`
`131`	`131`
`132`	`132`	`if (isset($buildConfig['skip_scd'])) {`
`133`		`- $result[self::VAR_SKIP_SCD] = $buildConfig['skip_scd'] === 'yes';`
	`133`	`+ $result[self::VAR_SKIP_SCD] = $buildConfig['skip_scd'] === '1';`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`if (isset($buildConfig['VERBOSE_COMMANDS'])) {`
Original file line number	Diff line number	Diff line change
`@@ -318,7 +318,7 @@ public function getDataProvider(): array`
`318`	`318`	`],`
`319`	`319`	`],`
`320`	`320`	`[`
`321`		`- 'skip_scd' => 'yes',`
	`321`	`+ 'skip_scd' => '1',`
`322`	`322`	`],`
`323`	`323`	`true,`
`324`	`324`	`],`