MAGECLOUD-1495: Add Proper Logging for Variables Overrides

Author: oshmyheliuk

src/Process/Build/DeployStaticContent/Generate.php

@@ -70,7 +70,7 @@ public function execute()
         try {
             $locales = $this->buildOption->getLocales();
             $excludeThemes = $this->buildOption->getExcludedThemes();
-            $threadCount= $this->buildOption->getThreadCount();
+            $threadCount = $this->buildOption->getThreadCount();
 
             $logMessage = 'Generating static content for locales: ' . implode(' ', $locales);
 

src/StaticContent/ThreadCountOptimizer.php

@@ -5,6 +5,8 @@
  */
 namespace Magento\MagentoCloud\StaticContent;
 
+use Psr\Log\LoggerInterface;
+
 class ThreadCountOptimizer
 {
     /**
@@ -19,6 +21,19 @@ class ThreadCountOptimizer
      */
     const THREAD_COUNT_COMPACT_STRATEGY = 1;
 
+    /**
+     * @var LoggerInterface
+     */
+    private $logger;
+
+    /**
+     * @param LoggerInterface $logger
+     */
+    public function __construct(LoggerInterface $logger)
+    {
+        $this->logger = $logger;
+    }
+
     /**
      * Defines best thread count value based on deploy strategy name
      *
@@ -29,6 +44,12 @@ class ThreadCountOptimizer
     public function optimize(int $threads, string $strategy): int
     {
         if ($strategy === self::STRATEGY_COMPACT) {
+            if ($threads !== self::THREAD_COUNT_COMPACT_STRATEGY) {
+                $this->logger->notice(
+                    'Threads count was forced to 1 as compact strategy can\'t be run with more than one job'
+                );
+            }
+
             return self::THREAD_COUNT_COMPACT_STRATEGY;
         }
 

src/Test/Unit/StaticContent/ThreadCountOptimizerTest.php

@@ -7,6 +7,8 @@
 
 use Magento\MagentoCloud\StaticContent\ThreadCountOptimizer;
 use PHPUnit\Framework\TestCase;
+use PHPUnit_Framework_MockObject_MockObject as Mock;
+use Psr\Log\LoggerInterface;
 
 class ThreadCountOptimizerTest extends TestCase
 {
@@ -15,9 +17,16 @@ class ThreadCountOptimizerTest extends TestCase
      */
     private $optimizer;
 
+    /**
+     * @var LoggerInterface|Mock
+     */
+    private $loggerMock;
+
     protected function setUp()
     {
-        $this->optimizer = new ThreadCountOptimizer();
+        $this->loggerMock = $this->getMockForAbstractClass(LoggerInterface::class);
+
+        $this->optimizer = new ThreadCountOptimizer($this->loggerMock);
     }
 
     /**
@@ -57,4 +66,16 @@ public function optimizeDataProvider(): array
             ]
         ];
     }
+
+    public function testOptimizeWithNotice()
+    {
+        $this->loggerMock->expects($this->once())
+            ->method('notice')
+            ->with('Threads count was forced to 1 as compact strategy can\'t be run with more than one job');
+
+        $this->assertEquals(
+            1,
+            $this->optimizer->optimize(3, ThreadCountOptimizer::STRATEGY_COMPACT)
+        );
+    }
 }