MAGECLOUD-3366: [Docker] DB dump can't be saved using db-dump (#446)

Author: shiftedreality

composer.json

@@ -79,6 +79,10 @@
         "dist/docker/mnt",
         "docker/mnt"
       ],
+      [
+        "dist/docker/tmp",
+        "docker/tmp"
+      ],
       [
         "dist/docker/mysql",
         "docker/mysql"

dist/docker/tmp/.gitignore

@@ -16,6 +16,7 @@
 use Magento\MagentoCloud\Filesystem\Driver\File;
 use Magento\MagentoCloud\Filesystem\FileSystemException;
 use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -161,7 +162,7 @@ public function execute(InputInterface $input, OutputInterface $output)
 
         $this->getApplication()
             ->find(ConfigConvert::NAME)
-            ->run($input, $output);
+            ->run(new ArrayInput([]), $output);
 
         $output->writeln('<info>Configuration was built.</info>');
     }

src/Command/Docker/Build.php

@@ -130,8 +130,7 @@ public function build(Repository $config): array
             [
                 'ports' => [9000],
                 'depends_on' => ['db'],
-                'volumes_from' => ['appdata'],
-                'volumes' => [$this->getMagentoVolume(true)],
+                'volumes' => $this->getMagentoVolumes(true),
                 'env_file' => [
                     './docker/global.env',
                     './docker/config.env',
@@ -145,33 +144,33 @@ public function build(Repository $config): array
             $config->get(self::NGINX_VERSION, self::DEFAULT_NGINX_VERSION),
             [
                 'depends_on' => ['fpm', 'db'],
-                'volumes_from' => ['appdata'],
-                'volumes' => [
-                    $this->getMagentoVolume(true),
-                ],
+                'volumes' => $this->getMagentoVolumes(true),
                 'env_file' => [
                     './docker/global.env',
                     './docker/config.env',
                 ],
             ]
         );
         $services['cron'] = $this->getCronCliService($phpVersion, true, $cliDepends, 'cron.magento2.docker');
-        $services['appdata'] = [
-            'image' => 'tianon/true',
-            'volumes' => [
-                './docker/mnt:/mnt',
-                self::DIR_MAGENTO . '/var',
-                self::DIR_MAGENTO . '/app/etc',
-                self::DIR_MAGENTO . '/pub/static',
-                self::DIR_MAGENTO . '/pub/media',
-                self::DIR_MAGENTO . '/vendor',
-                self::DIR_MAGENTO . '/generated'
-            ],
+
+        $volumeConfig = [
+            'driver_opts' => [
+                'type' => 'tmpfs',
+                'device' => 'tmpfs'
+            ]
         ];
 
         return [
-            'version' => '2',
+            'version' => '3',
             'services' => $services,
+            'volumes' => [
+                'magento-vendor' => $volumeConfig,
+                'magento-generated' => $volumeConfig,
+                'magento-var' => $volumeConfig,
+                'magento-etc' => $volumeConfig,
+                'magento-static' => $volumeConfig,
+                'magento-media' => $volumeConfig,
+            ]
         ];
     }
 
@@ -185,13 +184,46 @@ public function getConfigPath(): string
 
     /**
      * @param bool $isReadOnly
-     * @return string
+     * @return array
      */
-    private function getMagentoVolume(bool $isReadOnly): string
+    private function getMagentoVolumes(bool $isReadOnly): array
     {
-        $volume = '.:' . self::DIR_MAGENTO;
+        $flag = $isReadOnly ? ':ro' : ':rw';
+
+        return [
+            './:' . self::DIR_MAGENTO . $flag,
+            'magento-vendor:' . self::DIR_MAGENTO . '/vendor' . $flag,
+            'magento-generated:' . self::DIR_MAGENTO . '/generated' . $flag,
+            'magento-var:' . self::DIR_MAGENTO . '/var:rw',
+            'magento-etc:' . self::DIR_MAGENTO . '/app/etc:rw',
+            'magento-static:' . self::DIR_MAGENTO . '/pub/static:rw',
+            'magento-media:' . self::DIR_MAGENTO . '/pub/media:rw',
+        ];
+    }
+
+    /***
+     * @return array
+     */
+    private function getComposerVolumes(): array
+    {
+        $composeCacheDirectory = file_exists(getenv('HOME') . '/.cache/composer')
+            ? '~/.cache/composer'
+            : '~/.composer/cache';
 
-        return $isReadOnly ? $volume . ':ro' : $volume . ':rw';
+        return [
+            $composeCacheDirectory . ':/root/.composer/cache',
+        ];
+    }
+
+    /**
+     * @return array
+     */
+    private function getSharedVolumes(): array
+    {
+        return [
+            './docker/mnt:/mnt',
+            './docker/tmp:/tmp'
+        ];
     }
 
     /**
@@ -244,21 +276,17 @@ private function getCliService(
         array $depends,
         string $hostname
     ): array {
-        $composeCacheDirectory = file_exists(getenv('HOME') . '/.cache/composer')
-            ? '~/.cache/composer'
-            : '~/.composer/cache';
-
         $config = $this->serviceFactory->create(
             ServiceFactory::SERVICE_CLI,
             $version,
             [
                 'hostname' => $hostname,
                 'depends_on' => $depends,
-                'volumes' => [
-                    $composeCacheDirectory . ':/root/.composer/cache',
-                    $this->getMagentoVolume($isReadOnly),
-                ],
-                'volumes_from' => ['appdata'],
+                'volumes' => array_merge(
+                    $this->getMagentoVolumes($isReadOnly),
+                    $this->getComposerVolumes(),
+                    $this->getSharedVolumes()
+                ),
                 'env_file' => [
                     './docker/global.env',
                     './docker/config.env',