Skip to content

Commit 66ff64a

Browse files
Merge branch 'develop' into MCLOUD-8958
2 parents 0ed8cdc + 9125bcd commit 66ff64a

File tree

5 files changed

+10
-9
lines changed

5 files changed

+10
-9
lines changed

.github/CONTRIBUTING.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,17 @@ You must have a [GitHub account](https://help.github.com/en/github/getting-start
1313

1414
## Contribution requirements
1515

16-
1. Contributions must adhere to the [Magento coding standards](https://devdocs.magento.com/guides/v2.3/coding-standards/bk-coding-standards.html).
16+
1. Contributions must adhere to the [coding standards](https://developer.adobe.com/commerce/php/coding-standards/).
1717
2. When you submit a Pull request (PR), write a meaningful description to explain the purpose of your contribution. Comprehensive descriptions increase the chances that a pull request can be merged quickly, without requests for additional clarification. See the [Magento Cloud Tools Pull Request Template](https://github.com/magento/ece-tools/blob/develop/.github/PULL_REQUEST_TEMPLATE.md) for more information.
1818
3. Commits must be accompanied by meaningful commit messages.
1919
4. If your PR includes bug fixes, provide a step-by-step description of how to reproduce the bug in the pull request description.
20-
3. If your PR includes new logic or new features, you must also submit the following information along with the pull request
20+
5. If your PR includes new logic or new features, you must also submit the following information along with the pull request
2121
* Unit/integration test coverage
22-
* Proposed documentation updates: Submit developer documentation contributions to the [Magento DevDocs repository](https://github.com/magento/devdocs/blob/master/.github/CONTRIBUTING.md). Submit updates to Magento user documentation to the [Magento Merchant documentation repository](https://github.com/magento/merchdocs/blob/master/.github/CONTRIBUTING.md).
23-
4. For larger features or changes, [open an issue](https://github.com/magento/ece-tools/issues/new) to discuss the proposed changes prior to development. Discussing the updates in advance can prevent duplicate or unnecessary effort and allow other contributors to provide input.
22+
* Proposed [documentation](https://developer.adobe.com/commerce) updates. Use feedback buttons __Edit in GitHub__ and __Log an issue__ at the top of a relevant topic.
23+
6. For larger features or changes, [open an issue](https://github.com/magento/ece-tools/issues/new) to discuss the proposed changes prior to development. Discussing the updates in advance can prevent duplicate or unnecessary effort and allow other contributors to provide input.
2424

2525
## Contribution process
26+
2627
1. Search current [listed issues](https://github.com/magento/ece-tools/issues) (open or closed) for similar proposals of intended contribution before starting work on a new contribution.
2728
2. Review and sign the [Contributor License Agreement (CLA)](https://opensource.adobe.com/cla.html) if this is your first time contributing. You only need to sign the CLA once.
2829
3. Create and test your work.

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535
### Release notes
3636

37-
For user-facing changes, add a meaningful release note. For examples, see [Magento Cloud ECE-tools release notes](https://devdocs.magento.com/cloud/release-notes/ece-release-notes.html).
37+
For user-facing changes, add a meaningful release note. For examples, see [Magento Cloud ECE-tools release notes](https://experienceleague.adobe.com/docs/commerce-cloud-service/user-guide/release-notes/ece-tools-package.html).
3838

3939
### Associated documentation updates
4040
<!--

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ The Magento Cloud Suite includes a set of packages designed to deploy and manage
1818

1919
## Useful Resources
2020
- [Release Notes](https://github.com/magento/ece-tools/releases)
21-
- [Magento Cloud Guide DevDocs](https://devdocs.magento.com/cloud/bk-cloud.html)
21+
- [Magento Cloud Guide DevDocs](https://experienceleague.adobe.com/docs/commerce-cloud-service/user-guide/overview.html)
2222
- [Cloud Knowledge Base and Support](https://support.magento.com)
2323
- [Cloud Slack Channel](https://magentocommeng.slack.com) (join #cloud and #cloud-docker)
2424

src/Util/PasswordGenerator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function generateRandomPassword(int $length = 20): string
4545
{
4646
while (true) {
4747
$password = $this->generateRandomString($length);
48-
/* http://docs.magento.com/m2/ee/user_guide/stores/admin-signin.html
48+
/* https://experienceleague.adobe.com/docs/commerce-admin/start/admin/admin-signin.html#admin-sign-in
4949
* An Admin password must be seven or more characters long, and include both letters and numbers.
5050
*/
5151
if ((preg_match('/.*[A-Za-z].*/', $password)) && (preg_match('/.*[\d].*/', $password))) {

tests/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,15 @@ This test will generate a pretty report for unit test coverage.
3838

3939
1. Run the command `composer test:coverage`
4040
2. Observe result in CLI output
41-
- Be sure to enable [xDebug](http://devdocs.magento.com/guides/v2.2/cloud/howtos/debug.html) for this test
41+
- Be sure to enable [xDebug](https://experienceleague.adobe.com/docs/commerce-cloud-service/user-guide/develop/test/debug.html) for this test
4242

4343
## Code coverage report
4444

4545
This test will generate a pretty report for unit test coverage.
4646

4747
1. Run the command `composer test:coverage-generate`
4848
2. Navigate to `tests/unit/tmp/coverage` and open `index.html` file in browser
49-
- Be sure to enable [xDebug](http://devdocs.magento.com/guides/v2.2/cloud/howtos/debug.html) for this test
49+
- Be sure to enable [xDebug](https://experienceleague.adobe.com/docs/commerce-cloud-service/user-guide/develop/test/debug.html) for this test
5050

5151
## Best practices
5252

0 commit comments

Comments
 (0)