MAGECLOUD-1491: Error Messages for Config Scanner Improvement (#136)

oshmyheliuk · Bohdan Korablov · commit 61e64245a741 · 2018-01-12T10:59:56.000+02:00
diff --git a/src/Command/ConfigDump.php b/src/Command/ConfigDump.php
@@ -16,7 +16,7 @@
  */
 class ConfigDump extends Command
 {
-    const NAME = 'dump';
+    const NAME = 'config:dump';
 
     /**
      * @var LoggerInterface
@@ -46,7 +46,8 @@ public function __construct(ProcessInterface $process, LoggerInterface $logger)
     protected function configure()
     {
         $this->setName(static::NAME)
-            ->setDescription('Dump static content');
+            ->setDescription('Dump configuration for static content deployment.')
+            ->setAliases(['dump']);
 
         parent::configure();
     }
diff --git a/src/Config/Validator/Build/ConfigFileStructure.php b/src/Config/Validator/Build/ConfigFileStructure.php
@@ -72,7 +72,7 @@ public function validate(): Validator\ResultInterface
                 PHP_EOL,
                 [
                     'To speed up the deploy process, please run the following commands:',
-                    '1. bin/magento app:config:dump',
+                    '1. php ./vendor/bin/ece-tools config:dump',
                     '2. git add -f app/etc/config.php',
                     '3. git commit -m \'Updating config.php\'',
                     '4. git push'
diff --git a/src/Test/Unit/Config/Validator/Build/ConfigFileStructureTest.php b/src/Test/Unit/Config/Validator/Build/ConfigFileStructureTest.php
@@ -126,7 +126,7 @@ public function testRunScdConfigNotExists()
                 [
                     'error' => 'No stores/website/locales found in config.php',
                     'suggestion' => 'To speed up the deploy process, please run the following commands:' . PHP_EOL
-                        . '1. bin/magento app:config:dump' . PHP_EOL
+                        . '1. php ./vendor/bin/ece-tools config:dump' . PHP_EOL
                         . '2. git add -f app/etc/config.php' . PHP_EOL
                         . '3. git commit -m \'Updating config.php\'' . PHP_EOL
                         . '4. git push'

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`*/`
`17`	`17`	`class ConfigDump extends Command`
`18`	`18`	`{`
`19`		`- const NAME = 'dump';`
	`19`	`+ const NAME = 'config:dump';`
`20`	`20`
`21`	`21`	`/**`
`22`	`22`	`* @var LoggerInterface`
`@@ -46,7 +46,8 @@ public function __construct(ProcessInterface $process, LoggerInterface $logger)`
`46`	`46`	`protected function configure()`
`47`	`47`	`{`
`48`	`48`	`$this->setName(static::NAME)`
`49`		`- ->setDescription('Dump static content');`
	`49`	`+ ->setDescription('Dump configuration for static content deployment.')`
	`50`	`+ ->setAliases(['dump']);`
`50`	`51`
`51`	`52`	`parent::configure();`
`52`	`53`	`}`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public function validate(): Validator\ResultInterface`
`72`	`72`	`PHP_EOL,`
`73`	`73`	`[`
`74`	`74`	`'To speed up the deploy process, please run the following commands:',`
`75`		`- '1. bin/magento app:config:dump',`
	`75`	`+ '1. php ./vendor/bin/ece-tools config:dump',`
`76`	`76`	`'2. git add -f app/etc/config.php',`
`77`	`77`	`'3. git commit -m \'Updating config.php\'',`
`78`	`78`	`'4. git push'`
Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ public function testRunScdConfigNotExists()`
`126`	`126`	`[`
`127`	`127`	`'error' => 'No stores/website/locales found in config.php',`
`128`	`128`	`'suggestion' => 'To speed up the deploy process, please run the following commands:' . PHP_EOL`
`129`		`- . '1. bin/magento app:config:dump' . PHP_EOL`
	`129`	`+ . '1. php ./vendor/bin/ece-tools config:dump' . PHP_EOL`
`130`	`130`	`. '2. git add -f app/etc/config.php' . PHP_EOL`
`131`	`131`	`. '3. git commit -m \'Updating config.php\'' . PHP_EOL`
`132`	`132`	`. '4. git push'`