Skip to content

Commit 4b7dec7

Browse files
ngeronBohdan Korablov
authored andcommitted
MAGECLOUD-862 Correcting issue with config:set on setSecureAdmin (#45)
* MAGECLOUD-862 Correcting issue with config:set on setSecureAdmin * MAGECLOUD-862: Correcting issue with config:set on setSecureAdmin
1 parent e67c38c commit 4b7dec7

File tree

5 files changed

+3
-155
lines changed

5 files changed

+3
-155
lines changed

src/App/Container.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ public function __construct(string $root, array $config)
106106
'processes' => [
107107
$this->make(DeployProcess\InstallUpdate\Install\EmailChecker::class),
108108
$this->make(DeployProcess\InstallUpdate\Install\Setup::class),
109-
$this->make(DeployProcess\InstallUpdate\Install\SecureAdmin::class),
110109
$this->make(DeployProcess\InstallUpdate\ConfigUpdate::class),
111110
$this->make(DeployProcess\InstallUpdate\Install\ConfigImport::class),
112111
$this->make(DeployProcess\InstallUpdate\Install\ResetPassword::class),

src/Process/Deploy/InstallUpdate/Install/SecureAdmin.php

Lines changed: 0 additions & 68 deletions
This file was deleted.

src/Process/Deploy/InstallUpdate/Install/Setup.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,8 @@ public function execute()
9191
? $this->environment->getAdminLastname() : Environment::DEFAULT_ADMIN_LASTNAME)
9292
. ' --admin-email=' . escapeshellarg($this->environment->getAdminEmail())
9393
. ' --admin-password=' . escapeshellarg($this->environment->getAdminPassword()
94-
? $this->environment->getAdminPassword() : $this->passwordGenerator->generateRandomPassword());
94+
? $this->environment->getAdminPassword() : $this->passwordGenerator->generateRandomPassword())
95+
. ' --use-secure-admin=1';
9596

9697
$dbPassword = $this->environment->getDbPassword();
9798
if (strlen($dbPassword)) {

src/Test/Unit/Process/Deploy/InstallUpdate/Install/SecureAdminTest.php

Lines changed: 0 additions & 85 deletions
This file was deleted.

src/Test/Unit/Process/Deploy/InstallUpdate/Install/SetupTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ public function testExecute(
144144
. ' --backend-frontname=\'' . $adminUrlExpected . '\' --admin-user=\'' . $adminNameExpected . '\''
145145
. ' --admin-firstname=\'' . $adminFirstnameExpected . '\' --admin-lastname=\'' . $adminLastnameExpected
146146
. '\' --admin-email=\'admin@example.com\' --admin-password=\'' . $adminPasswordExpected . '\''
147+
. ' --use-secure-admin=1'
147148
. ' --db-password=\'password\' -v'
148149
);
149150

0 commit comments

Comments
 (0)