Skip to content

Commit 3d1c570

Browse files
BaDosshiftedreality
authored andcommitted
MAGECLOUD-5117: Fix failing cron Functional Test (#672)
1 parent 3a5d96d commit 3d1c570

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

src/Test/Functional/Acceptance/Cron22Cest.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,15 @@ protected function cronDataProvider(): array
2727
],
2828
],
2929
],
30+
[
31+
'version' => '2.2.4',
32+
'variables' => [
33+
'MAGENTO_CLOUD_VARIABLES' => [
34+
'ADMIN_EMAIL' => 'admin@example.com',
35+
'ADMIN_LOCALE' => 'ar_KW'
36+
],
37+
],
38+
],
3039
[
3140
'version' => '2.2.5',
3241
'variables' => [

src/Test/Functional/Acceptance/CronCest.php

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,12 @@ public function testCron(\CliTester $I, \Codeception\Example $data)
5555
$I->assertTrue($I->runBinMagentoCommand('cron:run', Docker::DEPLOY_CONTAINER));
5656

5757
$successfulJobs2 = $I->grabNumRecords('cron_schedule', ['job_code' => 'cron_test_job', 'status' => 'success']);
58-
$I->assertEquals($successfulJobs1, $successfulJobs2, 'Number of successful jobs changed');
58+
59+
if (version_compare($data['version'], '2.2.5', '<')) {
60+
$I->assertEquals($successfulJobs1, $successfulJobs2, 'Number of successful jobs changed');
61+
} else {
62+
$I->assertGreaterThan($successfulJobs1, $successfulJobs2, 'Number of successful jobs did not change');
63+
}
5964

6065
$I->updateInDatabase(
6166
'cron_schedule',
@@ -76,7 +81,11 @@ public function testCron(\CliTester $I, \Codeception\Example $data)
7681
$I->assertTrue($I->runBinMagentoCommand('cron:run', Docker::DEPLOY_CONTAINER));
7782

7883
$successfulJobs3 = $I->grabNumRecords('cron_schedule', ['job_code' => 'cron_test_job', 'status' => 'success']);
79-
$I->assertGreaterThan($successfulJobs1, $successfulJobs3, 'Number of successful jobs did not change');
84+
$I->assertGreaterThan(
85+
version_compare($data['version'], '2.2.5', '<') ? $successfulJobs1 : $successfulJobs2,
86+
$successfulJobs3,
87+
'Number of successful jobs did not change'
88+
);
8089
}
8190

8291
/**

0 commit comments

Comments
 (0)