Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Commit f0a21b2

Browse files
authored
Merge pull request #8459 from chrisfwd/bugfix/#8458-getviewmodel-results-in-null
#8458 getViewModel() results in null
2 parents 21ebf3f + 11ab575 commit f0a21b2

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/guides/v2.3/extension-dev-guide/view-models.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ View models can be used by passing the view model class as an argument to a temp
2424
```xml
2525
<block name="orangeco.new.viewmodel" template="OrangeCompany_Catalog::example.phtml">
2626
<arguments>
27-
<argument name="viewModel" xsi:type="object">OrangeCompany\Catalog\ViewModel\MyNewViewModel</argument>
27+
<argument name="view_model" xsi:type="object">OrangeCompany\Catalog\ViewModel\MyNewViewModel</argument>
2828
</arguments>
2929
</block>
3030
```
@@ -34,7 +34,7 @@ In the following example, the same view model is used with an existing block in
3434
```xml
3535
<referenceBlock name="checkout.cart.item.renderers.default">
3636
<arguments>
37-
<argument name="viewModel" xsi:type="object">OrangeCompany\Catalog\ViewModel\MyNewViewModel</argument>
37+
<argument name="view_model" xsi:type="object">OrangeCompany\Catalog\ViewModel\MyNewViewModel</argument>
3838
</arguments>
3939
</referenceBlock>
4040
```
@@ -78,7 +78,7 @@ The view model class is passed as an argument to the `product.info.upsell` block
7878
<block class="Magento\Catalog\Block\Product\ProductList\Upsell" name="product.info.upsell" template="Magento_Catalog::product/list/items.phtml">
7979
<arguments>
8080
<argument name="type" xsi:type="string">upsell</argument>
81-
<argument name="viewModel" xsi:type="object">Magento\Catalog\ViewModel\Product\Listing\PreparePostData</argument>
81+
<argument name="view_model" xsi:type="object">Magento\Catalog\ViewModel\Product\Listing\PreparePostData</argument>
8282
</arguments>
8383
</block>
8484
```

src/guides/v2.3/frontend-dev-guide/layouts/xml-instructions.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ There are examples of all argument types.
319319
- The *object* type:
320320

321321
```xml
322-
<argument name="viewModel" xsi:type="object">Vendor\CustomModule\ViewModel\Class</argument>
322+
<argument name="view_model" xsi:type="object">Vendor\CustomModule\ViewModel\Class</argument>
323323
```
324324

325325
The `Vendor\CustomModule\ViewModel\Class` class should implement the `\Magento\Framework\View\Element\Block\ArgumentInterface` interface.
@@ -394,7 +394,7 @@ $someString = $block->getData('some_string'); //or $block->getSomeString()
394394
$isActive = $block->getData('is_active'); //or $block->getIsActive()
395395

396396
/** @var Vendor\CustomModule\ViewModel\Class|\Magento\Framework\View\Element\Block\ArgumentInterface $viewModel */
397-
$viewModel = $block->getData('viewModel'); //or $block->getViewModel()
397+
$viewModel = $block->getData('view_model'); //or $block->getViewModel()
398398

399399
/** @var string|int|float $someNumber */
400400
$someNumber = $block->getData('some_number'); //or $block->getSomeNumber()

src/guides/v2.3/frontend-dev-guide/layouts/xml-manage.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,7 @@ Let us say that we want to add functionality to a core template with custom logi
510510
<body>
511511
<referenceBlock name="checkout.cart.item.renderers.default">
512512
<arguments>
513-
<argument name="viewModel" xsi:type="object">Vendor\CustomModule\ViewModel\Class</argument>
513+
<argument name="view_model" xsi:type="object">Vendor\CustomModule\ViewModel\Class</argument>
514514
</arguments>
515515
</referenceBlock>
516516
</body>
@@ -539,7 +539,7 @@ Then, in the `cart/item/default.phtml` file, use the viewModel:
539539

540540
```php
541541
/** @var \Vendor\CustomModule\ViewModel\Class $viewModel */
542-
$viewModel = $block->getData('viewModel');
542+
$viewModel = $block->getViewModel();
543543

544544
$viewModel->canShowAdditionalData();
545545
```

0 commit comments

Comments
 (0)