Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Commit ce90fb4

Browse files
committed
AC-1537: Added UCT error codes coming from magento-coding-standards
1 parent 8513a04 commit ce90fb4

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/_includes/upgrade/uct-error-reference.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ Custom code errors are raised when custom code is using the Adobe Commerce entry
8181
| 1327 | Inherited non Adobe Commerce API interface | Constants that are not marked as `@api` may be changed. Consider introducing and using a private constant of the required value within the custom code instead. |
8282
| 1328 | Implemented non Adobe Commerce API interface | Interfaces not marked as `@api` may be changed. Consider removing this inheritance or replacing it with inheritance from the Adobe Commerce interface that is marked as `@api` or an interface introduced in the scope of customization code. |
8383
| 1420 | Instantiating non Adobe Commerce API class/interface | Classes that are not marked as `@api` may be changed. Consider updating the code to rely on the interface marked as `@api` instead. Otherwise, the functionality relying on this implementation should be tested after the upgrade. Also, the recommended way of retrieving an instance of the class is using DI. Consider using a factory if a new instance of the class is required. |
84-
| 1428 | Possible dependency on implementation details. Usage of `%s` should be declared instead of `%s` | Classes that are not marked as `@api` may be changed. Consider updating the code to rely on the interface marked as `@api` instead. Otherwise, the functionality relying on this implementation should be tested after the upgrade. |
84+
| 1428 | Possible dependency on implementation details. Usage of `xx` should be declared instead of `xx` | Classes that are not marked as `@api` may be changed. Consider updating the code to rely on the interface marked as `@api` instead. Otherwise, the functionality relying on this implementation should be tested after the upgrade. |
8585
| 1429 | Call non Adobe Commerce API methods | Methods that are not marked as `@api` or are not declared within API class/interface may be changed. Even if the interface of the method is not updated in the new version, its behaviour or output can be different. Consider relying on an interface method. Otherwise, the functionality relying on this implementation should be tested after the upgrade. |
8686
| 1449 | Call to non-interface method (that is present in implementation) | Methods that are not declared in the interface may be changed. Consider relying on an interface method. Otherwise, the functionality relying on this implementation should be tested after the upgrade. |
8787
| 1524 | Using non Adobe Commerce API property | Values of the properties that are not marked as `@api` may be changed. Consider relying on the API interface method instead. |
@@ -123,7 +123,7 @@ Custom code errors are raised when custom code is using the Adobe Commerce entry
123123
| 5028 | Access to protected and private members of `Block` class is obsolete in phtml templates | Use only public members |
124124
| 5029 | Please do not use `"jquery/ui"` library in templates | Use needed jquery ui widget instead |
125125
| 5030 | Please do not initialize JS component in PHP | initialize JS component in template |
126-
| 5031 | Contains obsolete method `'xxx'` | Please use `getConnection()` method instead. |
126+
| 5031 | Contains obsolete method `xx` | Please use `getConnection()` method instead. |
127127
| 5032 | `loadLayout` method is deprecated | Please use `\Magento\Framework\View\Layout\Builder::build` instead. |
128128
| 5033 | `renderLayout` method is deprecated | Please use `\Magento\Framework\Controller\ResultInterface::renderResult` instead. |
129129
| 5034 | `_redirect` method is deprecated | Please use `\Magento\Backend\Model\View\Result\Redirect::render` instead. |
@@ -145,7 +145,7 @@ Custom code errors are raised when custom code is using the Adobe Commerce entry
145145
| 5050 | The block being referenced is removed | Remove reference to block |
146146
| 5051 | `output="toHtml"` is obsolete | Use `output="1"` |
147147
| 5052 | The class `\Magento\Framework\View\Element\Text\ListText` is not supposed to be used in layout anymore | Remove class `\Magento\Framework\View\Element\Text\ListText` from layout |
148-
| 5053 | Call of method "xx" via layout instruction `<action>` is not allowed | Avoid using offending method in <action> |
148+
| 5053 | Call of method `xx` via layout instruction `<action>` is not allowed | Avoid using offending method in <action> |
149149
| 5054 | `helper` attribute contains `/` | Remove `/` from helper attribute |
150150
| 5055 | `helper` attribute does not contain `::` | Add `::` to helper attribute |
151151
| 5056 | Install scripts are obsolete | Please use declarative schema approach in module\'s etc/db_schema.xml file |
@@ -159,7 +159,7 @@ Custom code errors are raised when custom code is using the Adobe Commerce entry
159159
| 5064 | Recurring scripts are obsolete | Please create class Recurring in module\'s Setup folder |
160160
| 5065 | 'data' is in an invalid directory | Create a data patch within module's Setup/Patch/Data folder for data upgrades or use declarative schema approach in module's etc/db_schema.xml file for schema changes. |
161161
| 5066 | 'sql' is in an invalid directory | Create a data patch within module's Setup/Patch/Data folder for data upgrades or use declarative schema approach in module's etc/db_schema.xml file for schema changes. |
162-
| 5067 | Nodes identified by XPath 'xx' are obsolete | Use suggestion from error message itself |
162+
| 5067 | Nodes identified by XPath `xx` are obsolete | Use suggestion from error message itself |
163163
| 5068 | Directive `{{htmlescape}}` is obsolete | Use `{{var}}` instead |
164164
| 5069 | Directive `{{escapehtml}}` is obsolete | Use `{{var}}` instead |
165165
| 5070 | 3rd parameter is not needed anymore for `getChildHtml()` | Remove 3rd parameter from call to `getChildHtml()` |
@@ -168,11 +168,11 @@ Custom code errors are raised when custom code is using the Adobe Commerce entry
168168
| 5073 | Legacy table names with slash must be fixed to direct table names | Use direct table name instead |
169169
| 5074 | Use of deprecated method `getResource()` to (save / load / delete) data detected. | Use a repository instead |
170170
| 5075 | Application modules should not use classes from test modules | Remove usage of classes from test modules |
171-
| 5076 | Cannot use "xxx" in namespace as it is reserved since PHP 7 | Remove usage of "xxx" from namespace |
172-
| 5077 | Cannot use "xxx" as class name as it is reserved since PHP 7 | Remove usage of "xxx" from class name |
171+
| 5076 | Cannot use `xx` in namespace as it is reserved since PHP 7 | Remove usage of `xx` from namespace |
172+
| 5077 | Cannot use `xx` as class name as it is reserved since PHP 7 | Remove usage of `xx` from class name |
173173
| 5078 | Class needs to be requested in constructor, otherwise compiler will not be able to find and generate these classes | Add class to constructor |
174174
| 5079 | Use of var class variables is discouraged | Avoid using 'var' to declare class variable |
175-
| 5080 | Possible raw SQL statement 'xx' detected | Use repositories or data patches instead |
175+
| 5080 | Possible raw SQL statement `xx` detected | Use repositories or data patches instead |
176176
| 5081 | The use of helpers in templates is discouraged | Use ViewModel instead |
177177
| 5082 | The use of $this in templates is deprecated | Use $block instead |
178178
| 5083 | Constants are not allowed as the first argument of translation function | use string literal instead |

0 commit comments

Comments
 (0)