Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Commit c3e392d

Browse files
authored
Merge branch 'master' into release-note-update-MC-38509
2 parents c7e0369 + b392fe4 commit c3e392d

29 files changed

+528
-472
lines changed

.github/MAINTAINER_GUIDELINES.md

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,13 @@ In general, the same [guidelines](https://devdocs.magento.com/contributor-guide/
44

55
## General expectations
66

7-
- Self assign issues/pull requests (mostly pull requests)
8-
- Review and approve or request changes
9-
- Enforce the use of the issue/pull requests template
10-
- Ask contributors to link to the code base to validate documentation updates when applicable
11-
- Ask contributors not to contribute to unsupported versions of documentation when applicable
12-
- If a DevDocs maintainer creates a pull request, it must be reviewed by another maintainer or DevDocs admin
7+
- Self assign issues/pull requests (mostly pull requests). See the [Pull Request Process wiki topic](https://github.com/magento/devdocs/wiki/Pull-Request-Process) to learn more.
8+
- Review and approve, or request changes.
9+
- Enforce the use of the issue/pull request template.
10+
- Ask contributors to link to the code base to validate documentation updates when applicable.
11+
- Ask contributors not to contribute to unsupported versions of documentation when applicable.
12+
- Ask contributors to add a [`whatsnew`](https://github.com/magento/devdocs/wiki/Pull-Request-Process) to their `New Topic`, `Major Update`, or `Technical` labeled PRs.
13+
- If a DevDocs maintainer creates a pull request, it must be reviewed by another maintainer or DevDocs admin.
1314

1415
## Labels
1516

@@ -23,12 +24,21 @@ Here is a brief summary of the most important labels:
2324
- `Editorial`: Typos, grammatical inconsistencies, or minor rewrites
2425
- `small changes`: See [Small changes workflow](#small-changes-workflow)
2526

27+
PRs with the `Internal Dev` label were created by Magento/Adobe employees and will be handled by the Documentation team only.
28+
2629
We also use version labels when appropriate (for example, 2.3.x).
2730

2831
As a maintainer, we expect you to add or remove labels according to these guidelines.
2932

3033
See https://github.com/magento/devdocs/labels for all labels and their descriptions.
3134

35+
## Communicating internally and externally
36+
37+
There may be instances in which a maintainer has questions about a specific PR or issue. There are proper channels for communicating internally (Magento) and externally (contributors):
38+
39+
- Externally: Questions, revisions, or other conversation with the contributor must happen within the applicable PR or issue. Tag the contributor, if needed, to get their attention.
40+
- Internally: Questions for the Magento Documentation team about a PR or issue can happen as a comment in the applicable PR or issue or within the #devdocs_maintainers channel in Magento Community Engineering Slack. If your question pertains to a specific team member, you can tag their name to initiate the conversation.
41+
3242
## Testing
3343

3444
We use a private CI/CD stack and do not provide access to it.

src/_data/toc/cloud-guide.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ pages:
343343
versionless: true
344344

345345
- label: IP allow list
346-
url: /cloud/cdn/fastly-vcl-whitelist.html
346+
url: /cloud/cdn/fastly-vcl-allowlist.html
347347
versionless: true
348348

349349
- label: IP block list

src/_data/toc/marketplace-sellers.yml

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,24 @@ pages:
103103
url: /marketplace/sellers/technical-review-guidelines.html
104104
versionless: true
105105

106-
- label: Code Validation
107-
url: /marketplace/sellers/code-validation.html
106+
- label: Malware Scan
107+
url: /marketplace/sellers/malware-scan.html
108+
versionless: true
109+
110+
- label: Code Sniffer
111+
url: /marketplace/sellers/code-sniffer.html
112+
versionless: true
113+
114+
- label: Installation and Varnish Tests
115+
url: /marketplace/sellers/installation-and-varnish-tests.html
116+
versionless: true
117+
118+
- label: Copy Paste Detector
119+
url: /marketplace/sellers/copy-paste-detector.html
120+
versionless: true
121+
122+
- label: Semantic Version Check
123+
url: /marketplace/sellers/semantic-version-check.html
108124
versionless: true
109125

110126
- label: Submit for Marketing Review
@@ -153,12 +169,3 @@ pages:
153169
- label: Analytics
154170
url: /marketplace/sellers/analytics.html
155171
versionless: true
156-
157-
- label: Technical Reference
158-
url: /marketplace/sellers/technical-reference.html
159-
versionless: true
160-
children:
161-
162-
- label: Packaging v1.x Extensions
163-
url: /marketplace/sellers/packaging-v1x-extensions.html
164-
versionless: true

src/cloud/architecture/pro-architecture.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ You cannot create a branch from the Production environment branch. You must push
148148

149149
Rather than running a traditional, active-passive master or a master-slave setup, {{site.data.var.ece}} runs a redundant architecture where all three instances accept reads and writes. This architecture offers zero downtime when scaling and provides guaranteed transactional integrity.
150150

151-
Because of our unique, redundant hardware, we can provide you with three gateway servers. Most external services enable you to [whitelist](https://glossary.magento.com/whitelist) multiple IP addresses, so having more than one fixed IP address is not a problem.
151+
Because of our unique, redundant hardware, we can provide you with three gateway servers. Most external services enable you to add multiple IP addresses to an [allowlist](https://glossary.magento.com/whitelist), so having more than one fixed IP address is not a problem.
152152

153153
The three gateways map to the three servers in your Production environment cluster and retain static IP addresses. It is fully redundant and highly available at every level:
154154

src/cloud/cdn/fastly-vcl-allowlist.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
---
22
group: cloud-guide
33
title: Custom VCL for allowing requests
4-
redirect_from:
5-
- /cloud/configure/fastly-vcl-whitelist.html
64
functional_areas:
75
- Cloud
86
- Setup
@@ -89,11 +87,11 @@ In the code sample, the condition `!req.http.Fastly-FF` is important when using
8987

9088
After reviewing and updating the code for your environment, use either of the following methods to add the custom VCL snippet to your Fastly service configuration:
9189

92-
- [Add the custom VCL snippet from the Magento Admin](#add-whitelist-vcl). This method is recommended if you can access the Magento Admin UI. (Requires [Fastly CDN module for Magento 2 version 1.2.58]({{site.baseurl}}/cloud/cdn/configure-fastly.html#upgrade) or later.)
90+
- [Add the custom VCL snippet from the Magento Admin](#add-the-custom-vcl-snippet). This method is recommended if you can access the Magento Admin UI. (Requires [Fastly CDN module for Magento 2 version 1.2.58]({{site.baseurl}}/cloud/cdn/configure-fastly.html#upgrade) or later.)
9391

9492
- Save the JSON code example to a file (for example, `allowlist.json`) and [upload it using the Fastly API]({{site.baseurl}}/cloud/cdn/cloud-vcl-custom-snippets.html#manage-custom-vcl-snippets-using-the-api). Use this method if you cannot access the Magento Admin UI.
9593

96-
## Add the custom VCL snippet {#add-whitelist-vcl}
94+
## Add the custom VCL snippet
9795

9896
{% include cloud/admin-ui-login-step.md %}
9997

src/cloud/env/environments-start.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ To activate an inactive environment, use the `magento-cloud environment:activate
112112

113113
The following table lists incoming and outgoing IP addresses used by {{site.data.var.ece}} [Integration environments]({{ site.baseurl }}/cloud/architecture/pro-architecture.html#cloud-arch-int). These IP addresses are stable, but might change. We always notify customers before making any IP address changes.
114114

115-
If you have a corporate firewall that blocks outgoing SSH connections, you can add the inbound IP addresses to your whitelist.
115+
If you have a corporate firewall that blocks outgoing SSH connections, you can add the inbound IP addresses to your allowlist.
116116

117117
### AWS regions
118118

src/cloud/live/live.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ content='The security scan tool uses the following public IP addresses:
4949
52.87.98.44
5050
```
5151

52-
You must whitelist these IP addresses in your network firewall rules to allow the tool to scan your site. The tool posts requests to ports 80 and 443 only.'
52+
You must add these IP addresses to an allowlist in your network firewall rules to allow the tool to scan your site. The tool posts requests to ports 80 and 443 only.'
5353
%}
5454

5555
The Magento Security Scan Tool enables you to regularly monitor your store websites and receive updates for known security risks, malware, and out-of-date software. This is a free service available for all implementations and versions of {{site.data.var.ece}}. You access the tool through your [Magento Marketplace account](https://account.magento.com/customer/account/login).

src/cloud/project/magento-app-php-ini.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,4 +54,4 @@ cat /etc/php5/fpm/php.ini
5454
```
5555

5656
{:.bs-callout-info}
57-
If you use {{site.data.var.mcd-prod}} for local development, see [Docker service containers]({{site.baseurl}}//cloud/docker/docker-containers-service.html#fpm-container) for information about using a custom `php.ini` file in a Docker environment.
57+
If you use {{site.data.var.mcd-prod}} for local development, see [Docker service containers]({{site.baseurl}}/cloud/docker/docker-containers-service.html#fpm-container) for information about using a custom `php.ini` file in a Docker environment.

src/cloud/project/project-webint-basic.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ Routes allow you to set redirects or upstream settings for applications for your
135135
1. Enter the **Upstream** route.
136136
1. Use the toggle to enable or disable the **Cache** for the route.
137137
1. Enter the cookies to list: No cookies, All cookies, or Specify a specific cookie. You can enter multiple specific cookies.
138-
1. For Headers to Whitelist, select Default Headers or Specify a header. You can enter multiple headers.
138+
1. To add Headers to an allowlist, select Default Headers or Specify a header. You can enter multiple headers.
139139
1. Use the toggle to enable or disable the Server-Side Includes (**SSI**).
140140

141141
1. To configure a Redirect, enter a URL to **Redirect to**. You can use `{default}` in the URL, which is a placeholder for the default domain.

src/cloud/project/sendgrid.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,4 @@ You can find Sendgrid details for your account in the Onboarding UI. Use the `ht
2626

2727
The CNAME records resolve to the Domain Keys Identified Mail (DKIM) and Sender Policy Framework (SPF) records managed by SendGrid, so that spam filters are less likely to inhibit your messages.
2828

29-
Magento does not support whitelisting, but you can review the [Sender Policy Framework (SPF)](https://sendgrid.com/docs/Glossary/spf.html) guidelines to improve delivery.
29+
Magento does not support allowlists, but you can review the [Sender Policy Framework (SPF)](https://sendgrid.com/docs/Glossary/spf.html) guidelines to improve delivery.

0 commit comments

Comments
 (0)