You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Copy file name to clipboardExpand all lines: src/contributor-guide/contributing.md
+7-7Lines changed: 7 additions & 7 deletions
Original file line number
Diff line number
Diff line change
@@ -20,7 +20,7 @@ The Community Engineering Team reviews all issues and contributions submitted by
20
20
When the Community Engineering Team works on reviewing the suggested changes, we will add a label to the issue to indicate certain information, like the status or who is working the issue. See [Labels](#labels) to learn more.
21
21
22
22
{:.bs-callout-tip}
23
-
Refer to [Magento Contributor Agreement](http://www.magento.com/legaldocuments/mca) for detailed information about the License Agreement. All contributors are required to submit a click-through form to agree to the terms.
23
+
Refer to the [Adobe Contributor Agreement](https://opensource.adobe.com/cla.html) for detailed information about the License Agreement. All contributors are required to submit a click-through form to agree to the terms.
24
24
25
25
## Community Backlog Priority {#backlog}
26
26
@@ -97,13 +97,13 @@ It helps maintainers decide:
97
97
98
98
## GitHub and two-factor authentication {#two-factor}
99
99
100
-
Magento**requires all Partners** who contribute code to enable 2FA on their GitHub accounts. You can use a mobile device or 2FA application for added protection. See [Configuring two-factor authentication](https://help.github.com/en/articles/configuring-two-factor-authentication) in the GitHub help.
100
+
Adobe**requires all Partners** who contribute code to enable 2FA on their GitHub accounts. You can use a mobile device or 2FA application for added protection. See [Configuring two-factor authentication](https://help.github.com/en/articles/configuring-two-factor-authentication) in the GitHub help.
101
101
102
102
We also recommend creating a personal access token for your account to use when interacting with GitHub in scripts and on the command line. See [Creating a personal access token for the command line](https://help.github.com/en/articles/creating-a-personal-access-token-for-the-command-line) in the GitHub help.
103
103
104
104
## Questions or enhancement requests? {#question}
105
105
106
-
We capture code-related issues in the [Magento 2 repo](https://github.com/magento/magento2) and documentation-related issues in the [Magento DevDocs repo](https://github.com/magento/devdocs). If you have questions about Magento functionality or processes, we recommend posting them to a question-and-answer site, such as [Stack Exchange](https://magento.stackexchange.com/) and the [Magento Forums](https://community.magento.com/), where Magento community members can quickly provide recommendations and advice.
106
+
We capture code-related issues in the [Magento 2 repo](https://github.com/magento/magento2) and documentation-related issues in the [DevDocs repo](https://github.com/magento/devdocs). If you have questions about Magento functionality or processes, we recommend posting them to a question-and-answer site, such as [Stack Exchange](https://magento.stackexchange.com/) and the [Magento Forums](https://community.magento.com/), where Magento community members can quickly provide recommendations and advice.
107
107
108
108
Submit feature requests or enhancement suggestions to the [Magento 2 Feature Requests and Improvements forum](https://community.magento.com/t5/Magento-2-Feature-Requests-and/idb-p/feature-requests). For details about how requests are managed, see [Improvements to GitHub Management](https://community.magento.com/t5/News-Announcements/Improvements-to-GitHub-Management/m-p/44572#M96).
109
109
@@ -117,8 +117,8 @@ Review the following supported and accepted pull request rules. We defined these
117
117
118
118
## Contribution requirements {#requirements}
119
119
120
-
1. Contributions must adhere to [Magento coding standards]({{ site.gdeurl }}/coding-standards/bk-coding-standards.html).
121
-
1. Refer to the Magento development team's [Definition of Done]({{ site.baseurl }}/contributor-guide/contributing_dod.html). We use these guidelines internally to ensure that we deliver well-tested, well-documented, and solid code. We encourage you to use this as well!
120
+
1. Contributions must adhere to the [coding standards]({{ site.gdeurl }}/coding-standards/bk-coding-standards.html).
121
+
1. Refer to the [Definition of Done]({{ site.baseurl }}/contributor-guide/contributing_dod.html). We use these guidelines internally to ensure that we deliver well-tested, well-documented, and solid code. We encourage you to use this as well!
122
122
1. Pull requests (PRs) must be accompanied by a meaningful description of their purpose. Comprehensive descriptions increase the chances that a pull request is merged quickly and without additional clarification requests.
123
123
1. Commits must be accompanied by meaningful commit messages.
124
124
1. PRs that include bug fixes must be accompanied by a step-by-step description of how to reproduce the bug.
@@ -131,7 +131,7 @@ Review the following supported and accepted pull request rules. We defined these
131
131
132
132
## Forks and pull requests
133
133
134
-
For complete information about contributing to Magento projects, see the [Beginner Guides](https://github.com/magento/magento2/wiki/Getting-Started) on the Magento 2 repository. These guides help you:
134
+
For complete information about contributing to Magento Open Source projects, see the [Beginner Guides](https://github.com/magento/magento2/wiki/Getting-Started) on the Magento 2 repository. These guides help you:
135
135
136
136
- Select an issue to work on and self-assign
137
137
- Fork a repository
@@ -402,7 +402,7 @@ Stating preconditions is very important. Provide information on:
402
402
403
403
Example:
404
404
405
-
1. Magento CE 2.0.0 without sample data is installed.
405
+
1. Magento Open Source 2.0.0 without sample data is installed.
406
406
1. PayPal payment method is set up.
407
407
1. Test category is set up.
408
408
1. Virtual Product is created and assigned to the Test Category.
Copy file name to clipboardExpand all lines: src/guides/v2.3/ext-best-practices/phpstorm/built-in-upgrade-compatibility-tool.md
+8-16Lines changed: 8 additions & 16 deletions
Original file line number
Diff line number
Diff line change
@@ -6,22 +6,11 @@ functional_areas:
6
6
---
7
7
8
8
The built-in Upgrade Compatibility Tool aims to achieve the same issues coverage as original Adobe Commerce [Upgrade Compatibility Tool]({{site.baseurl}}/upgrade-compatibility-tool/introduction.html).
9
-
There are issues that covered by this MVP version:
10
-
11
-
| Code | Name |
12
-
| ----- | ------ |
13
-
| 1131 | extending from @deprecated class |
14
-
| 1132 | importing @deprecated class |
15
-
| 1332 | importing @deprecated interface |
16
-
| 1134 | using @deprecated class |
17
-
| 1334 | using @deprecated interface |
18
-
| 1234 | using @deprecated constant |
19
-
| 1534 | using @deprecated property |
20
-
| 1235 | overriding @deprecated constant |
21
-
| 1535 | overriding @deprecated property |
22
-
| 1337 | inherited from @deprecated interface |
23
-
| 1338 | implemented @deprecated interface |
24
-
| 1439 | call @deprecated method |
9
+
There are three types of inspections covered by this MVP version:
10
+
11
+
* Deprecation (severity level: WARNING)
12
+
* API coverage (severity level: ERROR)
13
+
* Existence (severity level: CRITICAL)
25
14
26
15
A complete list of inspections that are already available in the original tool, can be found by the [following link]({{site.baseurl}}/upgrade-compatibility-tool/errors.html).
27
16
@@ -41,6 +30,9 @@ It allows you to see the problematic code just in real time, without running it
41
30
**The result of the real time inspection is most suitable for use during development, to be always compatible with future versions**:
The second IntelliJ IDEA tool that we can use for running UCT inspections is called **Inspect Code**. It is available under menu item
46
38
`Code -> Inspect Code`. Also, you can open a context menu under the target directory that allows IntelliJ IDEA to populate the path to analyse for you automatically:
Copy file name to clipboardExpand all lines: src/guides/v2.3/frontend-dev-guide/layouts/layout-override.md
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -7,7 +7,7 @@ functional_areas:
7
7
8
8
## What's in this topic {#fedg_layout_override_overview}
9
9
10
-
Not all layout customizations can be performed by [extending layouts]. If the amount of customizations is large, you can use the overriding function for the needed layout file. This means that the new file that you place in the theme will be used instead of the parent [theme] layout file of[base] layout file.
10
+
Not all layout customizations can be performed by [extending layouts]. If the amount of customizations is large, you can use the overriding function for the needed layout file. This means that the new file that you place in the theme will be used instead of the parent [theme] layout file or[base] layout file.
11
11
12
12
In this article, [page layouts], [page configurations], and [generic layouts] are referred to as *layout files*, as the mechanism of overriding is similar for all of them.
0 commit comments