Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Commit 7552989

Browse files
authored
Merge branch 'master' into hg-cloudfixes
2 parents 3402641 + 5a738c2 commit 7552989

File tree

15 files changed

+27
-41
lines changed

15 files changed

+27
-41
lines changed

src/_data/toc/live-search.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@ pages:
44
url: /live-search/overview.html
55
versionless: true
66

7-
- label: Install Live Search
8-
url: /live-search/install.html
9-
versionless: true
10-
117
- label: Storefront Popover
128
url: /live-search/storefront-popover.html
139
versionless: true
@@ -45,7 +41,3 @@ pages:
4541
- label: Events
4642
url: /live-search/events.html
4743
versionless: true
48-
49-
- label: Release Notes
50-
url: /live-search/release-notes.html
51-
versionless: true

src/_data/toc/page-builder.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ pages:
9090
url: /page-builder/docs/content-types/create/add-icon.html
9191
versionless: true
9292

93-
- label: Workflow tips
94-
url: /page-builder/docs/content-types/create/Troubleshooting.html
93+
- label: Troubleshooting
94+
url: /page-builder/docs/content-types/create/troubleshooting.html
9595
versionless: true
9696

9797
- label: 'Customize'
Loading
Loading
Loading
Loading

src/contributor-guide/contributing.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ The Community Engineering Team reviews all issues and contributions submitted by
2020
When the Community Engineering Team works on reviewing the suggested changes, we will add a label to the issue to indicate certain information, like the status or who is working the issue. See [Labels](#labels) to learn more.
2121

2222
{:.bs-callout-tip}
23-
Refer to [Magento Contributor Agreement](http://www.magento.com/legaldocuments/mca) for detailed information about the License Agreement. All contributors are required to submit a click-through form to agree to the terms.
23+
Refer to the [Adobe Contributor Agreement](https://opensource.adobe.com/cla.html) for detailed information about the License Agreement. All contributors are required to submit a click-through form to agree to the terms.
2424

2525
## Community Backlog Priority {#backlog}
2626

@@ -97,13 +97,13 @@ It helps maintainers decide:
9797

9898
## GitHub and two-factor authentication {#two-factor}
9999

100-
Magento **requires all Partners** who contribute code to enable 2FA on their GitHub accounts. You can use a mobile device or 2FA application for added protection. See [Configuring two-factor authentication](https://help.github.com/en/articles/configuring-two-factor-authentication) in the GitHub help.
100+
Adobe **requires all Partners** who contribute code to enable 2FA on their GitHub accounts. You can use a mobile device or 2FA application for added protection. See [Configuring two-factor authentication](https://help.github.com/en/articles/configuring-two-factor-authentication) in the GitHub help.
101101

102102
We also recommend creating a personal access token for your account to use when interacting with GitHub in scripts and on the command line. See [Creating a personal access token for the command line](https://help.github.com/en/articles/creating-a-personal-access-token-for-the-command-line) in the GitHub help.
103103

104104
## Questions or enhancement requests? {#question}
105105

106-
We capture code-related issues in the [Magento 2 repo](https://github.com/magento/magento2) and documentation-related issues in the [Magento DevDocs repo](https://github.com/magento/devdocs). If you have questions about Magento functionality or processes, we recommend posting them to a question-and-answer site, such as [Stack Exchange](https://magento.stackexchange.com/) and the [Magento Forums](https://community.magento.com/), where Magento community members can quickly provide recommendations and advice.
106+
We capture code-related issues in the [Magento 2 repo](https://github.com/magento/magento2) and documentation-related issues in the [DevDocs repo](https://github.com/magento/devdocs). If you have questions about Magento functionality or processes, we recommend posting them to a question-and-answer site, such as [Stack Exchange](https://magento.stackexchange.com/) and the [Magento Forums](https://community.magento.com/), where Magento community members can quickly provide recommendations and advice.
107107

108108
Submit feature requests or enhancement suggestions to the [Magento 2 Feature Requests and Improvements forum](https://community.magento.com/t5/Magento-2-Feature-Requests-and/idb-p/feature-requests). For details about how requests are managed, see [Improvements to GitHub Management](https://community.magento.com/t5/News-Announcements/Improvements-to-GitHub-Management/m-p/44572#M96).
109109

@@ -117,8 +117,8 @@ Review the following supported and accepted pull request rules. We defined these
117117

118118
## Contribution requirements {#requirements}
119119

120-
1. Contributions must adhere to [Magento coding standards]({{ site.gdeurl }}/coding-standards/bk-coding-standards.html).
121-
1. Refer to the Magento development team's [Definition of Done]({{ site.baseurl }}/contributor-guide/contributing_dod.html). We use these guidelines internally to ensure that we deliver well-tested, well-documented, and solid code. We encourage you to use this as well!
120+
1. Contributions must adhere to the [coding standards]({{ site.gdeurl }}/coding-standards/bk-coding-standards.html).
121+
1. Refer to the [Definition of Done]({{ site.baseurl }}/contributor-guide/contributing_dod.html). We use these guidelines internally to ensure that we deliver well-tested, well-documented, and solid code. We encourage you to use this as well!
122122
1. Pull requests (PRs) must be accompanied by a meaningful description of their purpose. Comprehensive descriptions increase the chances that a pull request is merged quickly and without additional clarification requests.
123123
1. Commits must be accompanied by meaningful commit messages.
124124
1. PRs that include bug fixes must be accompanied by a step-by-step description of how to reproduce the bug.
@@ -131,7 +131,7 @@ Review the following supported and accepted pull request rules. We defined these
131131

132132
## Forks and pull requests
133133

134-
For complete information about contributing to Magento projects, see the [Beginner Guides](https://github.com/magento/magento2/wiki/Getting-Started) on the Magento 2 repository. These guides help you:
134+
For complete information about contributing to Magento Open Source projects, see the [Beginner Guides](https://github.com/magento/magento2/wiki/Getting-Started) on the Magento 2 repository. These guides help you:
135135

136136
- Select an issue to work on and self-assign
137137
- Fork a repository
@@ -402,7 +402,7 @@ Stating preconditions is very important. Provide information on:
402402

403403
Example:
404404

405-
1. Magento CE 2.0.0 without sample data is installed.
405+
1. Magento Open Source 2.0.0 without sample data is installed.
406406
1. PayPal payment method is set up.
407407
1. Test category is set up.
408408
1. Virtual Product is created and assigned to the Test Category.

src/guides/v2.3/ext-best-practices/phpstorm/built-in-upgrade-compatibility-tool.md

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,11 @@ functional_areas:
66
---
77

88
The built-in Upgrade Compatibility Tool aims to achieve the same issues coverage as original Adobe Commerce [Upgrade Compatibility Tool]({{site.baseurl}}/upgrade-compatibility-tool/introduction.html).
9-
There are issues that covered by this MVP version:
10-
11-
| Code | Name |
12-
| ----- | ------ |
13-
| 1131 | extending from @deprecated class |
14-
| 1132 | importing @deprecated class |
15-
| 1332 | importing @deprecated interface |
16-
| 1134 | using @deprecated class |
17-
| 1334 | using @deprecated interface |
18-
| 1234 | using @deprecated constant |
19-
| 1534 | using @deprecated property |
20-
| 1235 | overriding @deprecated constant |
21-
| 1535 | overriding @deprecated property |
22-
| 1337 | inherited from @deprecated interface |
23-
| 1338 | implemented @deprecated interface |
24-
| 1439 | call @deprecated method |
9+
There are three types of inspections covered by this MVP version:
10+
11+
* Deprecation (severity level: WARNING)
12+
* API coverage (severity level: ERROR)
13+
* Existence (severity level: CRITICAL)
2514

2615
A complete list of inspections that are already available in the original tool, can be found by the [following link]({{site.baseurl}}/upgrade-compatibility-tool/errors.html).
2716

@@ -41,6 +30,9 @@ It allows you to see the problematic code just in real time, without running it
4130
**The result of the real time inspection is most suitable for use during development, to be always compatible with future versions**:
4231

4332
![]({{site.baseurl}}/common/images/phpstorm/built-in-uct/uct-inspections-highlighting.png)
33+
![]({{site.baseurl}}/common/images/phpstorm/built-in-uct/uct-inspections-highlighting-2.png)
34+
![]({{site.baseurl}}/common/images/phpstorm/built-in-uct/uct-inspections-highlighting-3.png)
35+
![]({{site.baseurl}}/common/images/phpstorm/built-in-uct/uct-inspections-highlighting-4.png)
4436

4537
The second IntelliJ IDEA tool that we can use for running UCT inspections is called **Inspect Code**. It is available under menu item
4638
`Code -> Inspect Code`. Also, you can open a context menu under the target directory that allows IntelliJ IDEA to populate the path to analyse for you automatically:

src/guides/v2.3/frontend-dev-guide/layouts/layout-override.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ functional_areas:
77

88
## What's in this topic {#fedg_layout_override_overview}
99

10-
Not all layout customizations can be performed by [extending layouts]. If the amount of customizations is large, you can use the overriding function for the needed layout file. This means that the new file that you place in the theme will be used instead of the parent [theme] layout file of [base] layout file.
10+
Not all layout customizations can be performed by [extending layouts]. If the amount of customizations is large, you can use the overriding function for the needed layout file. This means that the new file that you place in the theme will be used instead of the parent [theme] layout file or [base] layout file.
1111

1212
In this article, [page layouts], [page configurations], and [generic layouts] are referred to as *layout files*, as the mechanism of overriding is similar for all of them.
1313

src/guides/v2.4/extension-dev-guide/routing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ define the `match()` function in this class to use your own route matching logic
7171

7272
If you need route configuration data, use the Route [`Config`] class.
7373

74-
To add your custom router to the list of routers for the `FrontController`, add the following entry in your module's `di.xml` file:
74+
To add your custom router to the list of routers for the `FrontController`, add the following entry in your module's `frontend/di.xml` file:
7575

7676
```xml
7777
<type name="Magento\Framework\App\RouterList">

0 commit comments

Comments
 (0)