Merge pull request #2631 from loginesta/AC-1509

AC-1509: Remove outdated JSCS static from magento

Author: danidelcar

src/common/images/static-jscs.png

@@ -14,15 +14,14 @@ Use [RFC 2119](http://www.ietf.org/rfc/rfc2119.txt) to interpret the "must," "mu
 Magento uses the [jQuery library][jquery] including standard and custom [jQuery widgets][jquery-widgets].
 For the jQuery widget coding standard, see [jQuery widget coding standard][jquery-widget-coding-standard].
 
-## Eslint and JSCS tools
+## Eslint code analysis
 
-Use [ESLint][eslint] and `JSCS` to ensure the quality of your JavaScript code.
+Use [ESLint][eslint] to ensure the quality of your JavaScript code.
 
 ESLint is a community-driven tool that detects errors and potential problems in JavaScript code.
 It can use custom rules to enforce specific coding standards.
 
 *  [Magento ESLint Rules][eslint-rules]
-*  [Magento JSCS Rules][jscs-rules]
 
 ## Additional formatting standards
 
@@ -360,4 +359,3 @@ var foo = 'bar',
 [jquery-widget-coding-standard]: {{ page.baseurl }}/coding-standards/code-standard-jquery-widgets.html
 [eslint]: http://eslint.org/
 [eslint-rules]: https://github.com/magento/magento-coding-standard/blob/develop/eslint/.eslintrc-magento
-[jscs-rules]: https://github.com/magento/magento-coding-standard/blob/develop/jscs/.jscsrc

src/guides/v2.3/coding-standards/code-standard-javascript.md

@@ -19,29 +19,20 @@ For all of the static configuration installations below involving the PHPStorm P
 
 ## Javascript Code Style check
 
-{:.bs-callout-info}
-JSCS is deprecated in PHPStorm 2020.2. You must install the JSCS plugin.
-
-{:.procedure}
-To install the JSCS plugin:
-
-1. Go to PHPStorm preferences > Languages & Frameworks > JavaScript > Code Quality Tools > JSCS.
-1. Check **Enable**, if it is unchecked.
-1. Enter the path to your node binary (the result of outputting `which node` in your terminal).
-1. Enter the path to your JSCS package: `[magento_root]/node_modules/jscs`
-1. Click **Configuration File** and in the adjacent input field enter the path to the JSCS file Magento uses, which is located in: `https://github.com/magento/magento-coding-standard/blob/develop/jscs/.jscsrc`
+{:.bs-callout-warning}
+[JSCS package has been deprecated](https://www.npmjs.com/package/jscs) and [merged with ESLint](https://eslint.org/blog/2016/04/welcoming-jscs-to-eslint).
 
-![JSCS config]({{site.baseurl}}/common/images/static-jscs.png)
+### ESLint
 
-To verify it works, in any JS file add `snake_case: [],` to any object literal, and you should see a warning about not using camel case for the object key.
-
-## ESLint
+{:.bs-callout-info}
+Javascript code analysis is done through [ESLint]({{site.baseurl}}/guides/v2.4/coding-standards/code-standard-javascript.html#eslint-code-analysis).
+The ESLint rules are set up in `magento-coding-standard`, which is installed on Magento2 via `composer` since it's a development dependency.
 
 1. Go to PHPStorm preferences > Languages & Frameworks > JavaScript > Code Quality Tools > ESLint.
 1. Click **Manual ESLint configuration**.
 1. Fill in the adjacent input fields with the path to your node binary (the result of outputting `which node` in your terminal).
 1. Enter the path to your ESLint package: `[magento_root]/node_modules/eslint`
-1. Click **Configuration File** and in the adjacent input field enter the path to the ESLint file Magento uses, which is located in `dev/tests/static/testsuite/Magento/Test/Js/_files/eslint/.eslintrc-magento`.
+1. Click **Configuration File** and in the adjacent input field enter the path to the ESLint file Magento uses, which is located in `vendor/magento/magento-coding-standard/eslint/.eslintrc-magento`.
 
 See the image below for example configuration:
 

src/guides/v2.3/test/static/static-analysis.md

@@ -14,15 +14,14 @@ Use [RFC 2119](http://www.ietf.org/rfc/rfc2119.txt) to interpret the "must," "mu
 Magento uses the [jQuery library][jquery] including standard and custom [jQuery widgets][jquery-widgets].
 For the jQuery widget coding standard, see [jQuery widget coding standard][jquery-widget-coding-standard].
 
-## Eslint and JSCS tools
+## Eslint code analysis
 
-Use [ESLint][eslint] and `JSCS` to ensure the quality of your JavaScript code.
+Use [ESLint][eslint] to ensure the quality of your JavaScript code.
 
 ESLint is a community-driven tool that detects errors and potential problems in JavaScript code.
 It can use custom rules to enforce specific coding standards.
 
 *  [Magento ESLint Rules][eslint-rules]
-*  [Magento JSCS Rules][jscs-rules]
 
 ## Additional formatting standards
 
@@ -368,6 +367,5 @@ The source code of the rules can be found in the [Eslint custom rules folder][es
 [jquery-widget-coding-standard]: {{ page.baseurl }}/coding-standards/code-standard-jquery-widgets.html
 [eslint]: http://eslint.org/
 [eslint-rules]: https://github.com/magento/magento-coding-standard/blob/develop/eslint/.eslintrc-magento
-[jscs-rules]: https://github.com/magento/magento-coding-standard/blob/develop/jscs/.jscsrc
 [grunt-eslint-configuration]: {{ site.mage2bloburl }}/{{ page.guide_version }}/dev/tools/grunt/configs/eslint.json
 [eslint-custom-rules-folder]: {{ site.mage2bloburl }}/{{ page.guide_version }}/dev/tests/static/testsuite/Magento/Test/Js/_files/eslint/rules/