Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Commit 30b2b15

Browse files
authored
Merge pull request #2716 from magento-commerce/1-5_integration
1 5 integration
2 parents 2543088 + 1375a49 commit 30b2b15

File tree

5 files changed

+8
-9
lines changed

5 files changed

+8
-9
lines changed

src/guides/v2.3/extension-dev-guide/admin-grid.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -416,9 +416,9 @@ The resource model class translates to `app/code/Dev/Grid/Model/ResourceModel/Ca
416416

417417
namespace Dev\Grid\Model\ResourceModel;
418418

419-
use Magento\Catalog\Model\ResourceModel\Category;
419+
use Magento\Catalog\Model\ResourceModel\Category as BaseCategory;
420420

421-
class Category extends Category
421+
class Category extends BaseCategory
422422
{
423423
}
424424
```

src/guides/v2.3/howdoi/checkout/checkout_form.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ It should be similar to the following:
128128
<item name="custom-checkout-form-container" xsi:type="array">
129129
<!-- Add this item to configure your js file -->
130130
<item name="component" xsi:type="string">VendorName_ModuleName/js/view/custom-checkout-form</item>
131+
<item name="provider" xsi:type="string">checkoutProvider</item>
131132
<item name="config" xsi:type="array">
132133
<!-- And this to add your html template -->
133134
<item name="template" xsi:type="string">VendorName_ModuleName/custom-checkout-form</item>
@@ -265,7 +266,7 @@ The following code sample shows the configuration of the `custom-checkout-form-c
265266
Dynamically defined, or dynamic, forms are the forms where the set or type of fields can change. For example, the fields displayed on the checkout form depend on the Admin settings: depending on the **Admin > Stores > Settings > Configuration > Customers > Customer Configuration > Name and Address Options**.
266267

267268
For such forms, you must implement a [plugin]({{ page.baseurl }}/extension-dev-guide/plugins.html) for the `\Magento\Checkout\Block\Checkout\LayoutProcessor::process` method.
268-
A plugin can add custom fields definitions to layout at run-time. The format of the field definition is the same as for fields defined in layout.
269+
A plugin can add custom fields definitions to layout at runtime. The format of the field definition is the same as for fields defined in layout.
269270

270271
For example:
271272

src/guides/v2.3/howdoi/custom-attributes/text-field.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ There are five steps in developing a data patch. All the steps below are written
155155
```php
156156
// Get the newly created attribute's model
157157
$attribute = $this->customerSetup->getEavConfig()
158-
->getAttribute(CustomerMetadataInterface::ENTITY, 'externalcorp_external_id');
158+
->getAttribute(CustomerMetadataInterface::ENTITY_TYPE_CUSTOMER, 'externalcorp_external_id');
159159

160160
// Make attribute visible in Admin customer form
161161
$attribute->setData('used_in_forms', [
@@ -214,7 +214,6 @@ namespace ExampleCorp\Customer\Setup\Patch\Data;
214214
use Exception;
215215
use Psr\Log\LoggerInterface;
216216
use Magento\Customer\Api\CustomerMetadataInterface;
217-
use Magento\Customer\Model\Customer;
218217
use Magento\Customer\Model\ResourceModel\Attribute as AttributeResource;
219218
use Magento\Customer\Setup\CustomerSetup;
220219
use Magento\Customer\Setup\CustomerSetupFactory;
@@ -329,7 +328,7 @@ class ExternalId implements DataPatchInterface
329328

330329
// Get the newly created attribute's model
331330
$attribute = $this->customerSetup->getEavConfig()
332-
->getAttribute(Customer::ENTITY, 'externalcorp_external_id');
331+
->getAttribute(CustomerMetadataInterface::ENTITY_TYPE_CUSTOMER, 'externalcorp_external_id');
333332

334333
// Make attribute visible in Admin customer form
335334
$attribute->setData('used_in_forms', [

src/guides/v2.3/ui_comp_guide/components/ui-datecolumn.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ This is an example of how the DateColumn component integrates with the [Listing]
3333
<settings>
3434
<filter>dateRange</filter>
3535
<dataType>date</dataType>
36-
<dataType>date</dataType>
3736
<label translate="true">Date Column Example 1</label>
3837
</settings>
3938
</column>

src/guides/v2.4/security/two-factor-authentication.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ Two-Factor Authentication is implemented for Magento Web APIs with the following
6767

6868
## Magento Functional Testing Framework
6969

70-
MFTF uses Google Authenticator to execute tests with 2FA enabled. The following steps summarize how to configure MFTF with an encoded shared secret. For more information, see [Configuring MFTF for Two-Factor Authentication (2FA)]({{ page.baseurl }}/security/two-factor-authentication.html#magento-functional-testing-framework).
70+
MFTF uses Google Authenticator to execute tests with 2FA enabled. The following steps summarize how to configure MFTF with an encoded shared secret.
7171

7272
1. Select Google Authenticator as the 2FA provider:
7373

@@ -95,7 +95,7 @@ MFTF uses Google Authenticator to execute tests with 2FA enabled. The following
9595

9696
## Troubleshooting
9797

98-
The extension supports command line options to revoke and reset authenticators. Use these commands when you cannot access the Magento _Admin_.
98+
The extension supports command-line options to revoke and reset authenticators. Use these commands when you cannot access the Magento _Admin_.
9999

100100
### List all available 2FA providers
101101

0 commit comments

Comments
 (0)