Skip to content

show stopper - don't add more errors after certain things happen #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Schrank opened this issue Oct 31, 2019 · 1 comment · May be fixed by #23
Open

show stopper - don't add more errors after certain things happen #22

Schrank opened this issue Oct 31, 2019 · 1 comment · May be fixed by #23
Assignees
@Schrank
Labels
enhancement

Comments

@Schrank
Copy link
Member

Schrank commented Oct 31, 2019

define killing conditions which don’t need more explanation.

  • coupon inactive
  • wrong customer group
  • net valid anymore
  • not valid yet

@lfolco my customer wants to have a list of show stopper, which don't need more explanation. What do you think about them? I would add them to the repo, open a PR - if you like it we'll merge it, if not we don't.
If you don't find time to express your opinion (which is fine) then I'll decide ;-)
@Schrank Schrank self-assigned this Oct 31, 2019
@lfolco
Copy link
Contributor

lfolco commented Oct 31, 2019

This would be really nice actually, since sometimes we don't want to provide quite so much information necessarily.

@Schrank Schrank linked a pull request Nov 14, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Schrank Schrank

Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@Schrank @lfolco