Merge pull request #11 from LS-Myron/main

Updated code, updated class Request and added RequestInterface

Author: ryansunxl

Api/RequestInterface.php

@@ -0,0 +1,19 @@
+<?php
+declare(strict_types=1);
+
+namespace MageOS\CatalogDataAI\Api;
+
+interface RequestInterface
+{
+    /**
+     * Retrieve products id.
+     * @return int
+     */
+    public function getId(): int;
+
+    /**
+     * Retrieve overwrite flag.
+     * @return bool
+     */
+    public function getOverwrite(): bool;
+}

Controller/Adminhtml/Product/MassEnrich.php

@@ -7,6 +7,7 @@
 use Magento\Backend\Model\View\Result\Redirect;
 use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\Backend\App\Action;
+use Magento\Catalog\Model\Product;
 use Magento\Catalog\Model\ResourceModel\Product\CollectionFactory;
 use Magento\Framework\App\Action\HttpPostActionInterface as HttpPostActionInterface;
 use Magento\Framework\Controller\ResultFactory;
@@ -41,7 +42,7 @@ public function execute(): Redirect
 
         $productEnriched = 0;
         if($this->config->isEnabled()) {
-            /** @var \Magento\Catalog\Model\Product $product */
+            /** @var Product $product */
             foreach ($collection->getItems() as $product) {
                 //@TODO: we hit rate limit, change to batching the request
                 $this->publisher->execute($product->getId(), $this->overwrite);

Model/Config.php

@@ -1,9 +1,10 @@
 <?php
 declare(strict_types=1);
+
 namespace MageOS\CatalogDataAI\Model;
 
 use Magento\Framework\App\Config\ScopeConfigInterface;
-USE Magento\Catalog\Model\Product;
+use Magento\Catalog\Model\Product;
 
 class Config
 {
@@ -19,8 +20,7 @@ class Config
 
     public function __construct(
         private readonly ScopeConfigInterface $scopeConfig
-    ) {
-    }
+    ) {}
 
     public function isEnabled(): bool
     {

Model/Product/Enricher.php

@@ -13,8 +13,7 @@
 class Enricher
 {
     private Client $client;
-    public function __construct
-    (
+    public function __construct(
         private readonly Factory $clientFactory,
         private readonly Config $config
     ) {

Model/Product/Publisher.php

@@ -16,8 +16,7 @@ class Publisher
     public function __construct(
         private readonly PublisherInterface $publisher,
         private readonly RequestFactory     $requestFactory,
-    ) {
-    }
+    ) {}
 
     /**
      * @param int|string $productId

Model/Product/Request.php

@@ -3,10 +3,12 @@
 
 namespace MageOS\CatalogDataAI\Model\Product;
 
+use MageOS\CatalogDataAI\Api\RequestInterface;
+
 /**
  * Data model for enrichment message queue.
  */
-class Request
+class Request implements RequestInterface
 {
     public function __construct(
         private readonly int $id,
@@ -15,15 +17,15 @@ public function __construct(
     }
 
     /**
-     * Retrieve products id.
+     * @inheritDoc
      */
     public function getId(): int
     {
         return $this->id;
     }
 
     /**
-     * Retrieve overwrite flag.
+     * @inheritDoc
      */
     public function getOverwrite(): bool
     {

Observer/Product/SaveBefore.php

@@ -24,6 +24,5 @@ public function execute(Observer $observer): void
         if($this->config->canEnrich($product) && !$this->config->isAsync()) {
             $this->enricher->execute($product);
         }
-
     }
 }

etc/config.xml

@@ -11,7 +11,7 @@
                 <description>write a detailed product description for {{name}} with features in bullet list, under 1000 words</description>
             </product>
             <advanced>
-                <system_prompt>You are a helpful assistant.</system_prompt>
+                <system_prompt>Be a content generator, just reply with the content, skip all introductions.</system_prompt>
                 <temperature>0</temperature>
                 <frequency_penalty>0</frequency_penalty>
                 <presence_penalty>0</presence_penalty>