Skip to content
This repository was archived by the owner on Dec 21, 2024. It is now read-only.

Commit 811b238

Browse files
committed
Conflicts: src/jsonlogger.py
2 parents be78dfa + 21538d3 commit 811b238

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,14 @@
88

99
setup(
1010
name = "python-json-logger",
11-
version = "0.0.2",
11+
version = "0.0.5",
1212
url = "http://github.com/madzak/python-json-logger",
1313
license = "BSD",
1414
description = "A python library adding a json log formatter",
1515
author = "Zakaria Zajac",
1616
author_email = "zak@madzak.com",
1717
package_dir = {'': 'src'},
1818
packages = [''],
19-
# use_2to3 = True,
2019
test_suite = "tests.tests",
2120
install_requires = ['setuptools'],
2221
classifiers = [

src/jsonlogger.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def merge_record_extra(record, target, reserved=RESERVED_ATTR_HASH):
3131
:param target: dict to update
3232
:param reserved: dict or list with reserved keys to skip
3333
"""
34-
for key, value in record.__dict__.iteritems():
34+
for key, value in record.__dict__.items():
3535
#this allows to have numeric keys
3636
if (key not in reserved
3737
and not (hasattr(key,"startswith") and key.startswith('_'))
@@ -98,10 +98,11 @@ def format(self, record):
9898
log_record = {}
9999

100100
for field in self._required_fields:
101-
log_record[field] = record.__dict__[field]
101+
log_record[field] = record.__dict__.get(field)
102102
log_record.update(extras)
103103
merge_record_extra(record, log_record, reserved=self._skip_fields)
104104

105-
return "%s%s" % (self.prefix, json.dumps(log_record,
106-
default=self.json_default,
107-
cls=self.json_encoder))
105+
return "%s%s" % (self.prefix,
106+
json.dumps(log_record,
107+
default=self.json_default,
108+
cls=self.json_encoder))

tests/tests.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,6 @@ def testFormatKeys(self):
7272

7373
def testUnknownFormatKey(self):
7474
fr = jsonlogger.JsonFormatter('%(unknown_key)s %(message)s')
75-
self.assertRaises(KeyError,
76-
fr.format, logging.makeLogRecord({"msg":"test"}))
7775

7876
self.logHandler.setFormatter(fr)
7977
msg = "testing unknown logging format"

0 commit comments

Comments
 (0)