Merge pull request #480 from madsmtm/more-warnings

Add more warnings to crate root

Author: madsmtm

.github/workflows/ci.yml

@@ -181,6 +181,8 @@ jobs:
         $PUBLIC_CRATES
         --features=$INTERESTING_FEATURES
         --features=$LATEST_MACOS_FEATURE
+      env:
+        RUSTFLAGS: "--codegen=debuginfo=0" # Removed --deny=warnings
 
   ui:
     name: Compiler UI

crates/block-sys/src/lib.rs

@@ -14,11 +14,14 @@
 
 #![no_std]
 #![warn(elided_lifetimes_in_paths)]
+#![warn(missing_copy_implementations)]
 #![deny(non_ascii_idents)]
 #![warn(unreachable_pub)]
 #![deny(unsafe_op_in_unsafe_fn)]
 #![warn(clippy::cargo)]
 #![warn(clippy::ptr_as_ptr)]
+#![warn(clippy::missing_errors_doc)]
+#![warn(clippy::missing_panics_doc)]
 // Update in Cargo.toml as well.
 #![doc(html_root_url = "https://docs.rs/block-sys/0.2.0")]
 #![cfg_attr(feature = "unstable-docsrs", feature(doc_auto_cfg, doc_cfg_hide))]
@@ -291,6 +294,7 @@ pub struct Block_layout {
 }
 
 #[repr(C)]
+#[allow(missing_copy_implementations)]
 pub struct Block_descriptor_header {
     /// Reserved for future use. Currently always 0.
     pub reserved: c_ulong, // usize

crates/block2/src/block.rs

@@ -116,7 +116,7 @@ impl<A: BlockArguments, R: EncodeReturn> Block<A, R> {
         let ptr: *const Self = self;
         let layout = unsafe { ptr.cast::<ffi::Block_layout>().as_ref().unwrap_unchecked() };
         // TODO: Is `invoke` actually ever null?
-        let invoke = layout.invoke.unwrap();
+        let invoke = layout.invoke.unwrap_or_else(|| unreachable!());
 
         unsafe { A::__call_block(invoke, ptr as *mut Self, args) }
     }

crates/block2/src/lib.rs

@@ -76,12 +76,16 @@
 
 #![no_std]
 #![warn(elided_lifetimes_in_paths)]
+#![warn(missing_copy_implementations)]
+#![warn(missing_debug_implementations)]
 #![warn(missing_docs)]
 #![deny(non_ascii_idents)]
 #![warn(unreachable_pub)]
 #![deny(unsafe_op_in_unsafe_fn)]
 #![warn(clippy::cargo)]
 #![warn(clippy::ptr_as_ptr)]
+#![warn(clippy::missing_errors_doc)]
+#![warn(clippy::missing_panics_doc)]
 // Update in Cargo.toml as well.
 #![doc(html_root_url = "https://docs.rs/block2/0.3.0")]
 

crates/icrate/src/Foundation/__macro_helpers/cached.rs

@@ -6,6 +6,7 @@ use objc2::rc::Id;
 use objc2::Message;
 
 /// Allows storing an `Id` in a static and lazily loading it.
+#[derive(Debug)]
 pub struct CachedId<T> {
     ptr: AtomicPtr<T>,
 }

crates/icrate/src/Foundation/__macro_helpers/ns_string.rs

@@ -1,4 +1,5 @@
 #![cfg(feature = "Foundation_NSString")]
+#![allow(missing_copy_implementations)]
 //! Macro for making a static NSString.
 //!
 //! This closely follows what clang does, see:
@@ -37,6 +38,7 @@ extern "C" {
 /// [`CFRuntimeBase`]: <https://github.com/apple-oss-distributions/CF/blob/CF-1153.18/CFRuntime.h#L216-L228>
 /// [`CF_CONST_STRING`]: <https://github.com/apple-oss-distributions/CF/blob/CF-1153.18/CFInternal.h#L332-L336>
 #[repr(C)]
+#[derive(Debug)]
 pub struct CFConstString {
     isa: &'static AnyClass,
     // Important that we don't use `usize` here, since that would be wrong on
@@ -118,6 +120,7 @@ pub const fn is_ascii_no_nul(bytes: &[u8]) -> bool {
     true
 }
 
+#[derive(Debug)]
 pub struct Utf16Char {
     pub repr: [u16; 2],
     pub len: usize,
@@ -147,6 +150,7 @@ impl Utf16Char {
     }
 }
 
+#[derive(Debug)]
 pub struct EncodeUtf16Iter {
     str: &'static [u8],
     index: usize,

crates/icrate/src/lib.rs

@@ -7,6 +7,8 @@
 #![no_std]
 #![cfg_attr(feature = "unstable-docsrs", feature(doc_auto_cfg))]
 #![warn(elided_lifetimes_in_paths)]
+#![warn(missing_copy_implementations)]
+#![warn(missing_debug_implementations)]
 #![deny(non_ascii_idents)]
 #![warn(unreachable_pub)]
 #![deny(unsafe_op_in_unsafe_fn)]

crates/objc-sys/src/image_info.rs

@@ -5,6 +5,7 @@
 /// only used behind experimental features (`unstable-static-*`).
 #[repr(C)]
 #[doc(hidden)]
+#[allow(missing_copy_implementations)]
 pub struct __ImageInfo {
     // These are not actually `unsigned int`, even though the docs say so
     /// The version of the image info struct.

crates/objc-sys/src/lib.rs

@@ -15,11 +15,14 @@
 
 #![no_std]
 #![warn(elided_lifetimes_in_paths)]
+#![warn(missing_copy_implementations)]
 #![deny(non_ascii_idents)]
 #![warn(unreachable_pub)]
 #![deny(unsafe_op_in_unsafe_fn)]
 #![warn(clippy::cargo)]
 #![warn(clippy::ptr_as_ptr)]
+#![warn(clippy::missing_errors_doc)]
+#![warn(clippy::missing_panics_doc)]
 #![allow(clippy::upper_case_acronyms)]
 #![allow(non_camel_case_types)]
 #![allow(non_upper_case_globals)]

crates/objc2-encode/src/encoding.rs

@@ -34,7 +34,8 @@ use crate::EncodingBox;
 /// use objc2_encode::Encoding;
 /// assert!(Encoding::Array(10, &Encoding::FloatComplex).equivalent_to_str("[10jf]"));
 /// ```
-// Not `Copy`, since this may one day contain `Box`
+// Not `Copy`, since this may one day be merged with `EncodingBox`
+#[allow(missing_copy_implementations)]
 #[derive(Clone, Debug, PartialEq, Eq, Hash)]
 // See <https://en.cppreference.com/w/c/language/type>
 #[non_exhaustive] // Maybe we're missing some encodings?