Fix filtering only participating notifications.
#18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual query parameter was missing.
mackdk
reviewed
Nov 18, 2024
Owner
mackdk
left a comment
mackdk
left a comment
There was a problem hiding this comment.
Thanks for your contribution, I never actually noticed the problem 😅 Could you please fix the unit test by changing the references to wrong URL in github-client-scenarios.json? Otherwise, I will do it later today before merging 🙂
Author
|
Sure, I haven't noticed. Fixed in 7019fc3. I don't understand the SonarCloud failure though. |
Owner
Don't worry about that, it's not related to your change. Sonarcloud requires additional setup to run scans on pull requests from an external repository. I haven't looked into the details, but in summary, the token needed for the scan isn't available in your fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual query parameter was missing, see the docs.
Thank you so much for continuing the work in this extension! 🤩 Although seemingly simple, seeing the current notification count at the top of my screen and clicking it to get redirected to the unread notifications is so essential to my workflow. Keep up the good work! It would be so awesome if you could get it published as well, since there is nothing comparable anymore in the registry for recent Gnome versions.