Skip to content

GetStepScaleBasedOnLLHScan doesn't account for GlobalStepScale #516

@KSkwarczynski

Description

@KSkwarczynski

Describe the bug

Currently GetStepScaleBasedOnLLHScan doesn't account for GlobalStepScale, it only accounts for suggested global scale based on rule 2.38/std::sqrt(npars)

see :
https://github.com/mach3-software/MaCh3/blob/1ad9f5931427c6f6a7350b3d75718a10bcd8cce8/Fitters/FitterBase.cpp#L863C49-L863C70

This results in suggested step scale not represetning what we need in analysis very well.

Additional context

Issue has been first noticed by @yash-quark

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions