Skip to content

Commit 94e431a

Browse files
committed
v1.2.1--Reduce sample size,Fix Dart analyse warnings
1 parent 77276fa commit 94e431a

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
* Some improvements
1919
* Fix readme file
2020
* Reduce Sample size
21+
* Fix Dart Analyse warnings
2122

2223

2324
## v1.2.0

example/pubspec.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ packages:
7676
path: ".."
7777
relative: true
7878
source: path
79-
version: "1.1.0"
79+
version: "1.2.1"
8080
flutter_lints:
8181
dependency: "direct dev"
8282
description:

lib/src/controllers/flutter_3d_controller.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
import 'package:flutter/cupertino.dart';
21
import 'package:flutter_3d_controller/src/controllers/i_flutter_3d_controller.dart';
32
import 'package:flutter_3d_controller/src/data/repositories/i_flutter_3d_repository.dart';
43

54

6-
class Flutter3DController extends IFlutter3DController with ChangeNotifier {
5+
class Flutter3DController extends IFlutter3DController{
76

87
IFlutter3DRepository? _repository;
98
Flutter3DController();

lib/src/data/datasources/flutter_3d_datasource_web.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// ignore_for_file: avoid_web_libraries_in_flutter
2+
import 'package:flutter/services.dart';
23
import 'package:flutter_3d_controller/src/data/datasources/i_flutter_3d_datasource.dart';
34
import 'dart:js' as js;
4-
55
import 'package:webview_flutter/webview_flutter.dart';
66

77
class Flutter3DDatasource implements IFlutter3DDatasource{
@@ -73,6 +73,9 @@ class Flutter3DDatasource implements IFlutter3DDatasource{
7373

7474
@override
7575
void setCameraTarget(double x, double y, double z) {
76+
if(_webViewController!=null){
77+
throw PlatformException(code: '130',message: 'Mismatch platform usage');
78+
}
7679
executeCustomJsCode(
7780
"const modelViewer = document.querySelector(\"model-viewer\");"
7881
"modelViewer.cameraTarget = \"${x}m ${y}m ${z}m\";"

test/flutter_3d_controller_test.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
import 'package:flutter_test/flutter_test.dart';
2-
3-
import 'package:flutter_3d_controller/flutter_3d_controller.dart';
4-
52
void main() {
63
test('adds one to input values', () {
74
});

0 commit comments

Comments
 (0)