Skip to content

Commit 0487efd

Browse files
committed
libtest: Use a number value for the key "exec_time" in the JSON output
1 parent 3ca187e commit 0487efd

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

library/test/src/formatters/json.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ impl<T: Write> JsonFormatter<T> {
4747
evt
4848
))?;
4949
if let Some(exec_time) = exec_time {
50-
self.write_message(&*format!(r#", "exec_time": "{}""#, exec_time))?;
50+
self.write_message(&*format!(r#", "exec_time": {}"#, exec_time.0.as_secs_f64()))?;
5151
}
5252
if let Some(stdout) = stdout {
5353
self.write_message(&*format!(r#", "stdout": "{}""#, EscapedString(stdout)))?;
@@ -181,7 +181,7 @@ impl<T: Write> OutputFormatter for JsonFormatter<T> {
181181
))?;
182182

183183
if let Some(ref exec_time) = state.exec_time {
184-
let time_str = format!(", \"exec_time\": \"{}\"", exec_time);
184+
let time_str = format!(", \"exec_time\": {}", exec_time.0.as_secs_f64());
185185
self.write_message(&time_str)?;
186186
}
187187

src/test/run-make-fulldeps/libtest-json/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@ all:
1414
cat $(OUTPUT_FILE_STDOUT_SUCCESS) | "$(PYTHON)" validate_json.py
1515

1616
# Normalize the actual output and compare to expected output file
17-
cat $(OUTPUT_FILE_DEFAULT) | sed -r 's/\"exec_time\": \"[0-9]+\.[0-9]+s\"/\"exec_time\": \"\$$TIME\"/' | diff output-default.json -
18-
cat $(OUTPUT_FILE_STDOUT_SUCCESS) | sed -r 's/\"exec_time\": \"[0-9]+\.[0-9]+s\"/\"exec_time\": \"\$$TIME\"/' | diff output-stdout-success.json -
17+
cat $(OUTPUT_FILE_DEFAULT) | sed -r 's/\"exec_time\": [0-9]+(\.[0-9]+)?/\"exec_time\": \$$TIME/' | diff output-default.json -
18+
cat $(OUTPUT_FILE_STDOUT_SUCCESS) | sed -r 's/\"exec_time\": [0-9]+(\.[0-9]+)?/\"exec_time\": \$$TIME/' | diff output-stdout-success.json -

src/test/run-make-fulldeps/libtest-json/output-default.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@
77
{ "type": "test", "name": "c", "event": "ok" }
88
{ "type": "test", "event": "started", "name": "d" }
99
{ "type": "test", "name": "d", "event": "ignored" }
10-
{ "type": "suite", "event": "failed", "passed": 2, "failed": 1, "allowed_fail": 0, "ignored": 1, "measured": 0, "filtered_out": 0, "exec_time": "$TIME" }
10+
{ "type": "suite", "event": "failed", "passed": 2, "failed": 1, "allowed_fail": 0, "ignored": 1, "measured": 0, "filtered_out": 0, "exec_time": $TIME }

src/test/run-make-fulldeps/libtest-json/output-stdout-success.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@
77
{ "type": "test", "name": "c", "event": "ok", "stdout": "thread 'main' panicked at 'assertion failed: false', f.rs:15:5\n" }
88
{ "type": "test", "event": "started", "name": "d" }
99
{ "type": "test", "name": "d", "event": "ignored" }
10-
{ "type": "suite", "event": "failed", "passed": 2, "failed": 1, "allowed_fail": 0, "ignored": 1, "measured": 0, "filtered_out": 0, "exec_time": "$TIME" }
10+
{ "type": "suite", "event": "failed", "passed": 2, "failed": 1, "allowed_fail": 0, "ignored": 1, "measured": 0, "filtered_out": 0, "exec_time": $TIME }

0 commit comments

Comments
 (0)