Improve selection mechanism on sriov nic

[kamoulox25]

Is there an existing issue for this?

• There is no existing issue for this feature

What are you currently unable to do

Hello,

i raised an issue on the forum earlier: https://discuss.linuxcontainers.org/t/dealing-with-multi-physical-function-on-sriov-enabled-nic/24627

Basically, the way sriov network works on incus is that you assign a parent device to it, the physical function, and it will manage the virtual functions. But on some nic, like the intel x710, you have multiple port aka pf.
Incus doesn't allow to have a sriov network with multiples parents.

What do you think would need to be added

@stgraber proposed a solution to the ferature request:

it’s not, though a feature request to have the sriov nictype support the same selection mechanism as sriov gputype would make sense.

That would then give you:

vendorid
productid
pci

With the valid selectors then being:

vendorid (selecting any NIC with the matching vendor)
vendorid+productid (selecting any NIC with the matching vendor and product)
pci (selecting based on the PCI address of the PF)
parent (selecting based on an existing PF in use on the system)

For GPUs, we then have a bit of logic to try to balance VFs across NICs as well as prioritize the NICs that are on the same NUMA node as the instance.

kind regards