Skip to content

Commit e7cca72

Browse files
committed
optimize
1 parent 9ad412e commit e7cca72

File tree

4 files changed

+5
-29
lines changed

4 files changed

+5
-29
lines changed

spring-boot-data-aggregator-autoconfigure/src/main/java/io/github/lvyahui8/spring/autoconfigure/BeanAggregateAutoConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ public DataBeanAggregateQueryService dataBeanAggregateQueryService (
142142
/**
143143
* 允许用户自定义线程池
144144
*
145-
* @return
145+
* @return 线程池服务
146146
*/
147147
@Bean(name = "aggregateExecutorService")
148148
@ConditionalOnMissingBean(name = "aggregateExecutorService",value=ExecutorService.class)
@@ -158,7 +158,7 @@ public ExecutorService aggregateExecutorService() {
158158
/**
159159
* 允许用户自定义provider存储
160160
*
161-
* @return
161+
* @return provider数据仓库
162162
*/
163163
@Bean(name = "dataProviderRepository")
164164
@ConditionalOnMissingBean(DataProviderRepository.class)

spring-boot-data-aggregator-core/src/main/java/io/github/lvyahui8/spring/aggregate/concurrent/AbstractRunnableWrapper.java

Lines changed: 0 additions & 24 deletions
This file was deleted.

spring-boot-data-aggregator-core/src/main/java/io/github/lvyahui8/spring/aggregate/service/AbstractAsyncQueryTask.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public abstract class AbstractAsyncQueryTask<T> implements Callable<T> {
1616
*/
1717
private AsyncQueryTaskWrapper asyncQueryTaskWrapper;
1818

19-
public AbstractAsyncQueryTask(Thread taskFromThread, AsyncQueryTaskWrapper asyncQueryTaskWrapper) {
19+
protected AbstractAsyncQueryTask(Thread taskFromThread, AsyncQueryTaskWrapper asyncQueryTaskWrapper) {
2020
this.taskFromThread = taskFromThread;
2121
this.asyncQueryTaskWrapper = asyncQueryTaskWrapper;
2222
}

spring-boot-data-aggregator-core/src/main/java/io/github/lvyahui8/spring/aggregate/service/impl/DataBeanAggregateQueryServiceImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public <T> T get(DataProvideDefinition provider, Map<String, Object> invokeParam
7575
private <T> T innerGet(DataProvideDefinition provider, Map<String, Object> invokeParams, Class<T> resultType,
7676
AggregationContext context, DataConsumeDefinition causedConsumer)
7777
throws InterruptedException, InvocationTargetException, IllegalAccessException{
78-
Map<String,Object> dependObjectMap = null;
78+
Map<String,Object> dependObjectMap;
7979
try {
8080
interceptorChain.applyQueryBefore(context,provider);
8181
if(provider.getDepends() != null && ! provider.getDepends().isEmpty()) {
@@ -144,7 +144,7 @@ private Map<String, Object> getDependObjectMap(Map<String, Object> invokeParams,
144144
Map<String,DataConsumeDefinition> consumeDefinitionMap = new HashMap<>(consumeDefinitions.size());
145145
for (DataConsumeDefinition depend : consumeDefinitions) {
146146
consumeDefinitionMap.put(depend.getId(),depend);
147-
AsyncQueryTaskWrapper taskWrapper = null;
147+
AsyncQueryTaskWrapper taskWrapper;
148148
try {
149149
taskWrapper = taskWrapperClazz.newInstance();
150150
} catch (InstantiationException e) {

0 commit comments

Comments
 (0)