匿名provider增加缓存，减少反射操作

Author: lvyahui8

spring-boot-data-aggregator-core/src/main/java/io/github/lvyahui8/spring/aggregate/facade/impl/DataBeanAggregateQueryFacadeImpl.java

@@ -4,12 +4,10 @@
 import io.github.lvyahui8.spring.aggregate.func.MultipleArgumentsFunction;
 import io.github.lvyahui8.spring.aggregate.model.DataProvideDefinition;
 import io.github.lvyahui8.spring.aggregate.service.DataBeanAggregateService;
-import io.github.lvyahui8.spring.aggregate.util.DefinitionUtils;
 import org.springframework.util.Assert;
 
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
-import java.lang.reflect.Modifier;
 import java.util.Collections;
 import java.util.Map;
 
@@ -43,28 +41,12 @@ public <T> T get(Map<String, Object> invokeParams, MultipleArgumentsFunction<T>
 
     @Override
     public <T> T get(Map<String, Object> invokeParams, MultipleArgumentsFunction<T> multipleArgumentsFunction, Long timeout)  throws InterruptedException, IllegalAccessException, InvocationTargetException{
-        Method[] methods = multipleArgumentsFunction.getClass().getMethods();
-        Method applyMethod = null;
         if(invokeParams == null) {
             invokeParams = Collections.emptyMap();
         }
 
-        for (Method method : methods) {
-            if(! Modifier.isStatic(method.getModifiers()) && ! method.isDefault()) {
-                applyMethod = method;
-                break;
-            }
-        }
-
-        if(applyMethod == null) {
-            throw new IllegalAccessException(multipleArgumentsFunction.getClass().getName());
-        }
-
-
-        DataProvideDefinition provider = DefinitionUtils.getProvideDefinition(applyMethod);
-        provider.setTimeout(timeout);
-        provider.setTarget(multipleArgumentsFunction);
-
+        DataProvideDefinition provider = dataBeanAggregateService.getProvider(multipleArgumentsFunction);
+        Method applyMethod = provider.getMethod();
         boolean accessible = applyMethod.isAccessible();
         if(! accessible) {
             applyMethod.setAccessible(true);

spring-boot-data-aggregator-core/src/main/java/io/github/lvyahui8/spring/aggregate/service/DataBeanAggregateService.java

@@ -1,5 +1,6 @@
 package io.github.lvyahui8.spring.aggregate.service;
 
+import io.github.lvyahui8.spring.aggregate.func.MultipleArgumentsFunction;
 import io.github.lvyahui8.spring.aggregate.model.DataProvideDefinition;
 
 import java.lang.reflect.InvocationTargetException;
@@ -42,4 +43,12 @@ <T> T get(String id, Map<String,Object> invokeParams, Class<T> resultType)
     <T> T get(DataProvideDefinition provider, Map<String,Object> invokeParams, Class<T> resultType)
             throws InterruptedException, InvocationTargetException, IllegalAccessException;
 
+    /**
+     * 通过MultipleArgumentsFunction获取provider实例
+     *
+     * @param function 多参函数
+     * @return provider实例
+     * @throws IllegalAccessException ignored
+     */
+    DataProvideDefinition getProvider(MultipleArgumentsFunction<?> function) throws IllegalAccessException;
 }

spring-boot-data-aggregator-core/src/main/java/io/github/lvyahui8/spring/aggregate/service/impl/DataBeanAggregateServiceImpl.java

@@ -3,17 +3,21 @@
 import io.github.lvyahui8.spring.aggregate.config.RuntimeSettings;
 import io.github.lvyahui8.spring.aggregate.consts.AggregationConstant;
 import io.github.lvyahui8.spring.aggregate.context.AggregationContext;
+import io.github.lvyahui8.spring.aggregate.func.MultipleArgumentsFunction;
 import io.github.lvyahui8.spring.aggregate.interceptor.AggregateQueryInterceptorChain;
 import io.github.lvyahui8.spring.aggregate.model.*;
 import io.github.lvyahui8.spring.aggregate.repository.DataProviderRepository;
 import io.github.lvyahui8.spring.aggregate.service.AbstractAsyncQueryTask;
 import io.github.lvyahui8.spring.aggregate.service.AsyncQueryTaskWrapper;
 import io.github.lvyahui8.spring.aggregate.service.DataBeanAggregateService;
+import io.github.lvyahui8.spring.aggregate.util.DefinitionUtils;
 import lombok.Setter;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.context.ApplicationContext;
 
 import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
@@ -53,6 +57,34 @@ private AggregationContext initQueryContext(DataProvideDefinition rootProvider,
         return aggregationContext;
     }
 
+    @Override
+    public DataProvideDefinition getProvider(MultipleArgumentsFunction<?> multipleArgumentsFunction) throws IllegalAccessException {
+        DataProvideDefinition provider = repository.get(multipleArgumentsFunction.getClass().getName());
+        if(provider != null) {
+            return provider;
+        }
+        Method[] methods = multipleArgumentsFunction.getClass().getMethods();
+        Method applyMethod = null;
+
+
+        for (Method method : methods) {
+            if(! Modifier.isStatic(method.getModifiers()) && ! method.isDefault()) {
+                applyMethod = method;
+                break;
+            }
+        }
+
+        if(applyMethod == null) {
+            throw new IllegalAccessException(multipleArgumentsFunction.getClass().getName());
+        }
+
+        provider = DefinitionUtils.getProvideDefinition(applyMethod);
+        provider.setTarget(multipleArgumentsFunction);
+        provider.setId(multipleArgumentsFunction.getClass().getName());
+        repository.put(provider);
+        return provider;
+    }
+
     @Override
     public <T> T get(String id, Map<String, Object> invokeParams, Class<T> resultType)
             throws InterruptedException, InvocationTargetException, IllegalAccessException {

spring-boot-data-aggregator-example/src/test/java/io/github/lvyahui8/spring/example/DataBeanAggregateQueryFacadeTest.java

@@ -195,4 +195,26 @@ public User apply(@DataConsumer("user") User user,
             Assert.isTrue(e instanceof IllegalArgumentException,"e must be typeof IllegalArgumentException");
         }
     }
+
+    @Test
+    public void testAnonymousProviderCache() throws Exception {
+        Function2<Category, List<String>, String> userFunction = new Function2<Category, List<String>, String>() {
+            @Override
+            public String apply(@DataConsumer("rootCategory") Category category,
+                              @DataConsumer("topCategoryNames") List<String> topCategoryNames) {
+                return category.getName();
+            }
+        };
+        Map<String, Object> map = Collections.singletonMap("userId", 1L);
+        Exception exp = null;
+        for (int i = 0; i < 1000; i ++) {
+            try {
+                String name =  dataBeanAggregateQueryFacade.get(map,userFunction);
+            } catch (Exception e) {
+                exp = e;
+                log.error("exp:" + e.getMessage());
+            }
+        }
+        Assert.isNull(exp,"exp must be null!");
+    }
 }